Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Petr Jelinek
On 2015-09-29 13:44, Fujii Masao wrote: On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera wrote: Petr Jelinek wrote: On 2015-09-02 16:14, Fujii Masao wrote: On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: On Mon, Aug 3, 2015 at 10:31 AM,

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Fujii Masao
On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera wrote: > Petr Jelinek wrote: >> On 2015-09-02 16:14, Fujii Masao wrote: >> >On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: >> >>On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Petr Jelinek
On 2015-09-29 05:05, Alvaro Herrera wrote: Petr Jelinek wrote: On 2015-09-02 16:14, Fujii Masao wrote: On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote: track_commit_timestamp tracks COMMIT

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Alvaro Herrera
Petr Jelinek wrote: > On 2015-09-29 13:44, Fujii Masao wrote: > >On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera > > wrote: > >-#define RecoveryRequiresBoolParameter(param_name, currValue, masterValue) \ > >-do { \ > >-bool _currValue = (currValue); \ > >-bool

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Alvaro Herrera
Hi Fujii, thanks for the review. I have pushed the patch to 9.5 and master. Fujii Masao wrote: > @@ -5321,7 +5333,7 @@ xact_redo_commit(xl_xact_parsed_commit *parsed, > /* Set the transaction commit timestamp and metadata */ > TransactionTreeSetCommitTsData(xid, parsed->nsubxacts,

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Petr Jelinek
On 2015-09-28 18:59, Robert Haas wrote: The patch looks good to me except the following minor points. * or not. Normal path through RecordTransactionCommit() will be related * to a transaction commit XLog record, and so should pass "false" here. The above source comment of

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Robert Haas
On Mon, Sep 28, 2015 at 2:07 PM, Petr Jelinek wrote: > Sorry, missed your reply. To be clear, that was actually Fujii Masao's reply, not mine. I hope he can have a look at this version. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Robert Haas
On Fri, Sep 18, 2015 at 12:53 AM, Fujii Masao wrote: > On Sat, Sep 5, 2015 at 7:48 PM, Petr Jelinek wrote: >> On 2015-09-02 16:14, Fujii Masao wrote: >>> >>> On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: On Mon,

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Alvaro Herrera
Fujii Masao wrote: > +if (replorigin_sesssion_origin == InvalidRepOriginId || > > This is not the problem of the patch, but I started wondering what > "sesssion" in the variable name "replorigin_sesssion_origin" means. > Is it just a typo and it should be "session"? Or it's the abbreviation

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Alvaro Herrera
Petr Jelinek wrote: > On 2015-09-02 16:14, Fujii Masao wrote: > >On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: > >>On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote: > >>>track_commit_timestamp tracks COMMIT PREPARED as expected in standby >

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-17 Thread Fujii Masao
On Sat, Sep 5, 2015 at 7:48 PM, Petr Jelinek wrote: > On 2015-09-02 16:14, Fujii Masao wrote: >> >> On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: >>> >>> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao >>> wrote:

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-05 Thread Petr Jelinek
On 2015-09-02 16:14, Fujii Masao wrote: On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote: track_commit_timestamp tracks COMMIT PREPARED as expected in standby server, but not in master server.

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-02 Thread Fujii Masao
On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas wrote: > On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao wrote: >> track_commit_timestamp tracks COMMIT PREPARED as expected in standby server, >> but not in master server. Is this intentional? It should track

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-08-04 Thread Andres Freund
On 2015-08-04 13:16:52 -0400, Robert Haas wrote: On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao masao.fu...@gmail.com wrote: track_commit_timestamp tracks COMMIT PREPARED as expected in standby server, but not in master server. Is this intentional? It should track COMMIT PREPARED even in

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-08-04 Thread Robert Haas
On Tue, Aug 4, 2015 at 1:18 PM, Andres Freund and...@anarazel.de wrote: On 2015-08-04 13:16:52 -0400, Robert Haas wrote: On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao masao.fu...@gmail.com wrote: track_commit_timestamp tracks COMMIT PREPARED as expected in standby server, but not in master

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-08-04 Thread Robert Haas
On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao masao.fu...@gmail.com wrote: track_commit_timestamp tracks COMMIT PREPARED as expected in standby server, but not in master server. Is this intentional? It should track COMMIT PREPARED even in master? Otherwise, we cannot use commit_timestamp feature