Re: [HACKERS] [PATCH]Tablesample Submission

2013-06-06 Thread Simon Riggs
On 18 September 2012 10:32, Hitoshi Harada umi.tan...@gmail.com wrote: As wiki says, BERNOULLI relies on the statistics of the table, which doesn't sound good to me. Of course we could say this is our restriction and say good-bye to users who hadn't run ANALYZE first, but it is too hard for

Re: [HACKERS] [PATCH]Tablesample Submission

2013-05-22 Thread Simon Riggs
On 17 May 2013 21:46, Jaime Casanova ja...@2ndquadrant.com wrote: On Sun, Nov 4, 2012 at 10:22 PM, Qi Huang huangq...@outlook.com wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't

Re: [HACKERS] [PATCH]Tablesample Submission

2013-05-17 Thread Jaime Casanova
On Sun, Nov 4, 2012 at 10:22 PM, Qi Huang huangq...@outlook.com wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't notice the one for me, my mail box configuration problem. I am

Re: [HACKERS] [PATCH]Tablesample Submission

2013-01-18 Thread Jaime Casanova
On Thu, Jan 17, 2013 at 2:04 PM, Simon Riggs si...@2ndquadrant.com wrote: On 17 January 2013 18:32, Josh Berkus j...@agliodbs.com wrote: On 11/04/2012 07:22 PM, Qi Huang wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is

Re: [HACKERS] [PATCH]Tablesample Submission

2013-01-17 Thread Josh Berkus
On 11/04/2012 07:22 PM, Qi Huang wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't notice the one for me, my mail box configuration problem. I am still kind of busy with my

Re: [HACKERS] [PATCH]Tablesample Submission

2013-01-17 Thread Simon Riggs
On 17 January 2013 18:32, Josh Berkus j...@agliodbs.com wrote: On 11/04/2012 07:22 PM, Qi Huang wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't notice the one for me, my mail box

Re: [HACKERS] [PATCH]Tablesample Submission

2013-01-17 Thread Josh Berkus
So I can't see this going anywhere for 9.3. I've moved it to CF1 of 9.4 marked Waiting on Author Agreed. I wish I'd noticed that it got lost earlier. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] [PATCH]Tablesample Submission

2012-12-09 Thread Jaime Casanova
On Sun, Nov 4, 2012 at 10:22 PM, Qi Huang huangq...@outlook.com wrote: Dear hackers Sorry for not replying the patch review. I didn't see the review until recently as my mail box is full of Postgres mails and I didn't notice the one for me, my mail box configuration problem. I am

Re: [HACKERS] [PATCH]Tablesample Submission

2012-11-04 Thread Qi Huang
: [HACKERS] [PATCH]Tablesample Submission Date: Tue, 21 Aug 2012 23:08:41 +0800 Please add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Hi, Robert I added

Re: [HACKERS] [PATCH]Tablesample Submission

2012-10-17 Thread Alvaro Herrera
Hitoshi Harada escribió: Patch does not apply cleanly against latest master. outfuncs.c, allpath.c and cost.h have rejected parts. The make check failed in a lot of cases up to 26 out of 133. I didn't look into each issue but I suggest rebasing on the latest master and making sure the

Re: [HACKERS] [PATCH]Tablesample Submission

2012-09-18 Thread Hitoshi Harada
On Tue, Aug 21, 2012 at 8:08 AM, Qi Huang huangq...@outlook.com wrote: Please add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Hi, Robert I added it under

Re: [HACKERS] [PATCH]Tablesample Submission

2012-08-21 Thread Robert Haas
On Mon, Aug 20, 2012 at 9:52 PM, Qi Huang huangq...@outlook.com wrote: Hi, hackers I made the final version tablesample patch. It is implementing SYSTEM and BERNOULLI sample method, which is basically feature-complete. The regression test is also included in this patch. There is an

Re: [HACKERS] [PATCH]Tablesample Submission

2012-08-21 Thread Qi Huang
Please add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Hi, Robert I added it under Miscellaneous.