Re: [HACKERS] Addition of pg_dump --no-publications

2017-05-12 Thread Michael Paquier
On Fri, May 12, 2017 at 10:19 PM, Peter Eisentraut wrote: > On 5/11/17 21:59, Michael Paquier wrote: >> On Thu, May 11, 2017 at 3:19 PM, Michael Paquier >> wrote: >>> I imagine that pg_dump -s would be the basic operation that users >>> would do first before creating a subcription on a secondary

Re: [HACKERS] Addition of pg_dump --no-publications

2017-05-12 Thread Tom Lane
David Fetter writes: > While it's consistent with surrounding code, I find the use of ints to > express what is in essence a boolean condition puzzling. Any > insights? IIRC, it's forced by the getopt_long API, particularly the way that the long-options struct has to be declared.

Re: [HACKERS] Addition of pg_dump --no-publications

2017-05-12 Thread David Fetter
On Fri, May 12, 2017 at 10:59:27AM +0900, Michael Paquier wrote: > On Thu, May 11, 2017 at 3:19 PM, Michael Paquier > wrote: > > I imagine that pg_dump -s would be the basic operation that users > > would do first before creating a subcription on a secondary node, but > > what I find surprising is

Re: [HACKERS] Addition of pg_dump --no-publications

2017-05-12 Thread Peter Eisentraut
On 5/11/17 21:59, Michael Paquier wrote: > On Thu, May 11, 2017 at 3:19 PM, Michael Paquier > wrote: >> I imagine that pg_dump -s would be the basic operation that users >> would do first before creating a subcription on a secondary node, but >> what I find surprising is that publications are dump

Re: [HACKERS] Addition of pg_dump --no-publications

2017-05-11 Thread Michael Paquier
On Thu, May 11, 2017 at 3:19 PM, Michael Paquier wrote: > I imagine that pg_dump -s would be the basic operation that users > would do first before creating a subcription on a secondary node, but > what I find surprising is that publications are dumped by default. I > don't find confusing that tho

[HACKERS] Addition of pg_dump --no-publications

2017-05-10 Thread Michael Paquier
Hi all, I imagine that pg_dump -s would be the basic operation that users would do first before creating a subcription on a secondary node, but what I find surprising is that publications are dumped by default. I don't find confusing that those are actually included by default to be consistent wit