Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-17 Thread David Rowley
On 18 April 2017 at 09:01, Alvaro Herrera wrote: > David Rowley wrote: >> While reviewing extended stats I noticed that it was possible to >> create extended stats on many object types, including sequences. I >> mentioned that this should be disallowed. Statistics were then changed >> to be only a

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-17 Thread Alvaro Herrera
David Rowley wrote: > While reviewing extended stats I noticed that it was possible to > create extended stats on many object types, including sequences. I > mentioned that this should be disallowed. Statistics were then changed > to be only allowed on plain tables and materialized views. > > This

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-16 Thread Ashutosh Bapat
On Sat, Apr 15, 2017 at 5:27 AM, Peter Eisentraut wrote: > On 4/10/17 06:18, Ashutosh Bapat wrote: >> This isn't exactly about this particular thread. But I noticed, that >> after we introduced RELKIND_PARTITIONED_TABLE, we required to change a >> number of conditions to include this relkind. We m

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-14 Thread Peter Eisentraut
On 4/10/17 06:18, Ashutosh Bapat wrote: > This isn't exactly about this particular thread. But I noticed, that > after we introduced RELKIND_PARTITIONED_TABLE, we required to change a > number of conditions to include this relkind. We missed some places in > initial commits and fixed those later. I

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-14 Thread Alvaro Herrera
Noah Misch wrote: > On Mon, Apr 10, 2017 at 09:39:22PM +1200, David Rowley wrote: > > While reviewing extended stats I noticed that it was possible to > > create extended stats on many object types, including sequences. I > > mentioned that this should be disallowed. Statistics were then changed >

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-13 Thread Noah Misch
On Mon, Apr 10, 2017 at 09:39:22PM +1200, David Rowley wrote: > While reviewing extended stats I noticed that it was possible to > create extended stats on many object types, including sequences. I > mentioned that this should be disallowed. Statistics were then changed > to be only allowed on plai

Re: [HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-10 Thread Ashutosh Bapat
This isn't exactly about this particular thread. But I noticed, that after we introduced RELKIND_PARTITIONED_TABLE, we required to change a number of conditions to include this relkind. We missed some places in initial commits and fixed those later. I am wondering whether we should creates macros c

[HACKERS] Allowing extended stats on foreign and partitioned tables

2017-04-10 Thread David Rowley
While reviewing extended stats I noticed that it was possible to create extended stats on many object types, including sequences. I mentioned that this should be disallowed. Statistics were then changed to be only allowed on plain tables and materialized views. This should be relaxed again to allo