Re: [HACKERS] Bug when dumping "empty" operator classes

2017-05-29 Thread Michael Paquier
On Fri, May 26, 2017 at 8:14 AM, Daniel Gustafsson wrote: >> On 26 May 2017, at 17:08, Tom Lane wrote: >> I'll commit and back-patch this without a test case. Possibly Frost will >> be excited enough about it to add something to the pg_dump TAP tests, >> but those tests are too opaque for me to

Re: [HACKERS] Bug when dumping "empty" operator classes

2017-05-26 Thread Daniel Gustafsson
> On 26 May 2017, at 17:08, Tom Lane wrote: > > Daniel Gustafsson writes: >> While hacking on pg_upgrade in downstream Greenplum I ran into an error which >> seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). >> pg_dump generates incorrect SQL for an operator class which h

Re: [HACKERS] Bug when dumping "empty" operator classes

2017-05-26 Thread Tom Lane
Daniel Gustafsson writes: > While hacking on pg_upgrade in downstream Greenplum I ran into an error which > seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). > pg_dump generates incorrect SQL for an operator class which has no operators > or > procedures, and which has the

[HACKERS] Bug when dumping "empty" operator classes

2017-05-26 Thread Daniel Gustafsson
While hacking on pg_upgrade in downstream Greenplum I ran into an error which seems like an old, and obscure, bug in pg_dump (unrelated to pg_upgrade). pg_dump generates incorrect SQL for an operator class which has no operators or procedures, and which has the same column and storage types. While