Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-26 Thread Peter Eisentraut
On 10/24/15 7:55 AM, Robert Haas wrote: > On Fri, Oct 23, 2015 at 4:02 PM, Korry Douglas > wrote: >> When you call pg_is_in_recovery(), you should schema-qualify the function >> name, just in case some other version of that function exists in the >> search_path. >

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-26 Thread Thom Brown
On 24 October 2015 at 07:32, Victor Wagner wrote: > В Fri, 23 Oct 2015 22:14:56 +0100 > Thom Brown пишет: > > c> > >> > pg_basebackup -v -x -D standby1 \ >> > -d "host=localhost port=5532 user=rep_user readonly=1" >> >> Yes, this works: >> >> $ pg_basebackup

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-24 Thread Victor Wagner
В Fri, 23 Oct 2015 22:14:56 +0100 Thom Brown пишет: c> > > > pg_basebackup -v -x -D standby1 \ > > -d "host=localhost port=5532 user=rep_user readonly=1" > > Yes, this works: > > $ pg_basebackup -v -x -D standby1 -d "host=localhost port=5532 > user=rep_user readonly=1" >

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-24 Thread Victor Wagner
В Fri, 23 Oct 2015 16:02:33 -0400 Korry Douglas пишет: d> > Now support for service files is implemented and multiple host > > statements in the service file are allowed. > > A couple of minor nits: > > When you call pg_is_in_recovery(), you should

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-24 Thread Robert Haas
On Fri, Oct 23, 2015 at 4:02 PM, Korry Douglas wrote: > When you call pg_is_in_recovery(), you should schema-qualify the function > name, just in case some other version of that function exists in the > search_path. I wonder whether it's really a good idea to put

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-23 Thread Victor Wagner
On Thu, 22 Oct 2015 14:33:11 +0100 Thom Brown wrote: > On 21 October 2015 at 10:07, Victor Wagner wrote: > > On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: > > > >> > >> Attached patch which implements client library failover and > >> loadbalancing as

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-23 Thread Korry Douglas
On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: Attached patch which implements client library failover and loadbalancing as was described in the proposal <20150818041850.ga5...@wagner.pp.ru>. I'm sending imporoved verison of patch. As Olexander Shulgin noted, previous version of

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-23 Thread Thom Brown
On 23 October 2015 at 12:52, Victor Wagner wrote: > On Thu, 22 Oct 2015 14:33:11 +0100 > Thom Brown wrote: > >> On 21 October 2015 at 10:07, Victor Wagner wrote: >> > On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: >> > >> >> >> >>

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-22 Thread Thom Brown
On 21 October 2015 at 10:07, Victor Wagner wrote: > On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: > >> >> Attached patch which implements client library failover and >> loadbalancing as was described in the proposal >> <20150818041850.ga5...@wagner.pp.ru>. >> > > I'm

[HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-21 Thread Victor Wagner
On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: > > Attached patch which implements client library failover and > loadbalancing as was described in the proposal > <20150818041850.ga5...@wagner.pp.ru>. > I'm sending imporoved verison of patch. As Olexander Shulgin noted, previous version