Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Robert Haas
On Fri, Dec 17, 2010 at 9:47 PM, Andreas Karlsson wrote: > Sorry, everyone. > > Ignore my patch. This was already fixed in HEAD and while I wrote my > patch for the HEAD I somehow failed to spot that it was already fixed > when testing without my patch. > > Nice that is fixed, and sorry for the no

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
Sorry, everyone. Ignore my patch. This was already fixed in HEAD and while I wrote my patch for the HEAD I somehow failed to spot that it was already fixed when testing without my patch. Nice that is fixed, and sorry for the noise. Andreas -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Robert Haas
On Fri, Dec 17, 2010 at 9:30 PM, Andreas Karlsson wrote: > On Fri, 2010-12-17 at 21:20 -0500, Robert Haas wrote: >> On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson wrote: >> > What it does is gets rid of the incorrect completion which comes from >> > the completion rule for "SET foo TO bar" by

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
On Fri, 2010-12-17 at 21:20 -0500, Robert Haas wrote: > On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson wrote: > > What it does is gets rid of the incorrect completion which comes from > > the completion rule for "SET foo TO bar" by adding the correct > > completion for "SET SCHEMA" higher up in

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Robert Haas
On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson wrote: > Ah, sorry forgot the most important part of my explanation. > > What it does is gets rid of the incorrect completion which comes from > the completion rule for "SET foo TO bar" by adding the correct > completion for "SET SCHEMA" higher up

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
Ah, sorry forgot the most important part of my explanation. What it does is gets rid of the incorrect completion which comes from the completion rule for "SET foo TO bar" by adding the correct completion for "SET SCHEMA" higher up in the completion function. So instead of an incorrect completion

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Robert Haas
On Fri, Dec 17, 2010 at 8:34 PM, andreas wrote: > It has annoys me every time I want to move a table to another schema > that it completes to SET SCHEMA TO DEFAULT after a couple of presses of > the tab key. So today I decided to get off my lazy ass to write a tiny > patch to fix this behaviour. :

[HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread andreas
Hi, It has annoys me every time I want to move a table to another schema that it completes to SET SCHEMA TO DEFAULT after a couple of presses of the tab key. So today I decided to get off my lazy ass to write a tiny patch to fix this behaviour. :) My first patch for PostgreSQL so a question: Shou