Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-09 Thread Magnus Hagander
2010/3/9 Takahiro Itagaki : > > Magnus Hagander wrote: > >> >> The existing mechanism >> >> works (as demonstrated by the fact that the contrib modules work on >> >> Windows). >> > >> > Did we use non-standard tools except msvc in the build framework >> > for core code? And what should I do for an

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-08 Thread Takahiro Itagaki
Magnus Hagander wrote: > >> The existing mechanism > >> works (as demonstrated by the fact that the contrib modules work on > >> Windows). > > > > Did we use non-standard tools except msvc in the build framework > > for core code? And what should I do for an external project? > > Yes, we use mi

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-08 Thread Magnus Hagander
2010/3/8 Takahiro Itagaki : > > Tom Lane wrote: > >> Takahiro Itagaki writes: >> > I'd like to propose to define PGALWAYSEXPORT macro: >> >     #ifdef WIN32 >> >     #define PGALWAYSEXPORT  __declspec (dllexport) >> >     #endif >> > and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it >>

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-07 Thread Takahiro Itagaki
Tom Lane wrote: > Takahiro Itagaki writes: > > I'd like to propose to define PGALWAYSEXPORT macro: > > #ifdef WIN32 > > #define PGALWAYSEXPORT __declspec (dllexport) > > #endif > > and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it > > instead of PGDLLEXPORT. > > This se

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-07 Thread Tom Lane
Takahiro Itagaki writes: > I'd like to propose to define PGALWAYSEXPORT macro: > #ifdef WIN32 > #define PGALWAYSEXPORT __declspec (dllexport) > #endif > and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it > instead of PGDLLEXPORT. This seems like change for the sake of chang

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-07 Thread Takahiro Itagaki
"Kevin Flanagan" wrote: > 1. you have to define the symbol BUILDING_DLL in your code before > including postgres.h No, BUILDING_DLL does not work. We use PGDLLIMPORT both exported global variables and PG_MODULE_MAGIC/PG_FUNCTION_INFO_V1 for now, but actually we should always use __declspec (dll

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Kevin Flanagan
arch 2010 10:05 To: Kevin Flanagan Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks? Kevin Flanagan wrote: > Ok, re "building with the win32 configuration" ... that sounds like just the > thing I should know about.

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Dave Page
On Fri, Mar 5, 2010 at 9:50 AM, Craig Ringer wrote: > Dave Page wrote: >> On Fri, Mar 5, 2010 at 9:31 AM, Craig Ringer >> wrote: >> >>> Why _not_ distribute gettext headers, though? Sources I can understand >>> for size reasons, but the headers are small and fuss free, and you need >>> the _right

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Craig Ringer
Kevin Flanagan wrote: > Ok, re "building with the win32 configuration" ... that sounds like just the > thing I should know about. All I've done is downloaded and installed the > 1-click installer for Windows from > http://www.enterprisedb.com/products/pgdownload.do#windows ... so while I'm > su

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Kevin Flanagan
nks Kevin -Original Message- From: Craig Ringer [mailto:cr...@postnewspapers.com.au] Sent: 05 March 2010 04:02 To: Kevin Flanagan Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks? Kevin Flanagan wrote: > the comp

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Craig Ringer
Dave Page wrote: > On Fri, Mar 5, 2010 at 9:31 AM, Craig Ringer > wrote: > >> Why _not_ distribute gettext headers, though? Sources I can understand >> for size reasons, but the headers are small and fuss free, and you need >> the _right_ _versions_ to build against the Pg backend. > > No reason

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Dave Page
On Fri, Mar 5, 2010 at 9:31 AM, Craig Ringer wrote: > Why _not_ distribute gettext headers, though? Sources I can understand > for size reasons, but the headers are small and fuss free, and you need > the _right_ _versions_ to build against the Pg backend. No reason, other than I didn't realise

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Craig Ringer
Dave Page wrote: > On Fri, Mar 5, 2010 at 9:05 AM, Craig Ringer > wrote: > >> How do _you_ go about building server extensions for Pg? Where do you >> get the headers for gettext etc? > > Same place I get the binaries - gnuwin32 mostly. > >> I'm increasingly thinking the win32 package _should_

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Dave Page
On Fri, Mar 5, 2010 at 9:05 AM, Craig Ringer wrote: > How do _you_ go about building server extensions for Pg? Where do you > get the headers for gettext etc? Same place I get the binaries - gnuwin32 mostly. > I'm increasingly thinking the win32 package _should_ be split into > server binary an

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Craig Ringer
Dave Page wrote: > On Fri, Mar 5, 2010 at 4:02 AM, Craig Ringer > wrote: >> Kevin Flanagan wrote: >> >>> the compiler >>> complained about various missing include files, starting with >>> ‘libintl.h’. Having read the post at >>> http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I >

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-05 Thread Dave Page
On Fri, Mar 5, 2010 at 4:02 AM, Craig Ringer wrote: > Kevin Flanagan wrote: > >> the compiler >> complained about various missing include files, starting with >> ‘libintl.h’. Having read the post at >> http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I >> created an empty libint.h

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-04 Thread Craig Ringer
Kevin Flanagan wrote: > the compiler > complained about various missing include files, starting with > ‘libintl.h’. Having read the post at > http://archives.postgresql.org/pgsql-general/2009-03/msg00332.php I > created an empty libint.h in an include dir NFI why Pg for win32 doesn't bundle a cop

[HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-04 Thread Kevin Flanagan
I have PostgreSQL 8.4 installed on Windows XP, and am using Visual Studio 2005 to write a C-Language function. I have the most basic hello-world type example (just the 'add_one' function from http://www.postgresql.org/docs/8.4/interactive/xfunc-c.html) in a DLL, set to compile to C code rather than