Hi,
2014-08-01 16:26 GMT+09:00 Fabien COELHO
>
> Maybe somebody who knows more math than I do (like you, probably!) can
>> come up with something more clever.
>>
>
> I can certainly suggest other formula, but that does not mean beautiful
> code, thus would probably be rejected. I'll see.
>
> An
Hello,
Version one is "k' = 1 + (a * k + b) modulo n" with "a" prime with
respect to "n", "n" being the number of keys. This is nearly possible,
but for the modulo operator which is currently missing, and that I'm
planning to submit for this very reason, but probably another time.
That's pr
On Thu, Jul 31, 2014 at 10:01 AM, Fabien COELHO wrote:
>> One of the concerns that I have about the proposal of simply slapping a
>> gaussian or exponential modifier onto \setrandom aid 1 :naccounts is that,
>> while it will allow you to make part of the relation hot and another part of
>> the rel
Hello Robert,
[...]
One of the concerns that I have about the proposal of simply slapping a
gaussian or exponential modifier onto \setrandom aid 1 :naccounts is
that, while it will allow you to make part of the relation hot and
another part of the relation cold, you really can't get any more
On Wed, Jul 30, 2014 at 9:00 PM, Mitsumasa KONDO
wrote:
> Hmm... It doesn't have harm for pgbench source code. And, in general,
> checking script is useful for avoiding bug.
Not if nobody runs it, or if people run it but don't know what the
output should look like. I think anyone who knows enoug
On Wed, Jul 30, 2014 at 4:18 PM, Fabien COELHO wrote:
>> nor am I in favor of patch B.
>
> Yep. Would providing these as additional contrib files be more acceptable?
> Something like "tpc-b-gauss.sql"... Otherwise there is no example available
> to show the feature.
To be honest, it just feels li
Hi,
2014-07-31 5:18 GMT+09:00 Fabien COELHO :
>
> I've committed the changes to pgbench.c and the documentation changes
>> with some further wordsmithing.
>>
>
> Ok, thanks a lot for your reviews and your help with improving the
> documentation.
Yeah, thanks for all relative members.
> I don'
Hello Robert,
I've committed the changes to pgbench.c and the documentation changes
with some further wordsmithing.
Ok, thanks a lot for your reviews and your help with improving the
documentation.
I don't think including the other changes in patch A is a good idea,
Fine. It was mostly
On Tue, Jul 29, 2014 at 4:41 AM, Fabien COELHO wrote:
>> Attached B patch does turn incorrect setrandom syntax into errors instead
>> of ignoring extra parameters.
>>
>> First A patch is repeated to help commitfest references.
>
> Oops, I applied the change on the wrong part:-(
>
> Here is the cha
Attached B patch does turn incorrect setrandom syntax into errors instead of
ignoring extra parameters.
First A patch is repeated to help commitfest references.
Oops, I applied the change on the wrong part:-(
Here is the change on part A which checks setrandom syntax, and B for
completenes
Hello Robert,
3. Similarly, I suggest that the use of gaussian or uniform be an
error when argc < 6 OR argc > 6. I also suggest that the
parenthesized distribution type be dropped from the error message in
all cases.
I wish to agree, but my interpretation of the previous code is that they
we
Hello Robert,
I wish to agree, but my interpretation of the previous code is that
they were ignored before, so ISTM that we are stuck with keeping the
same unfortunate behavior.
I don't agree. I'm not in a huge hurry to fix all the places where
pgbench currently lacks error checks just bec
On Wed, Jul 23, 2014 at 12:39 PM, Fabien COELHO wrote:
>> 3. Similarly, I suggest that the use of gaussian or uniform be an
>> error when argc < 6 OR argc > 6. I also suggest that the
>> parenthesized distribution type be dropped from the error message in
>> all cases.
>
> I wish to agree, but my
Hi,
Thank you for your grate documentation and fix working!!!
It becomes very helpful for understanding our feature.
I add two feature in gauss_B_4.patch.
1) Add gaussianProbability() function
It is same as exponentialProbability(). And the feature is as same as
before.
2) Add result of "max/mi
Hello Robert,
Some review comments:
Thanks a lot for your return.
Please find attached two new parts of the patch (A for setrandom
extension, B for pgbench embedded test case extension).
1. I suggest that getExponentialrand and getGaussianrand be renamed to
getExponentialRand and getGaus
15 matches
Mail list logo