Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-05 Thread Bruce Momjian
On Fri, Aug 5, 2016 at 02:07:18PM -0400, Robert Haas wrote: > On Fri, Aug 5, 2016 at 11:06 AM, Bruce Momjian wrote: > > On Fri, Aug 5, 2016 at 10:57:35AM -0400, Peter Eisentraut wrote: > >> On 8/2/16 12:51 PM, Bruce Momjian wrote: > >> > Yes, that's a strong argument for using a space. I have a

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-05 Thread Robert Haas
On Fri, Aug 5, 2016 at 11:06 AM, Bruce Momjian wrote: > On Fri, Aug 5, 2016 at 10:57:35AM -0400, Peter Eisentraut wrote: >> On 8/2/16 12:51 PM, Bruce Momjian wrote: >> > Yes, that's a strong argument for using a space. I have adjusted the >> > patch to use spaces in all reasonable places. Patch

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-05 Thread Bruce Momjian
On Fri, Aug 5, 2016 at 10:57:35AM -0400, Peter Eisentraut wrote: > On 8/2/16 12:51 PM, Bruce Momjian wrote: > > Yes, that's a strong argument for using a space. I have adjusted the > > patch to use spaces in all reasonable places. Patch attached, which I > > have gzipped because it was 133 KB.

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-05 Thread Peter Eisentraut
On 8/2/16 12:51 PM, Bruce Momjian wrote: > Yes, that's a strong argument for using a space. I have adjusted the > patch to use spaces in all reasonable places. Patch attached, which I > have gzipped because it was 133 KB. (Ah, see what I did there?) :-) > > I am thinking of leaving the 9.6 doc

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-02 Thread Bruce Momjian
On Tue, Aug 2, 2016 at 11:29:01AM +0200, Christoph Berg wrote: > > The issue is that we output "10 bytes", not "10bytes", but for units we > > use "977KB". That seems inconsistent, but it is the normal policy > > people use. I think this is because "977KB" is really "977K bytes", but > > we just

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-02 Thread Christoph Berg
Re: Peter Eisentraut 2016-08-01 > > PostgreSQL uses the spaces inconsistently, though. pg_size_pretty uses > > spaces: > > > > # select pg_size_pretty((2^20)::bigint); > > pg_size_pretty > > > > 1024 kB > > because it's "pretty" :) :) > > SHOW does not: > > > > # show wor

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-01 Thread Peter Eisentraut
On 8/1/16 7:35 AM, Christoph Berg wrote: > PostgreSQL uses the spaces inconsistently, though. pg_size_pretty uses spaces: > > # select pg_size_pretty((2^20)::bigint); > pg_size_pretty > > 1024 kB because it's "pretty" :) > SHOW does not: > > # show work_mem; > work_mem > ───

Re: [HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-01 Thread Bruce Momjian
On Mon, Aug 1, 2016 at 01:35:53PM +0200, Christoph Berg wrote: > Re: Bruce Momjian 2016-07-30 <20160730181643.gd22...@momjian.us> > > I also just applied a doc patch that increases case and spacing > > consistency in the use of kB/MB/GB/TB. > > Hi, > > PostgreSQL uses the spaces inconsistently,

[HACKERS] pg_size_pretty, SHOW, and spaces

2016-08-01 Thread Christoph Berg
Re: Bruce Momjian 2016-07-30 <20160730181643.gd22...@momjian.us> > I also just applied a doc patch that increases case and spacing > consistency in the use of kB/MB/GB/TB. Hi, PostgreSQL uses the spaces inconsistently, though. pg_size_pretty uses spaces: # select pg_size_pretty((2^20)::bigint);