On Mon, Mar 17, 2014 at 12:55 PM, Andres Freund wrote:
> On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
>> Alvaro Herrera writes:
>> > I noticed (by running "cd src/include ; make check" with the attached
>> > patch applied) that since commit b89e151054 ("Introduce logical
>> > decoding.") tqual.h
On 2014-03-17 12:56:12 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2014-03-17 13:40:53 -0300, Alvaro Herrera wrote:
> >> There is of course a third choice which is to dictate that this function
> >> ought to be declared in reorderbuffer.h; but that would have the
> >> unpleasant side-eff
On 2014-03-17 12:57:15 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
> >> I guess the real question is why such a prototype is in tqual.h in
> >> the first place. ISTM this should be pushed somewhere specific to
> >> reorderbuffer.c. I'm -1 on h
Andres Freund writes:
> On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
>> I guess the real question is why such a prototype is in tqual.h in
>> the first place. ISTM this should be pushed somewhere specific to
>> reorderbuffer.c. I'm -1 on having struct HTAB bleed into tqual.h
>> via either of th
Andres Freund writes:
> On 2014-03-17 13:40:53 -0300, Alvaro Herrera wrote:
>> There is of course a third choice which is to dictate that this function
>> ought to be declared in reorderbuffer.h; but that would have the
>> unpleasant side-effect that tqual.c would need to #include that.
> I am pr
On 2014-03-17 12:50:37 -0400, Tom Lane wrote:
> Alvaro Herrera writes:
> > I noticed (by running "cd src/include ; make check" with the attached
> > patch applied) that since commit b89e151054 ("Introduce logical
> > decoding.") tqual.h now emits this warning when compiled standalone:
>
> > /pgsq
Alvaro Herrera writes:
> I noticed (by running "cd src/include ; make check" with the attached
> patch applied) that since commit b89e151054 ("Introduce logical
> decoding.") tqual.h now emits this warning when compiled standalone:
> /pgsql/source/HEAD/src/include/utils/tqual.h:101:13: warning: â
Hi,
On 2014-03-17 13:40:53 -0300, Alvaro Herrera wrote:
> I noticed (by running "cd src/include ; make check" with the attached
> patch applied) that since commit b89e151054 ("Introduce logical
> decoding.") tqual.h now emits this warning when compiled standalone:
I think we should add such a ch
I noticed (by running "cd src/include ; make check" with the attached
patch applied) that since commit b89e151054 ("Introduce logical
decoding.") tqual.h now emits this warning when compiled standalone:
/pgsql/source/HEAD/src/include/utils/tqual.h:101:13: warning: ‘struct HTAB’
declared inside pa
