Re: pspg - psql pager

I can't thank you enough pavel. I use psql on a daily basis since 8 years ago, with a lot "less" pain, Love vim keybindings and freeze column features. Works smoothly in ubuntu 16.04 x86_64. ​

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Tue, Nov 14, 2017 at 10:01 AM, Peter Geoghegan wrote: > On Tue, Nov 14, 2017 at 1:41 AM, Rushabh Lathia > wrote: >> Thanks Peter and Thomas for the review comments. > > No problem. More feedback: I see that Robert just committed support for a

Re: [HACKERS] [POC] Faster processing at Gather node

On Tue, Nov 14, 2017 at 7:31 AM, Rafia Sabih wrote: > Case 2: patches applied as in case 1 + >a) increased PARALLEL_TUPLE_QUEUE_SIZE to 655360 > No significant change in performance in any query >b) increased PARALLEL_TUPLE_QUEUE_SIZE to 65536 * 50 >

Re: [HACKERS] Parallel Hash take II

On Wed, Nov 15, 2017 at 1:35 PM, Andres Freund wrote: > But this does bug me, and I think it's what made me pause here to make a > bad joke. The way that parallelism treats work_mem makes it even more > useless of a config knob than it was before. Parallelism, especially >

Re: [HACKERS] pg audit requirements

2017-11-15 16:21 GMT+01:00 David Steele : > On 11/13/17 1:43 PM, Pavel Stehule wrote: > >> 2017-11-13 19:19 GMT+01:00 David Steele > > > > >> Thanks for the input! I'm not sure this is the best forum for >> comments, however, since pgAudit is

Re: Updated macOS start scripts

> On Nov 15, 2017, at 11:00 AM, Tom Lane wrote: > > Mark Dilger writes: >>> On Nov 15, 2017, at 8:32 AM, Tom Lane wrote: >>> The stuff in contrib/start-scripts/osx/ does not, as far as I know, >>> work at all on any recent

Re: [HACKERS] Parallel Hash take II

On Wed, Nov 15, 2017 at 10:35 AM, Andres Freund wrote: >> I realize you're sort of joking here, but I think it's necessary to >> care about fairness between pieces of code. > > Indeed I kinda was. When I posted v1 of parallel CREATE INDEX, it followed the hash join model of

Re: [HACKERS] Parallel Hash take II

Hi, On 2017-11-15 10:57:35 -0800, Peter Geoghegan wrote: > > I don't really have a good answer to "but what should we otherwise do", > > but I'm doubtful this is quite the right answer. > > I think that the work_mem model should be replaced by something that > centrally budgets memory. It would

Re: pspg - psql pager

2017-11-15 18:38 GMT+01:00 Gibrain : > I can't thank you enough pavel. > I use psql on a daily basis since 8 years ago, with a lot "less" pain, > Love vim keybindings and freeze column features. > Works smoothly in ubuntu 16.04 x86_64. > > > ​ > :) pspg is postcardware -

Re: Updated macOS start scripts

> On Nov 15, 2017, at 8:32 AM, Tom Lane wrote: > > The stuff in contrib/start-scripts/osx/ does not, as far as I know, > work at all on any recent release of macOS, because SystemStarter > is long gone. I propose replacing it with the attached, which > I've tested on

Re: [HACKERS] Parallel Hash take II

On 2017-11-15 08:37:11 -0500, Robert Haas wrote: > On Tue, Nov 14, 2017 at 4:24 PM, Andres Freund wrote: > >> I agree, and I am interested in that subject. In the meantime, I > >> think it'd be pretty unfair if parallel-oblivious hash join and > >> sort-merge join and every

Re: Updated macOS start scripts

Mark Dilger writes: >> On Nov 15, 2017, at 8:32 AM, Tom Lane wrote: >> The stuff in contrib/start-scripts/osx/ does not, as far as I know, >> work at all on any recent release of macOS, because SystemStarter >> is long gone. I propose replacing it

Re: [HACKERS] [POC] Faster processing at Gather node

Hi, On 2017-11-15 13:48:18 -0500, Robert Haas wrote: > I think that we need a little bit deeper analysis here to draw any > firm conclusions. Indeed. > I suspect that one factor is that many of the queries actually send > very few rows through the Gather. Yep. I kinda wonder if the same

Re: [HACKERS] Issues with logical replication

On Mon, Oct 9, 2017 at 9:19 PM, Stas Kelvich wrote: > I investigated this case and it seems that XactLockTableWait() in > SnapBuildWaitSnapshot() > not always work as expected. XactLockTableWait() waits on LockAcquire() for > xid to be > completed and if we finally

Re: [HACKERS] Parallel Hash take II

On Thu, Nov 16, 2017 at 8:09 AM, Robert Haas wrote: > On Wed, Nov 15, 2017 at 1:35 PM, Andres Freund wrote: >> But this does bug me, and I think it's what made me pause here to make a >> bad joke. The way that parallelism treats work_mem makes it even

Re: Fix number skipping in to_number

I wrote: > Oliver Ford writes: >> On Monday, 13 November 2017, Tom Lane wrote: >>> I don't follow your concern? If "$" is not the correct currency >>> symbol for the locale, we shouldn't accept it as a match to an L format. >>> Your patch is tightening what

Re: Further simplification of c.h's #include section

I wrote: > Robert Haas writes: >> On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane wrote: >>> How do you feel about "win32_more.h"? >> Seems morally equivalent to what you had before. I think what I would >> be looking for is a filename that somehow conveys

Re: [HACKERS] Parallel Hash take II

On Thu, Nov 16, 2017 at 7:35 AM, Andres Freund wrote: > On 2017-11-15 08:37:11 -0500, Robert Haas wrote: >> I mean, the very first version of this patch that Thomas submitted was >> benchmarked by Rafia and had phenomenally good performance >> characteristics. That turned out

Re: [HACKERS] Inconsistencies between pg_settings and postgresql.conf

On Wed, Sep 13, 2017 at 11:50 AM, Adrian Escoms wrote: > I realized that the parameter 'shared_preload_libraries' used to belong to > category 'Resource Usage / Kernel Resources' but since postgresql version > 9.4 it was changed in pg_settings to 'Client Connection Defaults /

Re: Updated macOS start scripts

> On Nov 15, 2017, at 1:37 PM, Tom Lane wrote: > > Mark Dilger writes: >> I have tested this on 10.11.6. I had no trouble following the instructions >> in the README and everything worked as described. >> As far as I can tell, this patch has not yet

Re: [HACKERS] Timeline ID in backup_label file

On Wed, Nov 15, 2017 at 11:16 PM, David Steele wrote: > Find my review below. > > On 10/26/17 2:03 PM, Michael Paquier wrote: >> >> Thanks for the feedback. Attached is a patch to achieve so, I have >> added as well a STOP TIMELINE field in the backup history file. Note >>

Re: Further simplification of c.h's #include section

On Wed, Nov 15, 2017 at 4:32 PM, Tom Lane wrote: >>> I have no objection to trying to clean things up in that area, but I >>> request a less-lame filename than win32_2.h > >> Sure, if you have a suggestion. > > How do you feel about "win32_more.h"? Seems morally equivalent to

Re: [HACKERS] Transaction control in procedures

On 11/8/17 18:48, Simon Riggs wrote: > What would happen if some of the INSERTs failed? Where would control > go to? (Maybe this is just "no change" in this particular proc) An exception is raised and unless the exception is caught (depending on the PL), control leaves the procedure. What is

Re: Updated macOS start scripts

Mark Dilger writes: > I am reasonably content with your earlier idea of not keeping support > for ancient versions of OS X, but if you want to do what you describe > above, I'd be happy to review that on my 10.6 box to verify that > everything works at least that far

Re: [HACKERS] [PATCH] Generic type subscripting

> On 14 November 2017 at 22:25, Dmitry Dolgov <9erthali...@gmail.com> wrote: > But now I wonder if `resnull` is really needed in `jsonb_get_element`, > `array_get_element` and it seems to me that I can even get rid of it so On the second thought, no, looks like I'm wrong and it should be like

Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility)

On Mon, Oct 30, 2017 at 9:19 PM, Badrul Chowdhury wrote: > Thank you for the comprehensive review! We are very much in the early stages > of contributing to the PG community and we clearly have lots to learn, but we > look forward to becoming proficient and active members

Re: Further simplification of c.h's #include section

I wrote: > Robert Haas writes: >> On Wed, Nov 15, 2017 at 10:51 AM, Tom Lane wrote: >>> 1. Move what's currently in src/include/port/win32.h (a/k/a >>> pg_config_os.h) to a new file, say src/include/port/win32_2.h. >> I have no objection to trying to

Re: [HACKERS] Transaction control in procedures

On 11/15/17 09:54, Merlin Moncure wrote: > ... I noticed that: > *) now() did not advance with commit and, > *) xact_start via pg_stat_activity did not advance > > Shouldn't both of those advance with the in-loop COMMIT? I think you are correct. I'll include that in the next patch version. It

Re: [HACKERS] Parallel Hash take II

On Thu, Nov 16, 2017 at 7:57 AM, Peter Geoghegan wrote: > The contrast with the situation with Thomas and his hash join patch is > interesting. Hash join is *much* more sensitive to the availability of > memory than a sort operation is. > >> I don't really have a good answer to "but

no library dependency in Makefile?

Hi, Recently, I found 'psql' is not rebuilt automatically after editing 'fe_utils/psqlscan.l'. The detail is: 'psqlscan.l' is part of 'libpgfeutils.a' which will be built into 'psql' statically. But there is no dependency rule between them. It's OK for 'libpq' since 'libpq' is a dynamic

Re: [HACKERS] Transform for pl/perl

On 14 Nov 2017 11:35, "Anthony Bykov" wrote: On Fri, 10 Nov 2017 14:40:21 +0100 Pavel Stehule wrote: > Hi > > 2017-10-24 14:27 GMT+02:00 Anthony Bykov : > > > There are some moments I should mention: > > 1. {"1":1}::jsonb

Re: [HACKERS] Transform for pl/perl

2017-11-15 10:24 GMT+01:00 Oleg Bartunov : > > > On 14 Nov 2017 11:35, "Anthony Bykov" wrote: > > On Fri, 10 Nov 2017 14:40:21 +0100 > Pavel Stehule wrote: > > > Hi > > > > 2017-10-24 14:27 GMT+02:00 Anthony Bykov

Re: [HACKERS] [PATCH] Add recovery_min_apply_delay_reconnect recovery option

On Fri, Oct 20, 2017 at 3:46 AM, Eric Radman wrote: > On Tue, Oct 17, 2017 at 12:34:17PM +0900, Michael Paquier wrote: >> On Tue, Oct 17, 2017 at 12:51 AM, Eric Radman wrote: >> > This administrative compromise is necessary because the WalReceiver is

Re: [HACKERS] Transform for pl/perl

Hi > Hello, > Thank you for your review. I have fixed most of your comments, except > for the 5-th part, about data::dumper - I just couldn't understand > your point, but I've added more tests with more complex objects if this > helps. > > Please, take a look at new patch. You can find it in

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

On Wed, Nov 15, 2017 at 5:39 PM, Michael Paquier wrote: > On Wed, Nov 15, 2017 at 5:21 PM, Masahiko Sawada > wrote: >> On Wed, Nov 15, 2017 at 2:38 PM, Michael Paquier >> wrote: >>> On Wed, Nov 15, 2017 at 12:12 PM,

Re: [HACKERS] Timeline ID in backup_label file

On Thu, Nov 16, 2017 at 9:20 AM, David Steele wrote: > For this patch at least, I think we should do #1. Getting rid of the order > dependency is attractive but there may be other programs that are depending > on the order. I know you are not proposing to change the order

Re: [HACKERS] Partition-wise aggregation/grouping

On 16 November 2017 at 05:57, Konstantin Knizhnik wrote: > The main problem IMHO is that there are a lot of different threads and > patches related with this topic:( > And it is very difficult to combine all of them together to achieve the > final goal: efficient

Re: Further simplification of c.h's #include section

On Wed, Nov 15, 2017 at 5:22 PM, Tom Lane wrote: > Thoughts? Sure, having a win32_port.h as a sub-include of port.h seems fine. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] moving some partitioning code to executor

On 2017/11/16 0:29, Robert Haas wrote: > On Tue, Nov 14, 2017 at 7:59 PM, Amit Langote > wrote: >> On 2017/11/15 2:09, Alvaro Herrera wrote: >>> Amit Langote wrote: >>> Since that 0001 patch was committed [1], here is the rebased patch. Will add this to

Re: [HACKERS] Timeline ID in backup_label file

On 11/15/17 6:01 PM, Michael Paquier wrote: On Wed, Nov 15, 2017 at 11:16 PM, David Steele wrote: Find my review below. On 10/26/17 2:03 PM, Michael Paquier wrote: Thanks for the feedback. Attached is a patch to achieve so, I have added as well a STOP TIMELINE field in

Re: [HACKERS] path toward faster partition pruning

On 16 November 2017 at 15:54, Kyotaro HORIGUCHI wrote: > Anyway I added __attribute((noinline)) to the two > functions and got the following result. > >> bms_add_range in 1.24 (12.4 ns per loop) >> bms_add_range2 in 0.8 (8 ns per loop) I see similar here with

Re: pspg - psql pager

> On Nov 15, 2017, at 1:41 AM, Pavel Stehule wrote: > > I hope so this pager is useful - I know some users who use it few months > intensively. But the source code has proof concept quality. It should be > cleaned next year. This is great! I’ve submitted it to

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

On Thu, Nov 16, 2017 at 10:57 AM, Masahiko Sawada wrote: > Agreed. Attached the updated patch, please review it. + /* +* Quick exit if session is not keeping around a non-exclusive backup +* already started. +*/ + if (sessionBackupState !=

Re: Further simplification of c.h's #include section

On Thu, Nov 16, 2017 at 2:23 PM, David Rowley wrote: > I do get some warnings: > > (ClCompile target) -> > src/test/modules/test_session_hooks/test_session_hooks.c(112): warning > C4113: 'void (__cdecl *)()' differs in parameter lists from >

wrong formatting psql expanded mode short columns

Hi postgres=# select i, i from generate_series(1,5) g(i); ┌─[ RECORD 1 ]─┐ │ i │ 1 │ │ i │ 1 │ ╞═[ RECORD 2 ]═╡ │ i │ 2 │ │ i │ 2 │ ╞═[ RECORD 3 ]═╡ │ i │ 3 │ │ i │ 3 │ ╞═[ RECORD 4 ]═╡ │ i │ 4 │ │ i │ 4 │ ╞═[ RECORD 5 ]═╡ │ i │ 5 │ │ i │ 5 │ └───┴───┘ The last column need to be more wider

Re: [HACKERS] ginInsertCleanup called from vacuum could still miss tuples to be deleted

On Mon, Nov 13, 2017 at 3:25 AM, Masahiko Sawada wrote: > In ginInsertCleanup(), we lock the GIN meta page by LockPage and could > wait for the concurrent cleaning up process if stats == NULL. And the > source code comment says that this happen is when ginINsertCleanup is >

Re: [HACKERS] Transform for pl/perl

Hello, hackers. > > I'm curious, how much benefit we could get from this ? There are several > > publicly available json datasets, which can be used to measure performance > > gaining. I have bookmarks and review datasets available from > > http://www.sai.msu.su/~megera/postgres/files/, look at

could not receive data from WAL stream: SSL SYSCALL error: Success

Hi hackers, I heard a report of an error like this from a user of openssl 1.1.0f-3+deb9u on Debian: pg_basebackup: could not receive data from WAL stream: SSL SYSCALL error: Success I noticed that some man pages for SSL_get_error say this under SSL_ERROR_SYSCALL: Some

Re: Rewriting PL/Python's typeio code

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:tested, passed Hello, I have checked your patch. Everything looks fine for me, but

Re: Schedule for migration to pglister

On Mon, Nov 06, 2017 at 10:36:38AM -0500, Stephen Frost wrote: > Our planned migration schedule is as follows: > > Nov 6 - > pgsql-www > > Nov 13 - > pgsql-hackers When each list migrated, its mbox archives stopped receiving new messages:

Re: [HACKERS] Partition-wise aggregation/grouping

On Sun, Nov 12, 2017 at 1:59 AM, Konstantin Knizhnik < k.knizh...@postgrespro.ru> wrote: > On 10/27/2017 02:01 PM, Jeevan Chalke wrote: > >> Hi, >> >> Attached new patch-set here. Changes include: >> >> 1. Added separate patch for costing Append node as discussed up-front in >> the >> patch-set.

RE: User defined data types in Logical Replication

Hi, > We are getting the bellow error while trying use Logical Replication with > user defined data types in a C program (when call elog function). > > ERROR: XX000: cache lookup failed for type X > Sorry for continuously disturbing in this topic, but am I missing something here? I

Further simplification of c.h's #include section

Yesterday's commit 91aec93e6 got rid of quite a bit of unprincipled cruft that had accumulated in c.h's #include section. It occurs to me that we could clean it up some more, eliminating almost all the Windows-specific hacking there, by doing this: 1. Move what's currently in

Re: Separate leader buffer info and worker wait info in EXPLAIN output?

On Tue, Nov 14, 2017 at 6:09 PM, Thomas Munro wrote: > EXPLAIN can show per-worker information and aggregated information, > but doesn't show the leader's information individually. Should it? > > Example: > > Partial Aggregate [...] > Output: PARTIAL count(*)

Re: Further simplification of c.h's #include section

Robert Haas writes: > On Wed, Nov 15, 2017 at 10:51 AM, Tom Lane wrote: >> 1. Move what's currently in src/include/port/win32.h (a/k/a >> pg_config_os.h) to a new file, say src/include/port/win32_2.h. > I have no objection to trying to clean things up

Re: [HACKERS] Timeline ID in backup_label file

Hi Michael, Find my review below. On 10/26/17 2:03 PM, Michael Paquier wrote: > > Thanks for the feedback. Attached is a patch to achieve so, I have > added as well a STOP TIMELINE field in the backup history file. Note > that START TIMELINE gets automatically into the backup history file. >

Re: Schedule for migration to pglister

Noah, * Noah Misch (n...@leadboat.com) wrote: > On Mon, Nov 06, 2017 at 10:36:38AM -0500, Stephen Frost wrote: > > Our planned migration schedule is as follows: > > > > Nov 6 - > > pgsql-www > > > > Nov 13 - > > pgsql-hackers > > When each list migrated, its mbox archives stopped receiving

Re: pspg - psql pager

2017-11-15 15:42 GMT+01:00 Merlin Moncure : > On Wed, Nov 15, 2017 at 4:45 AM, Andreas Joseph Krogh > wrote: > > På onsdag 15. november 2017 kl. 10:41:45, skrev Pavel Stehule > > : > > > > Hi > > > > I finished new pager, that can

Re: pspg - psql pager

On Wed, Nov 15, 2017 at 4:45 AM, Andreas Joseph Krogh wrote: > På onsdag 15. november 2017 kl. 10:41:45, skrev Pavel Stehule > : > > Hi > > I finished new pager, that can be interesting for postgresql expert users. > Thanks for making this, "-X

Re: [HACKERS] Transaction control in procedures

On Wed, Nov 15, 2017 at 7:38 AM, Merlin Moncure wrote: > On Tue, Nov 14, 2017 at 5:27 PM, Peter Eisentraut >>> Can we zero in on this? The question implied, 'can you do this >>> without being in a transaction'? PERFORM do_stuff() is a implicit >>> transaction, so it ought to

Re: [HACKERS] Custom compression methods

On Wed, Nov 15, 2017 at 4:09 AM, Ildus Kurbangaliev wrote: > So in the next version of the patch I can just unlink the options from > compression methods and dropping compression method will not affect > already compressed tuples. They still could be decompressed.

Re: [HACKERS] Transaction control in procedures

2017-11-15 14:38 GMT+01:00 Merlin Moncure : > On Tue, Nov 14, 2017 at 5:27 PM, Peter Eisentraut > wrote: > > On 11/14/17 16:33, Merlin Moncure wrote: > >>> One detail in your example is that when you enter the procedure, you > are > >>>

Re: [HACKERS] Partition-wise aggregation/grouping

On Thu, Nov 2, 2017 at 7:36 AM, Robert Haas wrote: > On Wed, Nov 1, 2017 at 6:20 PM, Jeevan Chalke > wrote: > > Yep. > > But as David reported earlier, if we remove the first part i.e. adding > > cpu_operator_cost per tuple, Merge Append

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Tue, Nov 14, 2017 at 12:28 AM, Thomas Munro wrote: > Thanks. You're right. Rebased and updated to describe what "off" does. Committed. I noticed that you didn't add the new GUC to postgresql.conf.sample, so I did that. But then I thought it didn't really

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Wed, Nov 15, 2017 at 8:35 AM, Jesper Pedersen wrote: > Small typo. Thanks. That just proves no task is so simple that I can't foul it up. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Logical Replication and triggers

I would like somebody to consider Petr Jelineks patch for worker.c from here (https://www.postgresql.org/message-id/619c557d-93e6-1833-1692-b010b176ff77%402ndquadrant.com) I'm was facing the same issue with 10.1 and BEFORE INSERT OR UPDATE triggers. BR Thomas Rosenstein

Re: pspg - psql pager

2017-11-15 Merlin Moncure : > I use psql all day, every day. PSPG IS AWESOME, IF YOU USE PSQL GET > IT AND DON'T LOOK BACK. [..] > Thank you Pavel. +1! I especially love it for the improved handling of wide tables (which are really annoying with “less”). Also --no-mouse is

Re: [HACKERS] pg audit requirements

On 11/13/17 1:43 PM, Pavel Stehule wrote: 2017-11-13 19:19 GMT+01:00 David Steele Thanks for the input!  I'm not sure this is the best forum for comments, however, since pgAudit is not part of Postgres. Issues can be opened at the github site:

Re: pspg - psql pager

On 15 November 2017 at 09:41, Pavel Stehule wrote: > Hi > > I finished new pager, that can be interesting for postgresql expert users. > > It demonstrate some possibilities of TUI and I hope it shows some possible > directions of future possibilities of psql. > > It is

Re: Rewriting PL/Python's typeio code

Anthony Bykov writes: > I have checked your patch. Everything looks fine for me, but I have some > doubts: Thanks for reviewing! > 1. In file plpy_exec.c there is a typo on line 347: > "... We use the result and resultin[should be here "g"?] variables... No, "resultin"

Re: [HACKERS] moving some partitioning code to executor

On Tue, Nov 14, 2017 at 7:59 PM, Amit Langote wrote: > On 2017/11/15 2:09, Alvaro Herrera wrote: >> Amit Langote wrote: >> >>> Since that 0001 patch was committed [1], here is the rebased patch. Will >>> add this to the November commit-fest. >> >> Please rebase

Updated macOS start scripts

The stuff in contrib/start-scripts/osx/ does not, as far as I know, work at all on any recent release of macOS, because SystemStarter is long gone. I propose replacing it with the attached, which I've tested on current-vintage Macs. If anyone's interested in reviewing this, I'll stick it into

Re: [HACKERS] Partition-wise aggregation/grouping

On 15.11.2017 13:35, Jeevan Chalke wrote: As explained by Ashutosh Bapat in reply https://www.postgresql.org/message-id/CAFjFpRdpeMTd8kYbM_x0769V-aEKst5Nkg3+coG=8ki7s8z...@mail.gmail.com we cannot rely on just aggtype==aggtranstype. Obviously this check (aggtype==aggtranstype) is not

Re: [HACKERS] [PATCH] Incremental sort

Antonin Houska wrote: > Alexander Korotkov wrote: > > > Patch rebased to current master is attached. I'm going to improve my > > testing script and post new results. > > I wanted to review this patch but incremental-sort-8.patch fails to apply.

Re: Updated macOS start scripts

> On Nov 15, 2017, at 8:32 AM, Tom Lane wrote: > > The stuff in contrib/start-scripts/osx/ does not, as far as I know, > work at all on any recent release of macOS, because SystemStarter > is long gone. I propose replacing it with the attached, which > I've tested on