Re: Collation versions on Windows (help wanted, apply within)

2020-03-26 Thread Juan José Santamaría Flecha
On Wed, Mar 25, 2020 at 4:18 AM Thomas Munro wrote: > > Thanks! Pushed. > Great! > From the things we learned in this thread, I think there is an open > item for someone to write a patch to call EnumSystemLocalesEx() and > populate the initial set of collations, where we use "locale -a" on >

Re: Collation versions on Windows (help wanted, apply within)

2020-03-24 Thread Thomas Munro
On Tue, Mar 24, 2020 at 7:56 AM Juan José Santamaría Flecha wrote: > On Mon, Mar 23, 2020 at 5:59 AM Thomas Munro wrote: >> Done in this new 0002 patch (untested). 0001 removes the comment that >> individual collations can't have a NULL version, reports NULL for >> Linux/glibc collations like

Re: Collation versions on Windows (help wanted, apply within)

2020-03-23 Thread Juan José Santamaría Flecha
On Mon, Mar 23, 2020 at 5:59 AM Thomas Munro wrote: > > Done in this new 0002 patch (untested). 0001 removes the comment that > individual collations can't have a NULL version, reports NULL for > Linux/glibc collations like C.UTF-8 by stripping the suffix and > comparing with C and POSIX as

Re: Collation versions on Windows (help wanted, apply within)

2020-03-22 Thread Thomas Munro
On Wed, Dec 18, 2019 at 11:02 PM Thomas Munro wrote: > On Tue, Dec 17, 2019 at 1:40 AM Juan José Santamaría Flecha > wrote: > > This is a resume to illustrate an issue with locale = 'C': > > > > postgres=# CREATE COLLATION c_test (locale = 'C'); > > CREATE COLLATION > > postgres=# select

Re: Collation versions on Windows (help wanted, apply within)

2019-12-18 Thread Thomas Munro
On Tue, Dec 17, 2019 at 1:40 AM Juan José Santamaría Flecha wrote: > On Mon, Dec 16, 2019 at 1:26 AM Thomas Munro wrote: >> On Wed, Nov 27, 2019 at 10:38 AM Peter Eisentraut >> >> Would you mind posting the full output of the above query (with >> showing) on a Windows system after running

Re: Collation versions on Windows (help wanted, apply within)

2019-12-16 Thread Juan José Santamaría Flecha
On Mon, Dec 16, 2019 at 1:26 AM Thomas Munro wrote: > On Wed, Nov 27, 2019 at 10:38 AM Peter Eisentraut > > Would you mind posting the full output of the above query (with > showing) on a Windows system after running initdb with the -v2 patch, > so we can see how the collations look? > > Sure,

Re: Collation versions on Windows (help wanted, apply within)

2019-12-16 Thread Peter Eisentraut
On 2019-12-16 01:26, Thomas Munro wrote: While wondering about that, I noticed the "C.UTF-8" encoding (here on a glibc system): postgres=# \pset null Null display is "". postgres=# select collname, collprovider, collencoding, collcollate, collctype, collversion from pg_collation ; collname

Re: Collation versions on Windows (help wanted, apply within)

2019-12-15 Thread Thomas Munro
On Wed, Nov 27, 2019 at 10:38 AM Peter Eisentraut wrote: > On 2019-11-26 21:39, Thomas Munro wrote: > > On Fri, Nov 8, 2019 at 12:44 PM Thomas Munro wrote: > >> The reason for returning an empty string for "C" and "POSIX" is the > >> following comment for get_collation_actual_version(): > >> >

Re: Collation versions on Windows (help wanted, apply within)

2019-11-26 Thread Peter Eisentraut
On 2019-11-26 21:39, Thomas Munro wrote: On Fri, Nov 8, 2019 at 12:44 PM Thomas Munro wrote: The reason for returning an empty string for "C" and "POSIX" is the following comment for get_collation_actual_version(): * A particular provider must always either return a non-NULL string or

Re: Collation versions on Windows (help wanted, apply within)

2019-11-26 Thread Thomas Munro
On Fri, Nov 8, 2019 at 12:44 PM Thomas Munro wrote: > The reason for returning an empty string for "C" and "POSIX" is the > following comment for get_collation_actual_version(): > > * A particular provider must always either return a non-NULL string or return > * NULL (if it doesn't support

Re: Collation versions on Windows (help wanted, apply within)

2019-11-10 Thread Thomas Munro
On Sat, Nov 9, 2019 at 10:20 AM Juan José Santamaría Flecha wrote: >> Do any Windows hackers want to help get it into shape? Some things to >> do: test it, verify that the _WIN32_WINNT >= 0x0600 stuff makes sense >> (why do we target such ancient Windows releases anyway?) > > You have to keep in

Re: Collation versions on Windows (help wanted, apply within)

2019-11-09 Thread Juan José Santamaría Flecha
On Fri, Nov 8, 2019 at 12:44 AM Thomas Munro wrote: > > recommend a better way to display the collation version as text. > > There is a major and a minor version. The attached patch applies on top the previous. Regards, Juan José Santamaría Flecha

Re: Collation versions on Windows (help wanted, apply within)

2019-11-08 Thread Juan José Santamaría Flecha
On Fri, Nov 8, 2019 at 12:44 AM Thomas Munro wrote: > > Do any Windows hackers want to help get it into shape? Some things to > do: test it, verify that the _WIN32_WINNT >= 0x0600 stuff makes sense > (why do we target such ancient Windows releases anyway?) You have to keep in mind that