Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Michael Paquier
On Sat, Apr 07, 2018 at 09:25:44AM -0300, Alvaro Herrera wrote:
> Tom Lane wrote:
>> I've always felt that the pg_foo_fn.h business was a kluge, and would
>> be happy to get rid of it.  But one could also argue that it would be
>> a good design, if we adopted it uniformly instead of haphazardly.
>> But that'd require more code churn, and there's no longer a lot to be
>> gained thereby.
> 
> I vote for removing pg_foo_fn.h.

+1 on that.
--
Michael


signature.asc
Description: PGP signature


Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Alvaro Herrera
Tom Lane wrote:

> I've always felt that the pg_foo_fn.h business was a kluge, and would
> be happy to get rid of it.  But one could also argue that it would be
> a good design, if we adopted it uniformly instead of haphazardly.
> But that'd require more code churn, and there's no longer a lot to be
> gained thereby.

I vote for removing pg_foo_fn.h.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services