On 2021/11/20 0:19, Fujii Masao wrote:
On 2021/11/19 16:54, Michael Paquier wrote:
On Thu, Nov 18, 2021 at 10:04:57AM +0530, Bharath Rupireddy wrote:
Yeah let's not do that. I'm fine with the
wait_event_for_archive_command_v2.patch as is.
Switched the patch as RfC, then.
Thanks!
On 2021/11/19 16:54, Michael Paquier wrote:
On Thu, Nov 18, 2021 at 10:04:57AM +0530, Bharath Rupireddy wrote:
Yeah let's not do that. I'm fine with the
wait_event_for_archive_command_v2.patch as is.
Switched the patch as RfC, then.
Thanks! Barring any objection, I will commit the patch.
On Thu, Nov 18, 2021 at 10:04:57AM +0530, Bharath Rupireddy wrote:
> Yeah let's not do that. I'm fine with the
> wait_event_for_archive_command_v2.patch as is.
Switched the patch as RfC, then.
--
Michael
signature.asc
Description: PGP signature
On Thu, Nov 18, 2021 at 7:53 AM Fujii Masao wrote:
> > 1) Can't we determine the wait event type based on commandName in
> > ExecuteRecoveryCommand instead of passing it as an extra param?
>
> Yes, that's possible. But isn't it uglier to make ExecuteRecoveryCommand()
> have
> the map of command
On Thu, Nov 18, 2021 at 11:23:17AM +0900, Fujii Masao wrote:
> Yes, that's possible. But isn't it uglier to make ExecuteRecoveryCommand()
> have
> the map of command name and wait event? So I feel inclined to avoid adding
> something like the following code into the function... Thought?
FWIW, I
On 2021/11/10 20:19, Bharath Rupireddy wrote:
Thanks for the patch. It looks good to me other than the following comment:
Thanks for the review!
1) Can't we determine the wait event type based on commandName in
ExecuteRecoveryCommand instead of passing it as an extra param?
Yes, that's
On Wed, Nov 10, 2021 at 5:00 PM Bharath Rupireddy
wrote:
>
> On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao
> wrote:
> > > The following activitymsg that are being set to ps display in
> > > XLogFileRead and pgarch_archiveXlog have come up for one of our
> > > internal team discussions recently:
>
On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao wrote:
> > The following activitymsg that are being set to ps display in
> > XLogFileRead and pgarch_archiveXlog have come up for one of our
> > internal team discussions recently:
> >
> > snprintf(activitymsg, sizeof(activitymsg), "waiting
Great, so great. Thanks you
Bharath Rupireddy schrieb am Mi.,
10. Nov. 2021, 12:20:
> On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao
> wrote:
> > On 2021/10/21 23:55, Bharath Rupireddy wrote:
> > >> Also how about adding wait events for other commands like
> > >> archive_cleanup_command,
On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao wrote:
> On 2021/10/21 23:55, Bharath Rupireddy wrote:
> >> Also how about adding wait events for other commands like
> >> archive_cleanup_command, restore_command and recovery_end_command?
> >
> > +1 for the wait event.
>
> Thanks!
> I added the wait
On 2021/10/22 18:32, Michael Paquier wrote:
On Thu, Oct 21, 2021 at 10:57:50PM +0900, Fujii Masao wrote:
Also how about adding wait events for other commands like
archive_cleanup_command, restore_command and recovery_end_command?
+1 to add something for all of them as we track the startup
On 2021/10/21 23:55, Bharath Rupireddy wrote:
Also how about adding wait events for other commands like
archive_cleanup_command, restore_command and recovery_end_command?
+1 for the wait event.
Thanks!
I added the wait events for also restore_command, etc into the patch.
I attached that
On Thu, Oct 21, 2021 at 10:57:50PM +0900, Fujii Masao wrote:
> Also how about adding wait events for other commands like
> archive_cleanup_command, restore_command and recovery_end_command?
+1 to add something for all of them as we track the startup process in
pg_stat_activity. Thinking with a
On Thu, Oct 21, 2021 at 7:28 PM Fujii Masao wrote:
>
> Hi,
>
> I'd like to propose to add new wait event reported while archiver process
> is executing archive_command. This would be helpful to observe
> what archiver is doing and check whether it has some troubles or not.
> Thought? PoC patch
14 matches
Mail list logo
