Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Craig Ringer
Hi all Updated patch attached. This one avoids the inline function stuff and instead just decides whether to compile unix_crashdump.c or win32_crashdump.c based on build system tests. It passes make check on nix and tests on win32, both with and without the crashdumps directory existing. The

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Craig Ringer
BTW, related to the crash dump work: I wanted to see if I could get any integration into Windows Error Reporting for Pg, because it'd be nice to be able to use Microsoft's servers to aggregate crash reports and collect data on problems. WER (on Windows 7 and Vista) also provides automatic

Re: [HACKERS] pg_execute_from_file, patch v10

2010-12-16 Thread Dimitri Fontaine
Itagaki Takahiro itagaki.takah...@gmail.com writes: I applied the attached patch extracted from Dimitri's work. Thanks! I'm working on next extension's patch, merging now. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via

Re: [HACKERS] SQL/MED - file_fdw

2010-12-16 Thread Shigeru HANADA
On Tue, 14 Dec 2010 15:51:18 +0900 Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Tue, Dec 14, 2010 at 15:31, Shigeru HANADA han...@metrosystems.co.jp wrote: In addition to above, ResetCopyFrom() is necessary to support nested loops which inner node is a ForeignScan. I think you

Re: [HACKERS] getting composite types info from libpq

2010-12-16 Thread Florian Pflug
On Dec16, 2010, at 02:51 , Daniele Varrazzo wrote: 1. do I get enough info in the PGresult to inspect anonymous composite types? You just get the composite value, as you discovered. In text mode, that means only the composite string value, which contains no information about the individual

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Greg Smith
Moving onto the directory archive part of this patch, the feature seems to work as advertised; here's a quick test case: createdb pgbench pgbench -i -s 1 pgbench pg_dump -F d -f test pg_restore -k test pg_restore -l test createdb copy pg_restore -d copy test The copy made that way looked good.

Re: [HACKERS] Default mode for shutdown

2010-12-16 Thread Markus Wanner
On 12/15/2010 03:47 PM, Tom Lane wrote: Yeah, and more to the point, do I want to finish whatever I was doing in that window? Fast-by-default is a nice hammer to swing, but one day you'll pound your finger. Magnus pointed out that most distributions already use fast shutdown. So it seems most

Re: [HACKERS] SQL/MED - file_fdw

2010-12-16 Thread Itagaki Takahiro
On Thu, Dec 16, 2010 at 18:45, Shigeru HANADA han...@metrosystems.co.jp wrote: COPY FROM is a command which INSERT data from a file essentially, so it requires RowExclusiveLock on the target table.  On the other hand, file_fdw is a feature which reads data from a file through a table, so it

Re: [HACKERS] Per-column collation

2010-12-16 Thread Greg Smith
Robert Haas wrote: I don't really have a position on whether or not this patch is ready to commit... but I do think that this is the sort of patch that is very likely to have some bugs almost no matter when we commit it I just updated the CF app to track Peter's latest update, which remains

Re: [HACKERS] Default mode for shutdown

2010-12-16 Thread Itagaki Takahiro
On Thu, Dec 16, 2010 at 19:26, Markus Wanner mar...@bluegap.ch wrote: On 12/15/2010 03:47 PM, Tom Lane wrote: Yeah, and more to the point, do I want to finish whatever I was doing in that window?  Fast-by-default is a nice hammer to swing, but one day you'll pound your finger. Magnus pointed

Re: [HACKERS] Per-column collation

2010-12-16 Thread Itagaki Takahiro
On Thu, Dec 16, 2010 at 19:37, Greg Smith g...@2ndquadrant.com wrote: I just updated the CF app to track Peter's latest update, which remains untested by anyone else for whether it fixes all the issues brought up.  It would be nice to get a re-review to confirm things are still working in

Re: [HACKERS] Per-column collation

2010-12-16 Thread Greg Smith
Itagaki Takahiro wrote: We might need previous reviewers and active reviewers in commit-fest app. Or, should non-active reviewers delete their names? This is only really an issue with patches that get moved from one CF to the next, which doesn't happen that often. Patches that are marked

Re: [HACKERS] proposal: auxiliary functions for record type

2010-12-16 Thread Florian Pflug
On Dec13, 2010, at 08:23 , Pavel Stehule wrote: There is a second possibility - and hardly simpler. We can use a specialised statement with own parser/executor node. Then implementation should be really simply syntax: EXTRACT_VALUE(expr1 FROM expr2 AS typename) ... RETURNS typename In

Re: [HACKERS] Instrument checkpoint sync calls

2010-12-16 Thread Greg Smith
Robert Haas wrote: On Wed, Dec 15, 2010 at 9:22 AM, Greg Smith g...@2ndquadrant.com wrote: patch I submit. Doesn't seem worth going through the trouble of committing that minor rework on its own, I'll slip it into the next useful thing that touches this area I do. Thanks for the hint, this

Re: [HACKERS] proposal: auxiliary functions for record type

2010-12-16 Thread Pavel Stehule
2010/12/16 Florian Pflug f...@phlo.org: On Dec13, 2010, at 08:23 , Pavel Stehule wrote: There is a second possibility - and hardly simpler. We can use a specialised statement with own parser/executor node. Then implementation should be really simply syntax: EXTRACT_VALUE(expr1 FROM expr2

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Greg Smith
Andres Freund wrote: On Thursday 02 December 2010 22:21:37 Alvaro Herrera wrote: Excerpts from Andres Freund's message of sáb oct 30 05:49:21 -0300 2010: Ill set this up for the next commitfest, I don't think I can do much more without further input. Are you reserving about 20

Re: [HACKERS] Tab completion for view triggers in psql

2010-12-16 Thread Greg Smith
David Fetter wrote: That we're in the position of having prevN_wd for N = 1..5 as the current code exists is a sign that we need to refactor the whole thing, as you've suggested before. I'll work up a design and prototype for this by this weekend. Great. I don't think issues around tab

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 09:21, Craig Ringer cr...@postnewspapers.com.au wrote: Hi all Updated patch attached. This one avoids the inline function stuff and instead just decides whether to compile unix_crashdump.c or win32_crashdump.c based on build system tests. It passes make check on nix

Re: [HACKERS] Extensions, patch v17

2010-12-16 Thread Greg Smith
Dimitri tells me there's a V18 of this patch due real soon now. That may very well be ready for a committer, but even if that's the case it's going to take them some time to consume what was at last count an almost 10K line long context diff. In the interest of closing this CF out without

Re: [HACKERS] CommitFest wrap-up

2010-12-16 Thread Greg Smith
Tom Lane wrote: - Writeable CTEs - I think we need Tom to pick this one up. - Fix snapshot taking inconsistencies - Ready for committer. Can any committer pick this up? Will take a look at these two also. I marked you down at the listed committer for them both. That leaves

[HACKERS] Crash on attempt to connect to nonstarted server

2010-12-16 Thread Magnus Hagander
I get a crash on win32 when connecting to a server that's not started. In fe-connect.c, we have: display_host_addr = (conn-pghostaddr == NULL) (strcmp(conn-pghost, host_addr) != 0); In my case, conn-pghost is NULL at this point, as is conn-pghostaddr.

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Andres Freund
Hi Greg, On Thursday 16 December 2010 13:32:46 Greg Smith wrote: Andres Freund wrote: On Thursday 02 December 2010 22:21:37 Alvaro Herrera wrote: Excerpts from Andres Freund's message of sáb oct 30 05:49:21 -0300 2010: Ill set this up for the next commitfest, I don't think I can do much

Re: [HACKERS] Instrument checkpoint sync calls

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 6:48 AM, Greg Smith g...@2ndquadrant.com wrote: I meant that I'd bundle it into the block of time I spend on that, and likely submit with something else that touches the same area.  Obviously the correction patch would be better on its own when being handed over to a

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 7:49 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please note that the SQL scripts seem to be encoded in latin9. Seems like an odd choice. Why not UTF-8? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 7:49 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please note that the SQL scripts seem to be encoded in latin9. Seems like an odd choice. Why not UTF-8? Not a choice, just what's already in… -- Dimitri Fontaine

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 8:01 AM, Magnus Hagander mag...@hagander.net wrote: We use the existance of the crashdumps directory as an indication we want crashdumps. That's fine when the system is up. But what if we crash *in the postmaster before we have done chdir()*? Should we perhaps instead

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 9:04 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 7:49 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please note that the SQL scripts seem to be encoded in latin9. Seems like an odd choice.  

Re: [HACKERS] SQL/MED - file_fdw

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 5:35 AM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: Ah, I found my bug in BeginCopy(), but it's in the usage of ExecCheckRTPerms() rather than RowExclusiveLock, right? The target relation should have been opened and locked by the caller. I think we can move the

Re: [HACKERS] mvcc DML on the same row

2010-12-16 Thread Simon Riggs
On Wed, 2010-12-15 at 20:50 +0100, matteo durighetto wrote: if we continue the transaction and we do for example another update on this row (X) , we again redo the same operation: X0 (deleted old row) X1 (row inserted, NOW deleted) = not needed for rollback X2 (insert new row

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Nicolas Barbier
2010/12/16 Robert Haas robertmh...@gmail.com: On Thu, Dec 16, 2010 at 7:49 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please note that the SQL scripts seem to be encoded in latin9. Seems like an odd choice.  Why not UTF-8? Latin 9 = ISO 8859-15 = a more modern version of Latin 1

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Andres Freund
On Wednesday 15 December 2010 20:12:45 Robert Haas wrote: On Wed, Dec 15, 2010 at 10:02 AM, Andres Freund and...@anarazel.de wrote: Is there a way that errstart() and/or errfinish() can know enough about the state of the communication with the frontend to decide whether to suppress

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 14:01, Magnus Hagander mag...@hagander.net wrote: On Thu, Dec 16, 2010 at 09:21, Craig Ringer cr...@postnewspapers.com.au wrote: Hi all Updated patch attached. This one avoids the inline function stuff and instead just decides whether to compile unix_crashdump.c or

Re: [HACKERS] mvcc DML on the same row

2010-12-16 Thread Andres Freund
On Thursday 16 December 2010 15:11:01 Simon Riggs wrote: In order to remove X1 we would need to change X0 to point to X2, which we don't do because we're not allowed to update in place. Even if we could, I'm not sure this case is frequent enough to be worth the effort. Especially as X3 would

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 15:07, Robert Haas robertmh...@gmail.com wrote: On Thu, Dec 16, 2010 at 8:01 AM, Magnus Hagander mag...@hagander.net wrote: We use the existance of the crashdumps directory as an indication we want crashdumps. That's fine when the system is up. But what if we crash *in

Re: [HACKERS] getting composite types info from libpq

2010-12-16 Thread Merlin Moncure
On Thu, Dec 16, 2010 at 5:03 AM, Florian Pflug f...@phlo.org wrote: On Dec16, 2010, at 02:51 , Daniele Varrazzo wrote: 1. do I get enough info in the PGresult to inspect anonymous composite types? You just get the composite value, as you discovered. In text mode, that means only the composite

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 9:24 AM, Magnus Hagander mag...@hagander.net wrote: Is that less ugly? ;) Well, I thought it was or I would have suggested it, but it's obviously open to interpretation. But yes, we are talking about in the field, so it's fairly small. But any crash during guc loading

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 9:24 AM, Magnus Hagander mag...@hagander.net wrote: We can do such a commandline. We don't have any platform-specific commandline options today. Is that something we've intentionally avoided, or just not needed before? Beats

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 15:56, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 9:24 AM, Magnus Hagander mag...@hagander.net wrote: We can do such a commandline. We don't have any platform-specific commandline options today. Is that something

Re: [HACKERS] Crash on attempt to connect to nonstarted server

2010-12-16 Thread Bruce Momjian
Magnus Hagander wrote: I get a crash on win32 when connecting to a server that's not started. In fe-connect.c, we have: display_host_addr = (conn-pghostaddr == NULL) (strcmp(conn-pghost, host_addr) != 0); In my case, conn-pghost is NULL at this point,

Re: [HACKERS] Question regarding psql or libpq

2010-12-16 Thread Tom Lane
Tatsuo Ishii is...@postgresql.org writes: It seems psql(or libpq) connects to PostgreSQL twice when md5 auth is required. Here is a strace log on my Linux machine. Is there any reason for this? IMO frontend/backend protocol allows to send salt after receiving AuthenticationMD5Password using

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 16.12.2010 12:12, Greg Smith wrote: Moving onto the directory archive part of this patch, the feature seems to work as advertised; here's a quick test case: createdb pgbench pgbench -i -s 1 pgbench pg_dump -F d -f test pg_restore -k test pg_restore -l test createdb copy pg_restore -d copy

Re: [HACKERS] Question regarding psql or libpq

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 16:22, Tom Lane t...@sss.pgh.pa.us wrote: Tatsuo Ishii is...@postgresql.org writes: It seems psql(or libpq) connects to PostgreSQL twice when md5 auth is required. Here is a strace log on my Linux machine. Is there any reason for this?  IMO frontend/backend protocol

Re: [HACKERS] Crash on attempt to connect to nonstarted server

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: I get a crash on win32 when connecting to a server that's not started. In fe-connect.c, we have: display_host_addr = (conn-pghostaddr == NULL) (strcmp(conn-pghost, host_addr) != 0); In my case, conn-pghost is

Re: [HACKERS] Question regarding psql or libpq

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Thu, Dec 16, 2010 at 16:22, Tom Lane t...@sss.pgh.pa.us wrote: Two connections are not really a problem IMO, so I would not be in favor of kluging the API to the extent required by solution (B). (B) could be as simple as a callback asking for it,

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Thu, Dec 16, 2010 at 15:56, Tom Lane t...@sss.pgh.pa.us wrote: I think the proposal for such a switch is unnecessary lily-gilding, Hmm. What we could do is have pg_ctl chdir() into the data directory on start. See above. You're solving a

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Magnus Hagander
On Tue, Dec 14, 2010 at 17:56, Massa, Harald Armin c...@ghum.de wrote: My question: Which way is available to query the linked libpq version? But it does outline that fact that it wouldn't suck to have a function  in libpq returning the version so that application can check this at  runtime

Re: [HACKERS] Crash on attempt to connect to nonstarted server

2010-12-16 Thread Bruce Momjian
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: I get a crash on win32 when connecting to a server that's not started. In fe-connect.c, we have: display_host_addr = (conn-pghostaddr == NULL) (strcmp(conn-pghost, host_addr) != 0); In my

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Dmitriy Igrishin
Magnus, thats great ! And name PQlibVersion is correct ! Thanks. 2010/12/16 Magnus Hagander mag...@hagander.net On Tue, Dec 14, 2010 at 17:56, Massa, Harald Armin c...@ghum.de wrote: My question: Which way is available to query the linked libpq version? But it does outline that fact that

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: But it does outline that fact that it wouldn't suck to have a function  in libpq returning the version so that application can check this at  runtime - clearly it would also be useful when being linked through something like psycopg2. Stuck in a

[HACKERS] default localtimestamp at time zone

2010-12-16 Thread Peter Eisentraut
Oddly, this doesn't work: create table test (x timestamp default localtimestamp at time zone 'UTC'); ERROR: 42601: syntax error at or near at (Parentheses help.) The attached patch fixes it. Is there any reason for this omission? (The patch also works in past releases, so it was not

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Magnus Hagander
On Thu, Dec 16, 2010 at 17:07, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: But it does outline that fact that it wouldn't suck to have a function  in libpq returning the version so that application can check this at  runtime - clearly it would also be

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Thu, Dec 16, 2010 at 17:07, Tom Lane t...@sss.pgh.pa.us wrote: because if you're trying to link against an older libpq, the link will fail before you ever get to execute.  So let's have a less implausible use-case please. Look back at the very

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 9:04 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please note that the SQL scripts seem to be encoded in latin9. Seems like an odd choice.  Why not UTF-8? Not a choice, just what's already in… Sure, I get it. I'm

Re: [HACKERS] [GENERAL] queriing the version of libpq

2010-12-16 Thread Andrew Chernow
And it *could* be used in exactly the case you're outlining as long as you load the function dynamically. Detecting the presence of a function does not require a version number. If the symbol is in the library, use it. The only reason the version number would come into play is if you

Re: [HACKERS] default localtimestamp at time zone

2010-12-16 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Oddly, this doesn't work: create table test (x timestamp default localtimestamp at time zone 'UTC'); ERROR: 42601: syntax error at or near at (Parentheses help.) The attached patch fixes it. Is there any reason for this omission? I'm not really

Re: [HACKERS] Complier warnings on mingw gcc 4.5.0

2010-12-16 Thread Andrew Dunstan
On 12/15/2010 11:53 PM, Tom Lane wrote: OK, patch committed so we can get testing from the existing buildfarm members, but please try on your new installation too. It's working, but I don't think it's right :-) In particular, I don't believe this, or rather I

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: I count four issues of various sizes left with this patch right now: 1) This levels bit 2) Can the approach used be simplified or the code made cleaner? 3) What is the interaction with Hot Standby error handling? 4) The usual code formatting

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 11:58 AM, Tom Lane t...@sss.pgh.pa.us wrote: Greg Smith g...@2ndquadrant.com writes: I count four issues of various sizes left with this patch right now: 1) This levels bit 2) Can the approach used be simplified or the code made cleaner? 3) What is the interaction

Re: [HACKERS] Complier warnings on mingw gcc 4.5.0

2010-12-16 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: It's working, but I don't think it's right :-) In particular, I don't believe this, or rather I don't believe that its converse is false: /* If not HAVE_GETOPT, we are using src/port/getopt.c, which has optreset */ Yeah, that was a 90%

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread David E. Wheeler
On Dec 16, 2010, at 8:19 AM, Tom Lane wrote: I would think that we want to establish the same policy as we have for dictionary files: they're assumed to be UTF-8. I don't believe there should be an encoding option at all. If we didn't need one for dictionary files, there is *surely* no

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 11:58 AM, Tom Lane t...@sss.pgh.pa.us wrote: It's possible we could refactor things so we abort the open transaction while inside the interrupt handler, then queue up an error to be reported whenever we next get a command (as

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 16.12.2010 17:23, Heikki Linnakangas wrote: On 16.12.2010 12:12, Greg Smith wrote: There's a number of small things that I'd like to see improved in new rev of this code ... In addition to those: ... One more thing: the motivation behind this patch is to allow parallel pg_dump in the

[HACKERS] Binary timestamp with without timezone

2010-12-16 Thread Radosław Smogura
Hi, I work on binary support for JDBC. I saw disadventage of TIMESTAMPS WITH / WITHOUT TZ. Currently (in text mode) driver always sends date time string with appended time offset, as UNSPECIFIED so backend can choose to use offset or not. In binary mode I can only send 8 bytes timestamp

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: One more thing: the motivation behind this patch is to allow parallel pg_dump in the future, so we should be make sure this patch caters well for that. As soon as we have parallel pg_dump, the next

Re: [HACKERS] Binary timestamp with without timezone

2010-12-16 Thread Tom Lane
=?utf-8?q?Rados=C5=82aw_Smogura?= rsmog...@softperience.eu writes: I work on binary support for JDBC. I saw disadventage of TIMESTAMPS WITH / WITHOUT TZ. Currently (in text mode) driver always sends date time string with appended time offset, as UNSPECIFIED so backend can choose to use

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 12:46 PM, Tom Lane t...@sss.pgh.pa.us wrote:  I'm handwaving there --- I think probably the first cut should just discard errors after the first, and see how well that works in practice. Seems reasonable. Another thing I don't quite understand is - at what point does

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 16.12.2010 19:58, Robert Haas wrote: On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: One more thing: the motivation behind this patch is to allow parallel pg_dump in the future, so we should be make sure this patch caters well for that. As

[HACKERS] PgEast 2011: NYC CFP

2010-12-16 Thread Joshua D. Drake
December 16th, 2010: Celebrating 15 years of PostgreSQL, early. Following on the smashing success of PostgreSQL Conference West, PostgreSQL Conference West, The PostgreSQL Conference for Developers, End Users and Decision Makers, is being held at the Hotel Pennsylvania, in New York City from

Re: [HACKERS] Binary timestamp with without timezone

2010-12-16 Thread Radosław Smogura
Tom Lane t...@sss.pgh.pa.us Thursday 16 December 2010 18:59:56 =?utf-8?q?Rados=C5=82aw_Smogura?= rsmog...@softperience.eu writes: I work on binary support for JDBC. I saw disadventage of TIMESTAMPS WITH / WITHOUT TZ. Currently (in text mode) driver always sends date time string with

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 12:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Another thing I don't quite understand is - at what point does the protocol allow us to emit an error? Basically, you can send an error in response to a query. What about some

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Joachim Wieland
On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: As soon as we have parallel pg_dump, the next big thing is going to be parallel dump of the same table using multiple processes. Perhaps we should prepare for that in the directory archive format, by

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 16.12.2010 20:33, Joachim Wieland wrote: On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: As soon as we have parallel pg_dump, the next big thing is going to be parallel dump of the same table using multiple processes. Perhaps we should prepare

[HACKERS] proposal: FOREACH-IN-ARRAY (probably for 9.2?)

2010-12-16 Thread Pavel Stehule
Hello I am resending a redesigned proposal about special plpgsql statement that support iteration over an array. The most conflict issue of last proposal was a syntax. It enhanced relative complex FOR statement. So now, it's based on new statement with simple syntax. We can use a keyword

Re: [HACKERS] Binary timestamp with without timezone

2010-12-16 Thread Tom Lane
=?utf-8?q?Rados=C5=82aw_Smogura?= rsmog...@softperience.eu writes: Tom Lane t...@sss.pgh.pa.us Thursday 16 December 2010 18:59:56 =?utf-8?q?Rados=C5=82aw_Smogura?= rsmog...@softperience.eu writes: ... This timestamp must be properly encoded depending if target is WITH TZ or not, but JDBC (and

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of jue dic 16 09:49:31 -0300 2010: Hi, Well $subject says about it all really. The bitrot of course comes from the fact that the last in-commitfest-dependency has been commited in, and I kept a version of pg_execute_sql_file() in the extension's

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 16.12.2010 20:33, Joachim Wieland wrote: How exactly would you just split the table in chunks of roughly the same size ? Check pg_class.relpages, and divide that evenly across the processes. That should be good enough. Not

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@commandprompt.com writes: I thought the suggestion of having version = 9.1devel line in each contrib's module extension file was a joke. It is certainly not going to be sustainable in the long run -- I don't think we want to be modifying all control files each release.

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@commandprompt.com writes: I thought the suggestion of having version = 9.1devel line in each contrib's module extension file was a joke. It is certainly not going to be sustainable in the long run -- I don't think we want to be modifying all control files each release.

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Alvaro Herrera alvhe...@commandprompt.com writes: I thought the suggestion of having version = 9.1devel line in each contrib's module extension file was a joke. It is certainly not going to be sustainable in the long run -- I don't think we want

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 1:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 12:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Another thing I don't quite understand is - at what point does the protocol allow us to emit an error? Basically,

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 2:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: On 16.12.2010 20:33, Joachim Wieland wrote: How exactly would you just split the table in chunks of roughly the same size ? Check pg_class.relpages, and divide

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Hmm. It's seeming to me that what we want to do is something like this: 1. If an error is thrown while DoingCommandRead, it gets upgraded to FATAL. I don't think we have much choice about this because, per your previous comments, we can't longjmp()

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: However, the only way I can see to fix this automatically is to have the makefiles propagate PG_VERSION_NUM (or one of the other values set by configure) into generated control files. Ah, somewhat like what I was asked to remove from the patch, right?

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 16.12.2010 22:13, Robert Haas wrote: So how bad would it be if we committed this new format without support for splitting large relations into multiple files, or with some stub support that never actually gets used, and fixed this later? Because this is starting to sound like a bigger

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Andrew Dunstan
On 12/16/2010 03:13 PM, Robert Haas wrote: So how bad would it be if we committed this new format without support for splitting large relations into multiple files, or with some stub support that never actually gets used, and fixed this later? Because this is starting to sound like a bigger

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 3:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Hmm.  It's seeming to me that what we want to do is something like this: 1. If an error is thrown while DoingCommandRead, it gets upgraded to FATAL.  I don't think we have much choice

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue dic 16 17:10:10 -0300 2010: However, the only way I can see to fix this automatically is to have the makefiles propagate PG_VERSION_NUM (or one of the other values set by configure) into generated control files. I don't think that's what we want

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 3:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: I guess you misunderstood what I said.  What I meant was that we cannot longjmp *out to the outer level*, ie we cannot take control away from the input stack.  We could however have a

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of jue dic 16 17:10:10 -0300 2010: However, the only way I can see to fix this automatically is to have the makefiles propagate PG_VERSION_NUM (or one of the other values set by configure) into generated control

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Robert Haas
On Thu, Dec 16, 2010 at 3:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: I thought the next thing we'd report would be the recovery conflict, not any bizarre can't-abort-the-transaction scenario. Well, if we discard it because we're too lazy to implement error message merging, that's OK.  

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 12/16/2010 03:13 PM, Robert Haas wrote: So how bad would it be if we committed this new format without support for splitting large relations into multiple files, or with some stub support that never actually gets used, and fixed this later?

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 3:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: (But this is all speculation; I don't actually know SSL innards.) I would be really surprised if aborting a transaction takes long enough to mess up SSL. I mean, there could be a

Re: [HACKERS] [PATCH] V3: Idle in transaction cancellation

2010-12-16 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue dic 16 17:54:51 -0300 2010: Robert Haas robertmh...@gmail.com writes: On Thu, Dec 16, 2010 at 3:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: (But this is all speculation; I don't actually know SSL innards.) I would be really surprised if aborting a

[HACKERS] clang and LLVM

2010-12-16 Thread Gevik Babakhani
Hi, I was wondering if there has been anyone experimenting to compile PG using LLVM/clang compiler tools. Regards, Gevik. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] clang and LLVM

2010-12-16 Thread Tom Lane
Gevik Babakhani pg...@xs4all.nl writes: I was wondering if there has been anyone experimenting to compile PG using LLVM/clang compiler tools. There is (or was, not sure if it's up right now) a buildfarm machine using LLVM. regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] Extensions, patch v18 (merge against master, bitrot-only-fixes)

2010-12-16 Thread Dimitri Fontaine
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: However, the only way I can see to fix this automatically is to have the makefiles propagate PG_VERSION_NUM (or one of the other values set by configure) into generated control files. Ah, somewhat like what I

Re: [HACKERS] Default mode for shutdown

2010-12-16 Thread Josh Kupershmidt
On Wed, Dec 15, 2010 at 10:11 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: It occurs to me that we may need a new mode, which disconnects sessions that are not in a transaction (or as soon as they are) but leaves in-progress transactions alone; this could be the new default.  Of

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Andres Freund
On Thursday 16 December 2010 19:33:10 Joachim Wieland wrote: On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: As soon as we have parallel pg_dump, the next big thing is going to be parallel dump of the same table using multiple processes.

Re: [HACKERS] directory archive format for pg_dump

2010-12-16 Thread Heikki Linnakangas
On 17.12.2010 00:29, Andres Freund wrote: On Thursday 16 December 2010 19:33:10 Joachim Wieland wrote: On Thu, Dec 16, 2010 at 12:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: As soon as we have parallel pg_dump, the next big thing is going to be parallel dump of the

Re: [HACKERS] Re: Proposed Windows-specific change: Enable crash dumps (like core files)

2010-12-16 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: Found another problem in it: when running with an older version of dbghelp.dll (which I was), it simply didn't work. We need to grab the version of dbghelp.dll at runtime and pick which things we're going to dump based on that. The attached version

  1   2   >