Re: [HACKERS] Doc patch, further describe and-mask nature of the permission system

2012-09-29 Thread Karl O. Pinc
On 09/29/2012 01:16:51 AM, Karl O. Pinc wrote: > The attached documentation patch further describes the > additive nature of the permission system. Attached a second patch, applied after the first, to extend the discussion further regards roles. (Original patch attached for reference.) Karl

Re: [HACKERS] data to json enhancements

2012-09-29 Thread Misa Simic
No probs... And I did...The thing is, subject is to wide... Post too long... Intention was just to better explain thoughts... I am not a blogger anyway, just new in Postgres community... Trying to say, probably 90% of post would be suficient just for the list, and because of i am new it is hard to

Re: [HACKERS] CREATE SCHEMA IF NOT EXISTS

2012-09-29 Thread Volker Grabsch
Dickson S. Guedes schrieb: > - https://commitfest.postgresql.org/action/patch_view?id=907 > > The patch is small and implements a new syntax to CREATE SCHEMA > that allow the creation of a schema be skipped when IF NOT EXISTS is > used. > > [...] > > - Should this patch implements others INEs like

[HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. This can be cured by making the pg_upgrade test set up its test installs with "initdb --no-locale." as shown below (with similar changes for the MSVC build system als

is JSON really "a type" (Re: [HACKERS] data to json enhancements)

2012-09-29 Thread Hannu Krosing
On 09/26/2012 06:46 PM, Tom Lane wrote: Andrew Dunstan writes: Drawing together various discussions both here and elsewhere (e.g. the PostgresOpen hallway track) I propose to work on the following: 1. make datum_to_json() honor a type's cast to json if it exists. The fallback is to use the type

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > The recent alter generic tests have broken pg_upgrade testing on Windows > and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate expected file, and if so why? I don't see a reason that this should be failing only ther

[HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
BTW, I tried the pg_upgrade regression tests this morning on my dinosaur HPUX box, and it promptly fell over with: uname: illegal option -- o usage: uname [-amnrsvil] [-S nodename] make: *** [check] Error 1 This is not terribly surprising, because the -o option is nowhere to be seen in the Single

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 12:13 PM, Tom Lane wrote: BTW, I tried the pg_upgrade regression tests this morning on my dinosaur HPUX box, and it promptly fell over with: uname: illegal option -- o usage: uname [-amnrsvil] [-S nodename] make: *** [check] Error 1 This is not terribly surprising, because the -o

Re: is JSON really "a type" (Re: [HACKERS] data to json enhancements)

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 11:47 AM, Hannu Krosing wrote: On 09/26/2012 06:46 PM, Tom Lane wrote: Andrew Dunstan writes: Drawing together various discussions both here and elsewhere (e.g. the PostgresOpen hallway track) I propose to work on the following: 1. make datum_to_json() honor a type's cast to jso

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > The trouble with uname -s is that its output is a bit variable. I think > this will work: > testhost=`uname -a | sed 's/.* //'` What do you mean by "a bit variable"? And why would that fix it? The output of -a is *defined* to be the same as -s followed by other s

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 01:06 PM, Tom Lane wrote: Andrew Dunstan writes: The trouble with uname -s is that its output is a bit variable. I think this will work: testhost=`uname -a | sed 's/.* //'` What do you mean by "a bit variable"? On one of my machines uname -s return MINGW32_NT5.1 On anot

Re: [HACKERS] Unportable use of uname in pg_upgrade test script

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > Exactly, the sed script pulls the last token from the line, which is > Msys on all my Mingw systems. Perhaps that's "uname -v"? > If you want to do it another way we could possibly pass the PORTNAME > from the global make file. That might be safer. The last few words

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 11:49 AM, Tom Lane wrote: Andrew Dunstan writes: The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate expected file, and if so why? I don't see a reaso

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > On 09/29/2012 11:49 AM, Tom Lane wrote: >> Is it still broken after Alvaro added the alternate expected file, and >> if so why? I don't see a reason that this should be failing only there. >> I also note that it seems to be passing fine on buildfarm members other >> than

[HACKERS] doc patch for increase in shared_buffers

2012-09-29 Thread Jeff Janes
The default value for shared_buffers was recently increased from 32MB to 128MB, but the docs were not updated. shared_buffer_increase.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of sáb sep 29 14:57:11 -0300 2012: > > Andrew Dunstan writes: > > Well, that's a very good point. chough is actually the same machine, > > doing an MSVC build. So why would this test pass there? I'll investigate > > a bit more. Here's what the regression diffs

Re: is JSON really "a type" (Re: [HACKERS] data to json enhancements)

2012-09-29 Thread Hannu Krosing
On 09/29/2012 05:40 PM, Andrew Dunstan wrote: I am not opposed to making a new type, but I really don't think that means we need to do nothing for the existing data type. The suggested SERIALIZATION mechanism seems to be fairly intrusive and heavy handed, as opposed to the very lightweight

Re: is JSON really "a type" (Re: [HACKERS] data to json enhancements)

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 05:01 PM, Hannu Krosing wrote: On 09/29/2012 05:40 PM, Andrew Dunstan wrote: I still think Tom's suggestion is the best and simplest way to do that. which Toms suggestion you mean here ? The 3. mentioned above was for making possible 2 separate ways to convert (serialise/quote

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 01:49 PM, Andrew Dunstan wrote: On 09/29/2012 11:49 AM, Tom Lane wrote: Andrew Dunstan writes: The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate e

Re: [HACKERS] 64-bit API for large object

2012-09-29 Thread Tatsuo Ishii
> Excerpts from Kohei KaiGai's message of jue sep 27 01:01:18 -0300 2012: > >> * I have a question. What is the meaning of INT64_IS_BUSTED? >> It seems to me a marker to indicate a platform without 64bit support. >> However, the commit 901be0fad4034c9cf8a3588fd6cf2ece82e4b8ce >> says as foll

Re: [HACKERS] 64-bit API for large object

2012-09-29 Thread Tatsuo Ishii
Kaiai-san, Thank you for review. > I checked this patch. It looks good, but here are still some points to be > discussed. > > * I have a question. What is the meaning of INT64_IS_BUSTED? > It seems to me a marker to indicate a platform without 64bit support. > However, the commit 901be0fad40

Re: is JSON really "a type" (Re: [HACKERS] data to json enhancements)

2012-09-29 Thread Darren Duncan
Hannu Krosing wrote: Reflecting over the dual possible interpretation of what it does mean to convert between "text" and "json" data types it has dawned to me that the confusion may come mainly from wanting json to be two things at once: 1. - a serialisation of of a subset of javascript object