Re: [HACKERS] Support for RANGE ... PRECEDING windows in OVER

Definitely not this week. Hopefully for next commit fest. On Sun, Jun 30, 2013 at 9:56 PM, Josh Berkus wrote: > On 06/30/2013 08:54 PM, ian link wrote: > > I found some time and I think I am up to speed now. I finally figured out > > how to add new operator strategies and made a little test ope

Re: [HACKERS] Block write statistics WIP

Hi, I'm looking into this patch as a reviewer. (2013/05/24 10:33), Heikki Linnakangas wrote: On 23.05.2013 19:10, Greg Smith wrote: On 5/20/13 7:51 AM, Heikki Linnakangas wrote: It strikes me as kind of weird that the read side and write side are not more symmetrical. It might seem weird if

Re: [HACKERS] Review: query result history in psql

> > but maybe some interactive mode should be usefull - so after > execution, and showing result, will be prompt if result should be > saved or not. I like the idea, in addition to the ordinary mode. Personally, I would use the ordinary mode, but I can see how 'interactive' would be useful. yes,

Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division

On Mon, Jul 1, 2013 at 6:16 AM, David Fetter wrote: > On Fri, Jun 28, 2013 at 01:28:35PM -0400, Peter Eisentraut wrote: > > On 6/28/13 11:30 AM, Robert Haas wrote: > > > On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane wrote: > > >> David Fetter writes: > > >>> Please find attached the latest patch.

Re: [HACKERS] plpython implementation

On 2013-06-30 22:43:52 -0300, Claudio Freire wrote: > Not only that, the CPython interpreter is rather fuzzy about the > division between interpreters. You can initialize multiple > interpreters, but they share a lot of state, so you can never fully > separate them. You'd have some state from the u

Re: [HACKERS] proposal: simple date constructor from numeric values

Hello 2013/6/29 Pavel Stehule : > Hello > > long time I am thinking about simple function for creating date or > timestamp values based on numeric types without necessity to create > format string. > > some like ansi_date(year, month, day) and ansi_timestamp(year, month, > day, hour, minuts, sec,

Re: [HACKERS] Optimizing pglz compressor

On 26.06.2013 16:37, Amit Kapila wrote: On Wednesday, June 26, 2013 2:15 AM Heikki Linnakangas wrote: Can you also try the attached patch, please? It's the same as before, but in this version, I didn't replace the prev and next pointers in PGLZ_HistEntry struct with int16s. That avoids some tabl

Re: [HACKERS] Review: query result history in psql

I'm not really bought into some of the ideas. but maybe some interactive mode should be usefull - so after >> execution, and showing result, will be prompt if result should be >> saved or not. > > I like the idea, in addition to the ordinary mode. Personally, I would use > the ordinary mode, but

Re: [HACKERS] Review: query result history in psql

2013/7/1 Maciej Gajewski : > I'm not really bought into some of the ideas. > > >>> but maybe some interactive mode should be usefull - so after >>> execution, and showing result, will be prompt if result should be >>> saved or not. >> >> I like the idea, in addition to the ordinary mode. Personally

Re: [HACKERS] Bugfix and new feature for PGXS

Le samedi 29 juin 2013 22:00:34, Josh Berkus a écrit : > On 06/29/2013 11:42 AM, Andrew Dunstan wrote: > > I think we can survive for now without an additional tool. What I did > > was a proof of concept, it was not intended as a suggestion that we > > should install prep_buildtree. I am only sugge

Re: [HACKERS] [PATCH] add --progress option to pgbench (submission 3)

(2013/06/28 3:17), Fabien COELHO wrote: Attached is patch version 5. It includes this solution for fork emulation, one report per thread instead of a global report. Some code duplication for that. It's good coding. I test configure option with --disable-thread-safety and not. My test results we

Re: [HACKERS] GIN improvements part 3: ordering in index

On Sun, Jun 30, 2013 at 3:09 PM, Heikki Linnakangas wrote: > On 25.06.2013 21:18, Alexander Korotkov wrote: > >> On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas> vmware.com >> >>> wrote: >>> >> >> In summary: The test case you presented as motivation for this patch is a >>> bit of a worst-c

Re: [HACKERS] GIN improvements part 1: additional information

On Sun, Jun 30, 2013 at 2:50 PM, Heikki Linnakangas wrote: > On 29.06.2013 20:08, Heikki Linnakangas wrote: > >> On 29.06.2013 11:56, Heikki Linnakangas wrote: >> >>> I made one significant change: I removed the 'freespace' field you added >>> to GinpageOpaque. Instead, on data leaf pages the off

Re: [HACKERS] GIN improvements part 1: additional information

On Thu, Jun 27, 2013 at 6:20 PM, Antonin Houska wrote: > On 06/25/2013 12:03 AM, Alexander Korotkov wrote: > >> >> >> New revision of patch is attached. Now it includes some docs. >> >> >> > Hi, > I was curious about the new layout of the data page, so I spent a while > looking into the code. > It

Re: [HACKERS] [PATCH] add --progress option to pgbench (submission 3)

Dear Mitsumasa, I have small comments. I think that 'lat' is not generally abbreviation of 'latency'. But I don't know good abbreviation. If you have any good abbreviation, please send us revise version. I needed something short, because I may add a "lag" time as well under throttling. No b

Re: [HACKERS] Review: query result history in psql

> When I tested this feature, I had 30 caches per 5 minutes, and only a > few from these queries had a sense. Switch between off and on is not > user friendly. I believe so there can be other solution than mine, but > a possibility to friendly clean unwanted caches is necessary. If you know that

Re: [HACKERS] Review: query result history in psql

2013/7/1 Maciej Gajewski : > >> When I tested this feature, I had 30 caches per 5 minutes, and only a >> few from these queries had a sense. Switch between off and on is not >> user friendly. I believe so there can be other solution than mine, but >> a possibility to friendly clean unwanted caches

Re: [HACKERS] [PATCH] add --progress option to pgbench (submission 3)

Hi, Febien Thanks for your fast response and fix! I set your patch ready for commiter now. (2013/07/01 19:49), Fabien COELHO wrote: I have small comments. I think that 'lat' is not generally abbreviation of 'latency'. But I don't know good abbreviation. If you have any good abbreviation, please

Re: [HACKERS] Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls

On Sun, Jun 30, 2013 at 10:07 PM, Nicholas White wrote: > I've attached another iteration of the patch that fixes the multiple-window > bug and adds (& uses) a function to create a Bitmapset using a custom > allocator. I don't think there's any outstanding problems with it now. I think the right

Re: [HACKERS] Review: Display number of changed rows since last analyze

On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote: > This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz > > The patch applies cleanly (with the exception of catversion.h of course), > compiles without warnings and passes the regression tests. > > It contains enough documentation,

Re: [HACKERS] Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls

On 1 July 2013 03:07, Nicholas White wrote: > I've attached another iteration of the patch that fixes the multiple-window > bug and adds (& uses) a function to create a Bitmapset using a custom > allocator. I don't think there's any outstanding problems with it now. > I just realised there is ano

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

On Tue, Feb 5, 2013 at 10:39 AM, Albe Laurenz wrote: > I found a small bug in the implementation of LDAP connection > parameter lookup. > > As documented in > http://www.postgresql.org/docs/current/static/libpq-ldap.html > processing should continue after a failed attempt > to connect to an LDAP s

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

On 7/1/13 7:58 AM, Magnus Hagander wrote: >> I also tried to fix the problem mentioned in >> > http://www.postgresql.org/message-id/CA+TgmoYnj=Es3L_0Q8+ijR4tVhvztW1fb=7c9k9gemzwqhp...@mail.gmail.com >> > that we use deprecated OpenLDAP functions, see the attached >> > ldap-undeprecate.patch. >> > >

Re: [HACKERS] Review: Display number of changed rows since last analyze

Magnus Hagander wrote: > On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz wrote: >> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz >> >> The patch applies cleanly (with the exception of catversion.h of course), >> compiles without warnings and passes the regression tests. >> >> It

Re: [HACKERS] Review: Display number of changed rows since last analyze

On Mon, Jul 1, 2013 at 2:48 PM, Albe Laurenz wrote: > Magnus Hagander wrote: >> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz >> wrote: >>> This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz >>> >>> The patch applies cleanly (with the exception of catversion.h of course), >>> comp

Re: [HACKERS] New regression test time

On Monday, July 01, 2013 8:37 AM Josh Berkus wrote: On 06/30/2013 12:33 AM, Amit kapila wrote: > > On Sunday, June 30, 2013 11:37 AM Fabien COELHO wrote: If we had a different set of tests, that would be a valid argument. But we don't, so it's not. And nobody has offered to write a feat

Re: [HACKERS] Review: Display number of changed rows since last analyze

Magnus Hagander wrote: >>> On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz >>> wrote: I think that the column name is ok as it is, even if it is a bit long - I cannot come up with a more succinct idea. Perhaps "n_changed_since_analyze" could be shortened to "n_mod_since_analyze

Re: [HACKERS] XLogInsert scaling, revisited

On 2013-06-26 18:52:30 +0300, Heikki Linnakangas wrote: > >* Could you document the way slots prevent checkpoints from occurring > > when XLogInsert rechecks for full page writes? I think it's correct - > > but not very obvious on a glance. > > There's this in the comment near the top of the fi

Re: [HACKERS] MVCC catalog access

On 2013-06-28 23:14:23 -0400, Robert Haas wrote: > Here's a further update of this patch. In this version, I added some > mechanism to send a new kind of sinval message that is sent when a > catalog without catcaches is updated; it doesn't apply to all > catalogs, just to whichever ones we want to

Re: [HACKERS] Documentation/help for materialized and recursive views

On 6/28/13 2:27 PM, David Fetter wrote: >> You can run \! man from within psql, > And if you're on Windows, you're Sadly Out of Luck with that. Is > there an equivalent we could #ifdef in for that platform? If you are using psql on Windows extensively, you probably have one of mingw, cygwin, or p

Re: [HACKERS] "pg_ctl promote" exit status

On 6/28/13 10:50 PM, Bruce Momjian wrote: > On Mon, Jan 28, 2013 at 09:46:32AM -0500, Peter Eisentraut wrote: >> On 1/26/13 4:44 PM, Aaron W. Swenson wrote: >>> You are right. Had I read a little further down, it seems that the >>> exit status should actually be 7. >> >> 7 is OK for "not running",

Re: [HACKERS] New regression test time

On Sat, Jun 29, 2013 at 02:59:35PM -0700, Josh Berkus wrote: > On 06/29/2013 02:14 PM, Andrew Dunstan wrote: > > AIUI: They do test feature use and errors that have cropped up in the > > past that we need to beware of. They don't test every bug we've ever > > had, nor do they exercise every piece o

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

Magnus Hagander wrote: > On Tue, Feb 5, 2013 at 10:39 AM, Albe Laurenz wrote: >> I found a small bug in the implementation of LDAP connection >> parameter lookup. [...] >> As coded now, the timeout won't work - if the LDAP server >> is down, ldap_simple_bind will wait for the network >> timeout,

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

Peter Eisentraut wrote: > Btw., I just checked the source code of Apache, PHP, and PAM, and they > are all unconditionally building with LDAP_DEPRECATED. So maybe there > is no hurry about this. I don't think that the old API functions will go away until there is a new standard for the LDAP C API

Re: [HACKERS] Documentation/help for materialized and recursive views

On Mon, Jul 01, 2013 at 10:05:24AM -0400, Peter Eisentraut wrote: > On 6/28/13 2:27 PM, David Fetter wrote: > >> You can run \! man from within psql, > > And if you're on Windows, you're Sadly Out of Luck with that. Is > > there an equivalent we could #ifdef in for that platform? > > If you are u

Re: [HACKERS] [PATCH] big test separation POC

Hi Fabien, On Mon, Jul 1, 2013 at 10:42 AM, Fabien COELHO wrote: > > - I do not understand why the makefile specifies $(srcdir) before >>>local files in some places. >>> >> >> For VPATH builds :-) >> > > Here is a v2 which is more likely to work under VPATH. I really appreciate your effo

Re: [HACKERS] New regression test time

On 2013-07-01 07:14:23 -0700, David Fetter wrote: > > If we had a different set of tests, that would be a valid argument. But > > we don't, so it's not. And nobody has offered to write a feature to > > split our tests either. > With utmost respect, this just isn't true. There is a "make coverag

Re: [HACKERS] Documentation/help for materialized and recursive views

On 7/1/13 10:20 AM, David Fetter wrote: > On Mon, Jul 01, 2013 at 10:05:24AM -0400, Peter Eisentraut wrote: >> On 6/28/13 2:27 PM, David Fetter wrote: You can run \! man from within psql, >>> And if you're on Windows, you're Sadly Out of Luck with that. Is >>> there an equivalent we could #if

Re: [HACKERS] checking variadic "any" argument in parser - should be array

Pavel Stehule escribió: > Hello > > updated patch - precious Assert, more comments Pavel, can you please remove quoted text from messages you reply to? This message has 10kb of completely useless text. Thanks, -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] checking variadic "any" argument in parser - should be array

2013/6/29 Pavel Stehule : > Hello > > updated patch - precious Assert, more comments > > Regards > > Pavel > stripped variadic_any_parser_check-3.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://ww

Re: [HACKERS] request a new feature in fuzzystrmatch

Joe Conway escribió: > Actually, given that this change will create version 1.1 of the > extension, I believe the 1.0 versions of the sql scripts should > probably be removed entirely. Can someone with more knowledge of the > extension facility comment on that? Besides what Michael said, another

[HACKERS] Shorter iterations of join_info_list

As far as I understand, deconstruct_recurse() ensures that SpecialJoinInfo of a new join always gets added to higher position in join_info_list than SJ infos of all joins located below the new join in the tree. I wonder if we can rely on that fact sometimes. One possible use case could be pla

Re: [HACKERS] Documentation/help for materialized and recursive views

On Mon, Jul 01, 2013 at 10:52:55AM -0400, Peter Eisentraut wrote: > On 7/1/13 10:20 AM, David Fetter wrote: > > On Mon, Jul 01, 2013 at 10:05:24AM -0400, Peter Eisentraut wrote: > >> On 6/28/13 2:27 PM, David Fetter wrote: > You can run \! man from within psql, > >>> And if you're on Windows,

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Sun, Jun 30, 2013 at 11:52 PM, Greg Smith wrote: > On 6/30/13 9:28 PM, Jon Nelson wrote: >> >> The performance of the latter (new) test sometimes seems to perform >> worse and sometimes seems to perform better (usually worse) than >> either of the other two. In all cases, posix_fallocate perfor

Re: [HACKERS] Passing fdw_private data from PlanForeignScan to PlanForeignModify

--On 13. Juni 2013 18:12:05 -0400 Tom Lane wrote: What i tried before was to access (in PlanForeignModify) the RelOptInfo structure through PlannerInfo->simple_rel_array, assuming the the resultRelation index points to the right array member. However, that didn't work, the fdw_private List i

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

My PostgresSQL (9.2) is crashing after certain load tests. Currently, postgressql is crashing when simulatenously 800 to 1000 threads are run on a 10 million records schema. Not sure, if we have to tweak some more parameters of postgres. - jasmine -- View this message in context: http://po

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

On 1 July 2013 01:44, David Fetter wrote: > On Fri, Jun 28, 2013 at 09:22:52PM +0100, Dean Rasheed wrote: >> On 21 June 2013 06:16, David Fetter wrote: >> > Please find attached a patch which allows subqueries in the FILTER >> > clause and adds regression testing for same. >> > >> >> This needs r

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 01, 2013 at 04:42:04AM -0700, jasmine wrote: > My PostgresSQL (9.2) is crashing after certain load tests. Currently, > postgressql is crashing when simulatenously 800 to 1000 threads are run on a > 10 million records schema. Not sure, if we have to tweak some more > parameters of postgr

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Sun, 2013-06-30 at 16:09 -0400, Andrew Dunstan wrote: > It was originally generated. Since then it's been maintained by hand. What is the procedure for maintaining it by hand? Why are HAVE_POSIX_SIGNALS and HAVE_SYNC_FILE_RANGE in there (though commented out), but not HAVE_POSIX_FADVISE? Regar

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

Very minor comment here: these SGML "id" tags: + are pretty important, because they become the URL for the specific page in the reference docs. So I think you should fix them to be the correct spelling of the command "alter template for extension", and also perhaps add an hyphen or two. Maybe

Re: [HACKERS] pg_ctl and -h/help

On Sun, Jun 30, 2013 at 02:29:20PM +0900, Michael Paquier wrote: > On Sat, Jun 29, 2013 at 10:45 PM, Bruce Momjian wrote: > > In studying pg_upgrade's handling of --help, I noticed that pg_ctl > > supports -h for help, but it is the only tool to do so, and -h is not > > documented. I propose we r

Re: [HACKERS] "pg_ctl promote" exit status

On Mon, Jul 1, 2013 at 10:11:23AM -0400, Peter Eisentraut wrote: > On 6/28/13 10:50 PM, Bruce Momjian wrote: > > On Mon, Jan 28, 2013 at 09:46:32AM -0500, Peter Eisentraut wrote: > >> On 1/26/13 4:44 PM, Aaron W. Swenson wrote: > >>> You are right. Had I read a little further down, it seems that t

Re: [HACKERS] Optimizing pglz compressor

On Mon, Jul 1, 2013 at 11:05:37AM +0300, Heikki Linnakangas wrote: > On 26.06.2013 16:37, Amit Kapila wrote: > >On Wednesday, June 26, 2013 2:15 AM Heikki Linnakangas wrote: > >>Can you also try the attached patch, please? It's the same as before, > >>but in this version, I didn't replace the prev

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Sun, 2013-06-30 at 18:55 -0400, Greg Smith wrote: > This makes platform level testing a lot easier, thanks. Attached is an > updated copy of that program with some error checking. If the files it > creates already existed, the code didn't notice, and a series of write > errors happened. If

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

I think this is unlikely to work reliably: + PG_TRY(); + { + ExtensionControl *control = read_extension_control_file(extname); + + if (control) + { + ereport(ERROR, + (errcode(ERRCODE_DUPLICATE_OBJECT), +errmsg("extension \"%s\

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 10:02 PM, David Fetter wrote: > On Mon, Jul 01, 2013 at 04:42:04AM -0700, jasmine wrote: >> My PostgresSQL (9.2) is crashing after certain load tests. Currently, >> postgressql is crashing when simulatenously 800 to 1000 threads are run on a >> 10 million records schema. Not

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Tue, Jul 2, 2013 at 1:55 AM, Jeff Davis wrote: > On Sun, 2013-06-30 at 18:55 -0400, Greg Smith wrote: >> This makes platform level testing a lot easier, thanks. Attached is an >> updated copy of that program with some error checking. If the files it >> creates already existed, the code didn't

Re: [HACKERS] Minor inheritance/check bug: Inconsistent behavior

On Sun, Jun 30, 2013 at 06:57:10AM +, Amit kapila wrote: > >> I have done the initial analysis and prepared a patch, don't know if > >> anything more I can do until > >> someone can give any suggestions to further proceed on this bug. > > >So, I guess we never figured this out. > > I can subm

Re: [HACKERS] Eliminating PD_ALL_VISIBLE, take 2

On Sun, 2013-06-30 at 22:58 -0400, Robert Haas wrote: > I thought that Jeff withdrew this patch. No -- was there a reason you thought that? I know it could use another round of testing before commit, and there may be a couple other things to clear up. But I don't want to invest a lot of time there

Re: [HACKERS] Outputting UTC offset with to_char()

Applied. I referenced macros for some of the new constants, e.g. SECS_PER_HOUR. --- On Fri, Jun 28, 2013 at 10:04:49PM -0400, Bruce Momjian wrote: > On Sun, Oct 21, 2012 at 05:40:40PM -0400, Andrew Dunstan wrote: > > > > I

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

Since this discussion seems to have stalled, let me do a quick summary. The goal of this subset of patches is to allow retroactive look up of relations starting from a WAL record. Currently, the WAL record only tracks the relfilenode that it affects, so there are two possibilities: 1. we add some

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

Alvaro Herrera writes: > So the question is, do we take the overhead of the new index (which > means overhead on DML operations -- supposedly rare) or do we take the > overhead of larger WAL records (which means overhead on all DDL > operations)? > Note we can make either thing apply to only peop

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Tue, 2013-07-02 at 02:13 +0900, Fujii Masao wrote: > Even in that case, if a user can easily know which platform posix_fallocate > should be used in, we can commit the patch with the configurable GUC > parameter. I disagree here. We're not talking about a huge win; this speedup may not even be

Re: [HACKERS] Move unused buffers to freelist

On Sun, Jun 30, 2013 at 3:24 AM, Amit kapila wrote: > Do you think it will be sufficient to just wake bgwriter when the buffers in > freelist drops > below low watermark, how about it's current job of flushing dirty buffers? Well, the only point of flushing dirty buffers in the background writer

Re: [HACKERS] review: Non-recursive processing of AND/OR lists

On Sun, Jun 30, 2013 at 1:08 PM, Pavel Stehule wrote: > 2013/6/30 Gurjeet Singh : >> On Sun, Jun 30, 2013 at 11:46 AM, Pavel Stehule >> wrote: >>> >>> 2013/6/30 Gurjeet Singh : >>> > On Sun, Jun 30, 2013 at 11:13 AM, Pavel Stehule >>> > >>> > wrote: >>> > >>> > How about naming those 3 variables

Re: [HACKERS] Support for RANGE ... PRECEDING windows in OVER

On Sun, Jun 30, 2013 at 11:54 PM, ian link wrote: > I found some time and I think I am up to speed now. I finally figured out > how to add new operator strategies and made a little test operator for > myself. > > It seems pretty clear that assuming '+' and '-' are addition and subtraction > is a b

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

On 2013-07-01 14:16:55 -0400, Tom Lane wrote: > Alvaro Herrera writes: > > So the question is, do we take the overhead of the new index (which > > means overhead on DML operations -- supposedly rare) or do we take the > > overhead of larger WAL records (which means overhead on all DDL > > operatio

Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division

On Mon, Jul 1, 2013 at 3:19 AM, Jeevan Chalke wrote: > I have re-validated this new patch and it looks good to go in now. > > I saw that it's already marked ready for committer. I don't normally like to commit things over another committer's objections, but this has +1 votes from four other commi

Re: [HACKERS] [PATCH] big test separation POC

While testing patch, I found that make installcheck breaks with your patch and gives following error: Indeed, I did not put the dependency for that target, I really tested "check" & "bigcheck". The attached patch adds the needed dependency for installcheck, and I could run it. I checked that

Re: [HACKERS] MVCC catalog access

On Mon, Jul 1, 2013 at 10:04 AM, Andres Freund wrote: > This is really cool stuff. Thanks. > I have to say, if the thing that primarily suffers is pretty extreme DDL > in extreme situations I am not really worried. Anybody running anything > close to the territory of such concurrency won't perfo

Re: [HACKERS] Documentation/help for materialized and recursive views

On Mon, Jul 1, 2013 at 10:20 AM, David Fetter wrote: > With deepest respect, failing to provide documentation to users on our > widest-deployed platform seems pretty hostile to me. Yes, that would be pretty hostile. However, we don't do anything that remotely resembles that statement, nor has an

Re: [HACKERS] Support for RANGE ... PRECEDING windows in OVER

Robert Haas escribió: > On Sun, Jun 30, 2013 at 11:54 PM, ian link wrote: > > It seems pretty clear that assuming '+' and '-' are addition and subtraction > > is a bad idea. I don't think it would be too tricky to add support for new > > operator strategies. Andrew Gierth suggested calling these

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Sun, Jun 30, 2013 at 8:30 AM, Atri Sharma wrote: > I have been reading the recent discussion and was researching a bit, and I > think that we should really go with the idea of randomising the input data(if > it is not completely presorted), to ensure that we do not get quadratic > complexity

Re: [HACKERS] Documentation/help for materialized and recursive views

On 07/01/2013 03:26 PM, Robert Haas wrote: Regardless of whether you agree with or disagree with the above statement, building a high-quality documentation reader into psql so that users who are running Windows but not mingw, cygwin, or pgAdmin can access the documentation more easily doesn't se

Re: [HACKERS] Support for RANGE ... PRECEDING windows in OVER

On Mon, Jul 1, 2013 at 3:28 PM, Alvaro Herrera wrote: > Robert Haas escribió: >> On Sun, Jun 30, 2013 at 11:54 PM, ian link wrote: > >> > It seems pretty clear that assuming '+' and '-' are addition and >> > subtraction >> > is a bad idea. I don't think it would be too tricky to add support for

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On Mon, Jul 1, 2013 at 2:17 PM, Jeff Davis wrote: > On Tue, 2013-07-02 at 02:13 +0900, Fujii Masao wrote: >> Even in that case, if a user can easily know which platform posix_fallocate >> should be used in, we can commit the patch with the configurable GUC >> parameter. > > I disagree here. We're

Re: [HACKERS] extensible external toast tuple support

On 2013-06-28 11:25:50 -0400, Robert Haas wrote: > On Fri, Jun 28, 2013 at 10:53 AM, Andres Freund > wrote: > >> Why does toast_insert_or_update() need to go through all the > >> rigamarole in toast_datum_differs()? I would have thought that it > >> could simply treat any external-indirect value

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 4:32 PM, Robert Haas wrote: >> This shouldn't be too complex, and should give us a fixed nlogn complexity >> even for wild data sets, without affecting existing normal data sets that >> are present in every day transactions. I even believe that those data sets >> will als

Re: [HACKERS] Documentation/help for materialized and recursive views

On Mon, Jul 1, 2013 at 9:26 PM, Robert Haas wrote: > On Mon, Jul 1, 2013 at 10:20 AM, David Fetter wrote: >> With deepest respect, failing to provide documentation to users on our >> widest-deployed platform seems pretty hostile to me. > > Yes, that would be pretty hostile. However, we don't do

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On 7/1/13 12:34 PM, Jeff Davis wrote: > On Sun, 2013-06-30 at 16:09 -0400, Andrew Dunstan wrote: >> It was originally generated. Since then it's been maintained by hand. > > What is the procedure for maintaining it by hand? Edit away. > Why are > HAVE_POSIX_SIGNALS and HAVE_SYNC_FILE_RANGE in th

Re: [HACKERS] Eliminating PD_ALL_VISIBLE, take 2

On Mon, Jul 1, 2013 at 1:21 PM, Jeff Davis wrote: > On Sun, 2013-06-30 at 22:58 -0400, Robert Haas wrote: >> I thought that Jeff withdrew this patch. > > No -- was there a reason you thought that? I thought I remembered you saying you were going to abandon it in the face of objections. > I know

Re: [HACKERS] Documentation/help for materialized and recursive views

On Mon, Jul 1, 2013 at 3:57 PM, Magnus Hagander wrote: > How different are they really? Yes, they are very different from an > implementation standpoint, from an enduser perspective they really are > not. If they were, they'd probably be called something else. They're different because they consu

Re: [HACKERS] Documentation/help for materialized and recursive views

On 07/01/2013 07:20 AM, David Fetter wrote: On Mon, Jul 01, 2013 at 10:05:24AM -0400, Peter Eisentraut wrote: On 6/28/13 2:27 PM, David Fetter wrote: You can run \! man from within psql, And if you're on Windows, you're Sadly Out of Luck with that. Is there an equivalent we could #ifdef in

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 3:54 PM, Claudio Freire wrote: > On Mon, Jul 1, 2013 at 4:32 PM, Robert Haas wrote: >>> This shouldn't be too complex, and should give us a fixed nlogn complexity >>> even for wild data sets, without affecting existing normal data sets that >>> are present in every day tr

Re: [HACKERS] "pg_ctl promote" exit status

On 7/1/13 12:47 PM, Bruce Momjian wrote: >> Approximately none of these changes seem correct to me. For example, >> why is failing to open the PID file 6, or failing to start the server 7? > > Well, according to that URL, we have: > > 6 program is not configured > 7 progr

Re: [HACKERS] GIN improvements part 1: additional information

On 01.07.2013 13:28, Alexander Korotkov wrote: Thanks! So, we have a lot of stuff and you give the points for further work. Could you please verify my plan of work on these patches: 1) Solving questions of archives.postgresql.org/** message-id/51CEA13C.8040103@**vmware.com

Re: [HACKERS] plpython implementation

On 7/1/13 1:29 AM, james wrote: > Given how useful it is to have a scripting language that can be used > outside > of the database as well as inside it, would it be reasonable to consider > 'promoting' pllua? You can start promoting pllua by making it work with current PostgreSQL versions. It has

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 5:12 PM, Robert Haas wrote: > On Mon, Jul 1, 2013 at 3:54 PM, Claudio Freire wrote: >> On Mon, Jul 1, 2013 at 4:32 PM, Robert Haas wrote: This shouldn't be too complex, and should give us a fixed nlogn complexity even for wild data sets, without affecting existi

Re: [HACKERS] Bugfix and new feature for PGXS

On 6/29/13 1:54 PM, Andrew Dunstan wrote: > I haven't seen a response to this. One thing we are missing is > documentation. Given that I'm inclined to commit all of this (i.e. > cedric's patches 1,2,3, and 4 plus my addition). Could someone post an updated set of patches that is currently under co

Re: [HACKERS] proposal: simple date constructor from numeric values

On 7/1/13 3:47 AM, Pavel Stehule wrote: > and it is a part of our ToDo: "Add function to allow the creation of > timestamps using parameters" > > so we can have a functions with signatures I would just name them date(...), time(...), etc. > CREATE OR REPLACE FUNCTION construct_date(year int, mon

Re: [HACKERS] Add regression tests for DISCARD

On 17 June 2013 18:14, Marko Kreen wrote: > Perhaps existing tests in guc.sql should be merged into it? > > Thanks Marko for pointing out about guc.sql. Please find attached a patch to move DISCARD related tests from guc.sql to discard.sql. It adds an extra test for a DISCARD PLANS line, althoug

Re: [HACKERS] pg_resetxlog -m documentation not up to date

On 6/19/13 9:57 PM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> Ping. This ought to be fixed before 9.3 goes out. > > Will fix. > >> On Sat, 2013-04-27 at 21:22 -0400, Peter Eisentraut wrote: >>> The pg_resetxlog -m option was changed from The man page lists the -m option as -m mxid,mxid

Re: [HACKERS] Bugfix and new feature for PGXS

On 07/01/2013 04:39 PM, Peter Eisentraut wrote: On 6/29/13 1:54 PM, Andrew Dunstan wrote: I haven't seen a response to this. One thing we are missing is documentation. Given that I'm inclined to commit all of this (i.e. cedric's patches 1,2,3, and 4 plus my addition). Could someone post an upd

Re: [HACKERS] changeset generation v5-01 - Patches & git tree

On 27 June 2013 23:18, Tom Lane wrote: > Exactly what is the argument that says performance of this > function is sufficiently critical to justify adding both the maintenance > overhead of a new pg_class index, *and* a broken-by-design syscache? > I think we all agree on changing the syscache.

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

On 7/1/13 3:44 PM, Robert Haas wrote: Yeah. If the patch isn't going to be a win on RHEL 5, I'd consider that a good reason to scrap it for now and revisit it in 3 years. There are still a LOT of people running RHEL 5, and the win isn't big enough to engineer a more complex solution. I'm still

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 12:32 PM, Robert Haas wrote: >> I have been reading the recent discussion and was researching a bit, and I >> think that we should really go with the idea of randomising the input >> data(if it is not completely presorted), to ensure that we do not get >> quadratic comple

Re: [HACKERS] pg_resetxlog -m documentation not up to date

Peter Eisentraut wrote: > On 6/19/13 9:57 PM, Alvaro Herrera wrote: > > Peter Eisentraut wrote: > >> Ping. This ought to be fixed before 9.3 goes out. > > > > Will fix. > > > >> On Sat, 2013-04-27 at 21:22 -0400, Peter Eisentraut wrote: > >>> The pg_resetxlog -m option was changed from > > The

Re: [HACKERS] Documentation/help for materialized and recursive views

Robert Haas escribió: > On Mon, Jul 1, 2013 at 3:57 PM, Magnus Hagander wrote: > > I still think a better option to that would be to get psql to provide > > a link to the full documentation there. > > It seems like clutter to me, but I'll defer to whatever the consensus is. I second the idea of

Re: [HACKERS] extensible external toast tuple support

On Mon, Jul 1, 2013 at 3:49 PM, Andres Freund wrote: >> I must be missing something. At that point, yes, you'd like to avoid >> re-toasting unnecessarily, but ISTM you've already bought the farm. >> Unless I'm misunderstanding the code as written, you'd just end up >> writing the indirect pointer

Re: [HACKERS] Randomisation for ensuring nlogn complexity in quicksort

On Mon, Jul 1, 2013 at 4:31 PM, Claudio Freire wrote: > What? > > A median of medians algorithm will guarantee floor(N/2) elements on > the smaller. That's the definition of median. > > Note that I'm referring to picking the actual median of all tuples, > not just a sample. That's slow, but it gua

  1   2   >