Re: [HACKERS] Postgres_fdw join pushdown - wrong results with whole-row reference

On 2016/06/28 13:53, Ashutosh Bapat wrote: Ideally, we should point out the specific column that faced the conversion problem and report it, instead of saying the whole row reference conversion caused the problem. But that may be too difficult. I think so too. Or at least the error message

[HACKERS] Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ?

On Sun, Jun 26, 2016 at 10:22:26PM -0400, Noah Misch wrote: > On Wed, Jun 15, 2016 at 11:08:54AM -0400, Noah Misch wrote: > > On Wed, Jun 15, 2016 at 03:02:15PM +0300, Teodor Sigaev wrote: > > > On Wed, Jun 15, 2016 at 02:54:33AM -0400, Noah Misch wrote: > > > > On Mon, Jun 13, 2016 at 10:44:06PM

Re: [HACKERS] Postgres_fdw join pushdown - wrong results with whole-row reference

On Tue, Jun 28, 2016 at 11:43 AM, Etsuro Fujita wrote: > On 2016/06/28 13:53, Ashutosh Bapat wrote: > >> Ideally, we should point out the specific column that faced the >> conversion problem and report it, instead of saying the whole row >> reference conversion

Re: [HACKERS] Postgres_fdw join pushdown - wrong results with whole-row reference

On 2016/06/28 15:23, Ashutosh Bapat wrote: The wording "column "whole-row reference ..." doesn't look good. Whole-row reference is not a column. The error context itself should be "whole row reference for foreign table ft1". Ah, you are right. Please find attached an updated version. Best

Re: [HACKERS] Improving executor performance

On 25 June 2016 05:00, Andres Freund Wrote: >To: pgsql-hackers@postgresql.org >Subject: [HACKERS] Improving executor performance > >My observations about the performance bottlenecks I found, and partially >addressed, are in rough order of importance (there's interdependence >between most of them):

Re: [HACKERS] Patch to implement pg_current_logfile() function

Le 07/04/2016 08:30, Karl O. Pinc a écrit : > On Thu, 7 Apr 2016 01:13:51 -0500 > "Karl O. Pinc" wrote: > >> On Wed, 6 Apr 2016 23:37:09 -0500 >> "Karl O. Pinc" wrote: >> >>> On Wed, 6 Apr 2016 22:26:13 -0500 >>> "Karl O. Pinc" wrote: On Wed,

Re: [HACKERS] fixing subplan/subquery confusion

On Tue, Jun 28, 2016 at 8:25 AM, Tom Lane wrote: > Amit Kapila writes: >> I had couple of questions [1] related to that patch. See if you find >> those as relevant? > > I do not think those cases are directly relevant: you're talking about >

Re: [HACKERS] Reviewing freeze map code

On Tue, Jun 21, 2016 at 6:59 AM, Andres Freund wrote: > On 2016-06-20 17:55:19 -0400, Robert Haas wrote: >> On Mon, Jun 20, 2016 at 4:24 PM, Andres Freund wrote: >> > On 2016-06-20 16:10:23 -0400, Robert Haas wrote: >> >> What exactly is the point of all

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

Rushabh Lathia writes: > SELECT setval('s', max(100)) from tab; > ERROR: ORDER/GROUP BY expression not found in targetlist Fixed, thanks for the report! regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Reviewing freeze map code

On Tue, Jun 28, 2016 at 8:06 PM, Masahiko Sawada wrote: > On Tue, Jun 21, 2016 at 6:59 AM, Andres Freund wrote: >> On 2016-06-20 17:55:19 -0400, Robert Haas wrote: >>> On Mon, Jun 20, 2016 at 4:24 PM, Andres Freund wrote: >>> > On

[HACKERS] Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ?

On Tue, Jun 28, 2016 at 9:32 AM, Noah Misch wrote: > On Sun, Jun 26, 2016 at 10:22:26PM -0400, Noah Misch wrote: >> On Wed, Jun 15, 2016 at 11:08:54AM -0400, Noah Misch wrote: >> > On Wed, Jun 15, 2016 at 03:02:15PM +0300, Teodor Sigaev wrote: >> > > On Wed, Jun 15, 2016 at

[HACKERS] seg fault on dsm_create call

Hello, sorry for my repost from psql-novice, probably it was not a right place for my question. I'm trying to understand how to work with dynamic shared memory, message queues and workers. The problem is I can not initialize any dsm segment - void _PG_init() { ...

Re: [HACKERS] [HITB-Announce] HITB2016AMS Videos & GSEC Singapore Voting

Robert Haas wrote: > On Mon, Jun 27, 2016 at 5:29 PM, Alvaro Herrera > wrote: > > Robert Haas wrote: > >> On Mon, Jun 20, 2016 at 5:41 PM, Hafez Kamal > >> wrote: > >> > See you in Singapore! > >> > >> This seems totally off-topic. Shouldn't a

[HACKERS] seg fault on dsm_create call

Some debug info related to my previous post - * thread #1: tid = 0x2601e9, 0x000100313e5e postgres`ResourceOwnerEnlargeDSMs + 10, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x130) * frame #0: 0x000100313e5e postgres`ResourceOwnerEnlargeDSMs + 10

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

Noah Misch wrote: > On Sun, Jun 19, 2016 at 05:56:12PM +0900, Michael Paquier wrote: > > The new pg_stat_wal_receiver does not include primary_conninfo. > > Looking at that now, it looks almost stupid not to include it... > > Adding it now would require a catalog bump, so I am not sure if this > >

Re: [HACKERS] Reference to UT1

On Wed, Jun 22, 2016 at 04:51:46PM -0400, Bruce Momjian wrote: > On Mon, Jun 6, 2016 at 03:53:41PM +1200, Thomas Munro wrote: > > Hi > > > > The manual[1] says "Technically,PostgreSQL uses UT1 rather than UTC > > because leap seconds are not handled." I'm certainly no expert on > > this stuff

Re: [HACKERS] Questionabl description in datatype.sgml

On Fri, Jun 24, 2016 at 07:27:24AM +0900, Tatsuo Ishii wrote: > > On Sat, Jun 18, 2016 at 11:58:58AM -0400, Tom Lane wrote: > >> Tatsuo Ishii writes: > >> > In "8.13.2. Encoding Handling" > >> > > >> > When using binary mode to pass query parameters to the server >

Re: [HACKERS] seg fault on dsm_create call

On Tue, Jun 28, 2016 at 10:11 AM, Max Fomichev wrote: > Hello, > sorry for my repost from psql-novice, probably it was not a right place for > my question. > > I'm trying to understand how to work with dynamic shared memory, message > queues and workers. > The problem is

Re: [HACKERS] seg fault on dsm_create call

On 28/06/16 19:24, Robert Haas wrote: On Tue, Jun 28, 2016 at 10:11 AM, Max Fomichev wrote: Hello, sorry for my repost from psql-novice, probably it was not a right place for my question. I'm trying to understand how to work with dynamic shared memory, message queues

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Michael Paquier writes: > > > On Tue, Jun 21, 2016 at 11:29 AM, Tom Lane wrote: > > >> What I would want to know is whether this specific change is actually a > > >> good idea. In

Re: [HACKERS] An unkillable connection caused replication delay on my replica

Shawn wrote: > strace of long-running query pid 6819 loops like this: > > sendto(10, "" NULL, 0) = ? ERESTARTSYS (To be > restarted if SA_RESTART is set) > --- SIGUSR1 {si_signo=SIGUSR1, si_code=SI_USER, si_pid=8719, > si_uid=3001} --- > rt_sigreturn() > > Where pid 6819

Re: [HACKERS] seg fault on dsm_create call

On Tue, Jun 28, 2016 at 12:45 PM, Max Fomichev wrote: > On 28/06/16 19:24, Robert Haas wrote: > Thanks. > It works now with CurrentResourceOwner = ResourceOwnerCreate(NULL, "name of > my extension") > > I am a little bit confused about test/modules/test_shm_mq, where >

Re: [HACKERS] IPv6 link-local addresses and init data type

Haribabu, On 07.06.2016 07:19, Haribabu Kommi wrote: >> I have not looked at the spec, but I wouldn't be surprised if there >> were an upper limit on the length of valid scope names. Yeah, I didn't find any upper limit, either. > I am not able to find any link that suggests the maximum length

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

On Tue, Jun 28, 2016 at 2:52 PM, Rushabh Lathia wrote: > Hi, > > Consider the below testcase: > > CREATE TABLE tab( > c1 INT NOT NULL, > c2 INT NOT NULL > ); > INSERT INTO tab VALUES (1, 2); > INSERT INTO tab VALUES (2, 1); > INSERT INTO tab VALUES (1, 2); > > > case

Re: [HACKERS] make clean didn't clean up files generated from *.(y|l)

Kouhei Kaigai writes: > I tried to build the latest master branch just after the switch from > REL9_5_STABLE and "make clean", however, repl_gram.c was not cleaned > up correctly. So, my problem is that repl_gram.l was the latest version, > but compiler saw the repl_gram.c

Re: [HACKERS] Postgres_fdw join pushdown - wrong results with whole-row reference

On Tue, Jun 28, 2016 at 12:52 PM, Etsuro Fujita wrote: > On 2016/06/28 15:23, Ashutosh Bapat wrote: > >> The wording "column "whole-row reference ..." doesn't look good. >> Whole-row reference is not a column. The error context itself should be >> "whole row

Re: [HACKERS] Reviewing freeze map code

On Fri, Jun 24, 2016 at 11:04 AM, Amit Kapila wrote: > On Fri, Jun 24, 2016 at 4:33 AM, Andres Freund wrote: >> On 2016-06-23 18:59:57 -0400, Alvaro Herrera wrote: >>> Andres Freund wrote: >>> >>> > I'm looking into three approaches right now: >>> >

[HACKERS] ToDo: API for SQL statement execution other than SPI

Hi I am writing two background workers - autoreindex and scheduler. In Both I need to execute queries from top level. I had to wrote redundant code https://github.com/okbob/autoreindex/blob/master/utils.c autoreindex_execute_sql_command .Same code is in pglogical. Some statements - like VACUUM or

Re: [HACKERS] Documentation fixes for pg_visibility

On Tue, Jun 28, 2016 at 7:05 AM, Robert Haas wrote: > On Mon, Jun 27, 2016 at 5:56 PM, Michael Paquier > wrote: >>> Under what circumstances would you wish to check only one page of a >>> relation? >> >> What I'd like to be able to do is to stop

[HACKERS] Forthcoming SQL standards about JSON and Multi-Dimensional Arrays (FYI)

Hi, FYI: I'd just like to point you to following two forthcoming standard parts from "ISO/IEC JTS 1/SC 32" comittee: one on JSON, and one on "Multi-Dimensional Arrays" (SQL/MDA). They define there some things different as already in PG. See also Peter Baumann's slides [1] and e.g. [2] :Stefan

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

Michael Paquier wrote: > I have been thinking more about that, and came up with the following > idea... We do not want to link libpq directly to the server, so let's > add a new routine to libpqwalreceiver that builds an obfuscated > connection string and let's have walreceiver.c save it in

[HACKERS] Re: Should phraseto_tsquery('simple', 'blue blue') @@ to_tsvector('simple', 'blue') be true ?

On Tue, Jun 28, 2016 at 7:00 PM, Oleg Bartunov wrote: > On Tue, Jun 28, 2016 at 9:32 AM, Noah Misch wrote: >> On Sun, Jun 26, 2016 at 10:22:26PM -0400, Noah Misch wrote: >>> On Wed, Jun 15, 2016 at 11:08:54AM -0400, Noah Misch wrote: >>> > On Wed, Jun 15,

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

On Wed, Jun 29, 2016 at 6:42 AM, Alvaro Herrera wrote: > Michael Paquier wrote: > >> I have been thinking more about that, and came up with the following >> idea... We do not want to link libpq directly to the server, so let's >> add a new routine to libpqwalreceiver

Re: [HACKERS] Rename max_parallel_degree?

On 28/06/2016 04:44, Amit Kapila wrote: > On Mon, Jun 27, 2016 at 10:35 PM, Julien Rouhaud >> >> There's already a pg_memory_barrier() call in >> BackgroundWorkerStateChange(), to avoid reordering the notify_pid load. >> Couldn't we use it to also make sure the parallel_terminate_count >>

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

Michael Paquier wrote: > On Wed, Jun 29, 2016 at 6:42 AM, Alvaro Herrera > wrote: > > I have already edited the patch following some of these ideas. Will > > post a new version later. > > Cool, thanks. Here it is. I found it was annoying to maintain the function

Re: [HACKERS] ERROR: ORDER/GROUP BY expression not found in targetlist

Thanks Tom. I performed testing with the latest commit and test are running fine. On Tue, Jun 28, 2016 at 8:14 PM, Tom Lane wrote: > Rushabh Lathia writes: > > SELECT setval('s', max(100)) from tab; > > ERROR: ORDER/GROUP BY expression not found

[HACKERS] make clean didn't clean up files generated from *.(y|l)

Hello, I got the build error below. It concerns RESERVE_WAL is not defined, however, it should not be a problem to be oversight for a long time. I tried to build the latest master branch just after the switch from REL9_5_STABLE and "make clean", however, repl_gram.c was not cleaned up correctly.

[HACKERS] dumping database privileges broken in 9.6

Do this: CREATE DATABASE test1; REVOKE CONNECT ON DATABASE test1 FROM PUBLIC; Run pg_dumpall. In 9.5, this produces CREATE DATABASE test1 WITH TEMPLATE = template0 OWNER = peter; REVOKE ALL ON DATABASE test1 FROM PUBLIC; REVOKE ALL ON DATABASE test1 FROM peter; GRANT ALL ON DATABASE test1 TO

Re: [HACKERS] Gin index on array of uuid

What's a good source code entry point to review how this is working for anyarray currently? I am new to the postgres code. I spend some time looking for it but all I found is the following (which I have not been able to decipher yet). [image: pasted1] Thank you, Enrique On Tue, Jun 21, 2016

Re: [HACKERS] primary_conninfo missing from pg_stat_wal_receiver

On Wed, Jun 29, 2016 at 12:23 PM, Alvaro Herrera wrote: > Michael Paquier wrote: >> On Wed, Jun 29, 2016 at 6:42 AM, Alvaro Herrera >> wrote: > >> > I have already edited the patch following some of these ideas. Will >> > post a new version

Re: [HACKERS] How to kill a Background worker and Its metadata

On 28 June 2016 at 08:28, Akash Agrawal wrote: > I've handled SIGTERM signal. pg_terminate_backend send signals (SIGTERM) > to backend processes identified by process ID. And also, after this call I > am able to track in my logs that the background worker gets terminated. > >

Re: [HACKERS] Rename max_parallel_degree?

On Wed, Jun 29, 2016 at 2:57 AM, Julien Rouhaud wrote: > > Thanks a lot for the help! > > PFA v6 which should fix all the issues mentioned. Couple of minor suggestions. - . Note that the requested + , limited by + . Note that the requested

Re: [HACKERS] parallel workers and client encoding

On 6/27/16 5:37 PM, Robert Haas wrote: Please find attached an a patch for a proposed alternative approach. This does the following: 1. When the client_encoding GUC is changed in the worker, SetClientEncoding() is not called. I think this could be a problem, because then the client encoding

Re: [HACKERS] Postgres_fdw join pushdown - wrong results with whole-row reference

> > > > > postgres_fdw resets the search path to pg_catalog while opening > connection > > to the server. The reason behind this is explained in deparse.c > > > > * We assume that the remote session's search_path is exactly > "pg_catalog", > > * and thus we need schema-qualify all and only names

Re: [HACKERS] How to kill a Background worker and Its metadata

I've handled SIGTERM signal. pg_terminate_backend send signals (SIGTERM) to backend processes identified by process ID. And also, after this call I am able to track in my logs that the background worker gets terminated. Yet, I am only able to register first 8 background workers. I am using select

Re: [HACKERS] How to kill a Background worker and Its metadata

I am calling proc_exit(1) once the worker encounters SIGTERM signal. I've attached my code here. Here is the link to stackoverflow: http://stackoverflow.com/questions/38058628/how-to-kill-a-background-worker-including-its-metadata-in-postgres On Mon, Jun 27, 2016 at 8:41 PM, Craig Ringer