Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Mark Kirkwood
On 27/05/17 20:30, Erik Rijkers wrote: Here is what I have: instances.sh: starts up 2 assert enabled sessions instances_fast.sh: alternative to instances.sh starts up 2 assert disabled 'fast' sessions testset.sh loop to call pgbench_derail2.sh with varying params pgbench_derail2.sh

Re: [HACKERS] Extra Vietnamese unaccent rules

2017-05-28 Thread Dang Minh Huong
Hi, unaccent.patch Description: Binary data I am interested in this thread.On May 27, 29 Heisei, at 10:41, Michael Paquier wrote:On Fri, May 26, 2017 at 5:48 PM, Thomas Munro wrote:Unicode has two ways to represent characters with accents:

Re: [HACKERS] Broken hint bits (freeze)

2017-05-28 Thread Amit Kapila
On Sat, May 27, 2017 at 10:18 PM, Vladimir Borodin wrote: > > 26 мая 2017 г., в 21:39, Amit Kapila написал(а): > > I think you somehow need > to ensure before switchover that all the WAL is replicated to ensure > this is not a setup problem. > > > Well, actually clean shutdown of master with exi

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Erik Rijkers
On 2017-05-26 15:59, Petr Jelinek wrote: Hmm, I was under the impression that the changes we proposed in the snapbuild thread fixed your issues, does this mean they didn't? Or the modified versions of those that were eventually committed didn't? Or did issues reappear at some point? Here is a

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-28 Thread Tom Lane
Andrew Borodin writes: > Maybe we should make compress\decompress functions optional? 1. You'll need to adjust the documentation (gist.sgml) not just the code. 2. If compress/decompress are omitted, then we could support index-only scans all the time, that is a no-op fetch function would work.

Re: [HACKERS] execGrouping.c limit on work_mem

2017-05-28 Thread Tom Lane
Jeff Janes writes: > In BuildTupleHashTable > /* Limit initial table size request to not more than work_mem */ > nbuckets = Min(nbuckets, (long) ((work_mem * 1024L) / entrysize)); > Is this a good idea? If the caller of this code has no respect for > work_mem, they are still going to blo

Re: [HACKERS] PostgreSQL 10 changes in exclusion constraints - did something change? CASE WHEN behavior oddity

2017-05-28 Thread Tom Lane
"Regina Obe" writes: > Is this behavior going to stay or change? > It seems inconsistent from a user perspective that > CASE constant == short-circuit skipping over SRFs that may otherwise > fail > While > CASE not_constant_table_dependent doesn't short-circuit. > I can understand the moti

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-28 Thread Andrew Borodin
Thanks, Tom! 2017-05-28 22:22 GMT+05:00 Tom Lane : > Andrew Borodin writes: >> Maybe we should make compress\decompress functions optional? > > 1. You'll need to adjust the documentation (gist.sgml) not just the code. Sure, I'll check out where compression is mentioned and update docs. > 2. If c

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-28 Thread Tom Lane
Andrew Borodin writes: > 2017-05-28 22:22 GMT+05:00 Tom Lane : >> 2. If compress/decompress are omitted, then we could support index-only >> scans all the time, that is a no-op fetch function would work. The >> patch should cover that interaction too. > I do not think so. Decompress have to get

Re: [HACKERS] [pgsql-translators] pg_upgrade translation

2017-05-28 Thread Alvaro Herrera
Alvaro Herrera wrote: > Translatability was turned on for pg_upgrade on pg10, but it needs some > work. The choices are we fix it now, or we revert the addition of NLS > there and we do it for PG11. Here are two patches to fix the messages, replacing "new" with "target" and "old" with "source".

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-28 Thread Andrew Borodin
28 мая 2017 г. 11:15 PM пользователь "Tom Lane" написал: Andrew Borodin writes: > 2017-05-28 22:22 GMT+05:00 Tom Lane : >> 2. If compress/decompress are omitted, then we could support index-only >> scans all the time, that is a no-op fetch function would work. The >> patch should cover that int

Re: [HACKERS] Allow GiST opcalsses without compress\decompres functions

2017-05-28 Thread Tom Lane
Andrew Borodin writes: > I'm not expert in toasting, cube's compress does nothing while cube > decomress does detoasting. Is this for reason? The original input datum could be toasted --- at least to the extent of being compressed in-line or having short header; I do not think we allow out-of-lin

Re: [HACKERS] Index created in BEFORE trigger not updated during INSERT

2017-05-28 Thread Tom Lane
Andres Freund writes: > On 2017-05-24 08:26:24 -0400, Robert Haas wrote: >> I'm willing to bet that nobody ever thought about that case very hard. >> It seems like we should either make it work or prohibit it, but I >> can't actually see quite how to do either off-hand. > Hm, strategically sprink

[HACKERS] Inconsistent syntax for NumericOnly grammar production

2017-05-28 Thread Tom Lane
I noticed that gram.y has NumericOnly: FCONST { $$ = makeFloat($1); } | '-' FCONST { $$ = makeFloat($2); doNegateFloat($$); } | SignedIconst

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Mark Kirkwood
On 28/05/17 19:01, Mark Kirkwood wrote: So running in cloud land now...so for no errors - will update. The framework ran 600 tests last night, and I see 3 'NOK' results, i.e 3 failed test runs (all scale 25 and 8 pgbench clients). Given the way the test decides on failure (gets tired of

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Jeff Janes
On Sun, May 28, 2017 at 3:17 PM, Mark Kirkwood < mark.kirkw...@catalyst.net.nz> wrote: > On 28/05/17 19:01, Mark Kirkwood wrote: > > >> So running in cloud land now...so for no errors - will update. >> >> >> >> > The framework ran 600 tests last night, and I see 3 'NOK' results, i.e 3 > failed tes

Re: [HACKERS] Extra Vietnamese unaccent rules

2017-05-28 Thread Thomas Munro
On Sun, May 28, 2017 at 7:55 PM, Dang Minh Huong wrote: > [Quoting Thomas] >> You don't have to worry about decoding that line, it's all done in >> that Python script. The problem is just in the function >> is_letter_with_marks(). Instead of just checking if combining_ids[0] >> is a plain letter

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Erik Rijkers
On 2017-05-29 00:17, Mark Kirkwood wrote: On 28/05/17 19:01, Mark Kirkwood wrote: So running in cloud land now...so for no errors - will update. The framework ran 600 tests last night, and I see 3 'NOK' results, i.e 3 failed test runs (all scale 25 and 8 pgbench clients). Given the way Coul

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Erik Rijkers
On 2017-05-29 03:33, Jeff Janes wrote: On Sun, May 28, 2017 at 3:17 PM, Mark Kirkwood < mark.kirkw...@catalyst.net.nz> wrote: I also got a failure, after 87 iterations of a similar test case. It [...] repeated the runs, but so far it hasn't failed again in over 800 iterations Could you give

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Mark Kirkwood
On 29/05/17 16:26, Erik Rijkers wrote: On 2017-05-29 00:17, Mark Kirkwood wrote: On 28/05/17 19:01, Mark Kirkwood wrote: So running in cloud land now...so for no errors - will update. The framework ran 600 tests last night, and I see 3 'NOK' results, i.e 3 failed test runs (all scale 25 and

[HACKERS] psql: Activate pager only for height, not width

2017-05-28 Thread Brendan Jurd
Hello hackers, I am often frustrated by the default behaviour of the psql pager, which will activate a pager if the output is deemed to be "too wide" for the terminal, regardless of the number of lines output, and of the pager_min_lines setting. This behaviour is sometimes desirable, but in my us

Re: [HACKERS] logical replication - still unstable after all these months

2017-05-28 Thread Mark Kirkwood
On 29/05/17 13:33, Jeff Janes wrote: On Sun, May 28, 2017 at 3:17 PM, Mark Kirkwood mailto:mark.kirkw...@catalyst.net.nz>> wrote: On 28/05/17 19:01, Mark Kirkwood wrote: So running in cloud land now...so for no errors - will update. The framework ran 600 tests last nigh

Re: [HACKERS] UPDATE of partition key

2017-05-28 Thread Amit Khandekar
On 24 May 2017 at 20:16, Amit Kapila wrote: > On Wed, May 24, 2017 at 8:14 PM, Amit Kapila wrote: >> Apart from above, there is one open issue [1] >> > > Forget to mention the link, doing it now. > > [1] - > https://www.postgresql.org/message-id/CAA4eK1KEZQ%2BCyXbBzfn1jFHoEfa_OemDLhLyy7xfD1QUZLo

Re: [HACKERS] Surjective functional indexes

2017-05-28 Thread Konstantin Knizhnik
On 05/27/2017 09:50 PM, Peter Eisentraut wrote: On 5/25/17 12:30, Konstantin Knizhnik wrote: Functions like (info->>'name') are named "surjective" ni mathematics. A surjective function is one where each value in the output type can be obtained by some input value. That's not what you are after

Re: [HACKERS] Adding support for Default partition in partitioning

2017-05-28 Thread Beena Emerson
On Thu, May 25, 2017 at 3:03 PM, Jeevan Ladhe wrote: > > Forgot to attach the patch. > PFA. > > On Thu, May 25, 2017 at 3:02 PM, Jeevan Ladhe > wrote: >> >> Hi Rajkumar, >> >>> postgres=# CREATE TEMP TABLE temp_list_part (a int) PARTITION BY LIST (a); >>> CREATE TABLE >>> postgres=# CREATE TEMP