Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Tom Lane
=?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= writes: > And that seems to have done the trick. I started a manual run of HEAD > on curculio and now it's green on the build farm. > Thanks! Thank *you*, for putting up a buildfarm member that caught this bug.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Mikael Kjellström
On 2016-04-28 00:15, Tom Lane wrote: Thomas Munro writes: Also happens on OpenBSD 5.8. Isn't this a classic case where memmove is called for? Replacing the memcpy at line 617 with memmove makes the tests run successfully, but at first glance the other two

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Tom Lane
Thomas Munro writes: >> Also happens on OpenBSD 5.8. Isn't this a classic case where memmove >> is called for? Replacing the memcpy at line 617 with memmove makes >> the tests run successfully, but at first glance the other two >> instances of memcpy in

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Thomas Munro
On Thu, Apr 28, 2016 at 8:46 AM, Thomas Munro wrote: > On Thu, Apr 28, 2016 at 7:02 AM, Alvaro Herrera > wrote: >> Robert Haas wrote: >> >>> That looks like malloc() returned NULL. I noticed when writing that >>> patch that

Re: [HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Thomas Munro
On Thu, Apr 28, 2016 at 7:02 AM, Alvaro Herrera wrote: > Robert Haas wrote: > >> That looks like malloc() returned NULL. I noticed when writing that >> patch that isolationtester has never had any checks for malloc >> returning NULL, which is bad, and probably worth

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Alvaro Herrera
Robert Haas wrote: > That looks like malloc() returned NULL. I noticed when writing that > patch that isolationtester has never had any checks for malloc > returning NULL, which is bad, and probably worth fixing, but I didn't > choose to stop and fix it at that time. I didn't actually check

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Robert Haas
On Wed, Apr 27, 2016 at 1:51 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> Modify the isolation tester so that multiple sessions can wait. > > Mikael was kind enough to set up an OpenBSD 5.9 buildfarm member, and > it's been failing in isolationtester. (I kindly

[HACKERS] Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

2016-04-27 Thread Alvaro Herrera
Robert Haas wrote: > Modify the isolation tester so that multiple sessions can wait. Mikael was kind enough to set up an OpenBSD 5.9 buildfarm member, and it's been failing in isolationtester. (I kindly accepted my suggestion to put it to run even though it is failing so that we could look at