Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread David Steele
On 12/23/16 7:26 PM, Tom Lane wrote: > David Steele writes: >> What about a ./configure option that basically removes the min/max >> limits of every setting where it makes sense? > > It's pretty much never the case that anything goes; for example, > are we going to insist

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread Tom Lane
David Steele writes: > What about a ./configure option that basically removes the min/max > limits of every setting where it makes sense? It's pretty much never the case that anything goes; for example, are we going to insist that the code be able to respond sanely to

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread David Steele
On 12/23/16 6:12 PM, Michael Paquier wrote: > On Sat, Dec 24, 2016 at 6:02 AM, David Steele wrote: >> On 12/23/16 10:24 AM, Tom Lane wrote: >>> Andres Freund writes: While it's not a particularly good idea to set it to 1s on a production system,

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread Michael Paquier
On Sat, Dec 24, 2016 at 6:02 AM, David Steele wrote: > On 12/23/16 10:24 AM, Tom Lane wrote: >> Andres Freund writes: >>> While it's not a particularly good idea to set it to 1s on a production >>> system, I don't see why we need to prevent that. It's not

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread David Steele
On 12/23/16 10:24 AM, Tom Lane wrote: > Andres Freund writes: >> While it's not a particularly good idea to set it to 1s on a production >> system, I don't see why we need to prevent that. It's not like 30s is >> likely to be a good idea either. > >> Hence I'd like to set the

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread Tom Lane
Andres Freund writes: > While it's not a particularly good idea to set it to 1s on a production > system, I don't see why we need to prevent that. It's not like 30s is > likely to be a good idea either. > Hence I'd like to set the lower limit to 1s. OK, but the documentation

Re: [HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread Fabien COELHO
Hello Andres, for testing - like yesterday's 6ef2eba3f - it's annoying that checkpoint_timeout has 30s minimum. I've now locally patched that to be 1s a significant number of times. While it's not a particularly good idea to set it to 1s on a production system, I don't see why we need to

[HACKERS] Remove lower limit on checkpoint_timeout?

2016-12-23 Thread Andres Freund
Hi, for testing - like yesterday's 6ef2eba3f - it's annoying that checkpoint_timeout has 30s minimum. I've now locally patched that to be 1s a significant number of times. While it's not a particularly good idea to set it to 1s on a production system, I don't see why we need to prevent that.