Re: [HACKERS] Style of file error messages

2007-05-30 Thread Joshua D. Drake
Gregory Stark wrote: "Tom Lane" <[EMAIL PROTECTED]> writes: A seasoned developer might only need the file name to guess what kind of file it is, but other people could probably use the help. I think Peter's argument is that what kind of file it is really doesn't help a regular user. Nonethele

Re: [HACKERS] Style of file error messages

2007-05-30 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > A seasoned developer might only need the file name to guess what kind of > file it is, but other people could probably use the help. I think Peter's argument is that what kind of file it is really doesn't help a regular user. Nonetheless I agree strongly.

Re: [HACKERS] Style of file error messages

2007-05-30 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Just to get an opinion, which is better: > could not open whatever file "%s": %m > or just: > could not open file "%s": %m > It seems to me that by the time you get to a file error message of this > level, the higher-level purpose of the file is pret

Re: [HACKERS] Style of file error messages

2007-05-30 Thread Joshua D. Drake
Peter Eisentraut wrote: Just to get an opinion, which is better: could not open transaction log file "%s": %m could not open control file "%s": %m could not open data file "%s": %m could not open temporary file "%s": %m could not open whatever file "%s": %m or just: could not open file "%s": %

[HACKERS] Style of file error messages

2007-05-30 Thread Peter Eisentraut
Just to get an opinion, which is better: could not open transaction log file "%s": %m could not open control file "%s": %m could not open data file "%s": %m could not open temporary file "%s": %m could not open whatever file "%s": %m or just: could not open file "%s": %m It seems to me that by