Re: [HACKERS] pg_dump does not refresh matviews from extensions

2017-02-26 Thread Robert Haas
On Thu, Feb 23, 2017 at 5:11 AM, Jim Nasby wrote: > Now that I know that, I guess I'm kinda on the fence about doing it > automatically, because AFAIK there'd be no way to override that automatic > behavior. I can't really conceive of any reason you wouldn't want the >

Re: [HACKERS] pg_dump does not refresh matviews from extensions

2017-02-22 Thread Jim Nasby
On 2/21/17 2:05 PM, Stephen Frost wrote: As for $SUBJECT, I feel like it really depends, doesn't it? If the extension creates the matview w/ no data in it, and doesn't mark it as a config table, should we really refresh it? On the other hand, if the extension creates the matview and either

Re: [HACKERS] pg_dump does not refresh matviews from extensions

2017-02-21 Thread Stephen Frost
Jim, * Jim Nasby (jim.na...@bluetreble.com) wrote: > I think $SUBJECT is a bug. While it would be unusual for an > extension to have a matview, it's still allowed, and as it stands > right now that view won't be refreshed at the end of a restore, > unlike other matviews. > > I started looking

[HACKERS] pg_dump does not refresh matviews from extensions

2017-02-21 Thread Jim Nasby
I think $SUBJECT is a bug. While it would be unusual for an extension to have a matview, it's still allowed, and as it stands right now that view won't be refreshed at the end of a restore, unlike other matviews. I started looking into a patch for this, but I'm not sure of the best way to