Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE
On Tue, Jan 14, 2014 at 2:39 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut pete...@gmx.net wrote: On 12/17/13, 8:16 PM, Maciek Sakrejda wrote: (now with patch--sorry about that) This patch doesn't apply. There are some recent changes around same place which broke this patch. Please find the modified patch attached with this mail, I had changed order of specifying vacuum_freeze_min_age and vacuum_freeze_table_age in Vacuum FREEZE option. I will mark this patch as Ready For Committer, unless there is any other objection for this patch. Committed with a grammatical correction. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE
On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut pete...@gmx.net wrote: On 12/17/13, 8:16 PM, Maciek Sakrejda wrote: (now with patch--sorry about that) This patch doesn't apply. There are some recent changes around same place which broke this patch. Please find the modified patch attached with this mail, I had changed order of specifying vacuum_freeze_min_age and vacuum_freeze_table_age in Vacuum FREEZE option. I will mark this patch as Ready For Committer, unless there is any other objection for this patch. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com correct-vacuum-freeze-docs_v2.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote: (now with patch--sorry about that) This patch doesn't apply. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE
On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda m.sakre...@gmail.com wrote: VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected. (now with patch--sorry about that) Your explanation and patch seems fine to me. Kindly submit your patch in Open CommitFest (https://commitfest.postgresql.org/action/commitfest_view?id=21). With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] [PATCH] Doc fix for VACUUM FREEZE
(now with patch--sorry about that) diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml index eb71581..5f03343 100644 --- a/doc/src/sgml/ref/vacuum.sgml +++ b/doc/src/sgml/ref/vacuum.sgml @@ -100,8 +100,9 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] ANALYZE [ replaceable class=PARAMETER para Selects aggressive quotefreezing/quote of tuples. Specifying literalFREEZE/literal is equivalent to performing - commandVACUUM/command with the - xref linkend=guc-vacuum-freeze-min-age parameter + commandVACUUM/command with both + xref linkend=guc-vacuum-freeze-table-age and + xref linkend=guc-vacuum-freeze-min-age set to zero. /para /listitem -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
