Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-03-04 Thread Masahiko Sawada
On Sat, Mar 4, 2017 at 1:46 PM, Peter Eisentraut wrote: > On 3/3/17 13:58, Petr Jelinek wrote: >> On 23/02/17 08:24, Masahiko Sawada wrote: >>> Attached updated version patches. Please review these. >>> >> >> This version looks good to me, I'd only change the >> >>> +PreventTransaction

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-03-03 Thread Peter Eisentraut
On 3/3/17 13:58, Petr Jelinek wrote: > On 23/02/17 08:24, Masahiko Sawada wrote: >> Attached updated version patches. Please review these. >> > > This version looks good to me, I'd only change the > >> +PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION CREATE >> SLOT"); > > t

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-03-03 Thread Petr Jelinek
On 23/02/17 08:24, Masahiko Sawada wrote: > Attached updated version patches. Please review these. > This version looks good to me, I'd only change the > + PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION CREATE > SLOT"); to "CREATE SUBSCRIPTION ... CREATE SLOT" as that's a

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-22 Thread Masahiko Sawada
On Wed, Feb 22, 2017 at 2:17 AM, Masahiko Sawada wrote: > On Wed, Feb 22, 2017 at 1:52 AM, Fujii Masao wrote: >> On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada >> wrote: >>> On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada wrot

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Masahiko Sawada
On Wed, Feb 22, 2017 at 1:52 AM, Fujii Masao wrote: > On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada > wrote: >> On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: >>> On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada >>> wrote: On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek wrot

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Fujii Masao
On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada wrote: > On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: >> On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada >> wrote: >>> On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek >>> wrote: On 15/02/17 06:43, Masahiko Sawada wrote: > On Tue,

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-21 Thread Masahiko Sawada
On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao wrote: > On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada > wrote: >> On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek >> wrote: >>> On 15/02/17 06:43, Masahiko Sawada wrote: On Tue, Feb 14, 2017 at 1:13 AM, Fujii Masao wrote: > On Mon, Feb 1

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-20 Thread Fujii Masao
On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada wrote: > On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek > wrote: >> On 15/02/17 06:43, Masahiko Sawada wrote: >>> On Tue, Feb 14, 2017 at 1:13 AM, Fujii Masao wrote: On Mon, Feb 13, 2017 at 4:05 PM, Masahiko Sawada wrote: > On Sat,

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-15 Thread Masahiko Sawada
On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek wrote: > On 15/02/17 06:43, Masahiko Sawada wrote: >> On Tue, Feb 14, 2017 at 1:13 AM, Fujii Masao wrote: >>> On Mon, Feb 13, 2017 at 4:05 PM, Masahiko Sawada >>> wrote: On Sat, Feb 11, 2017 at 8:18 PM, Petr Jelinek wrote: > On 10/02/

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-15 Thread Petr Jelinek
On 15/02/17 06:43, Masahiko Sawada wrote: > On Tue, Feb 14, 2017 at 1:13 AM, Fujii Masao wrote: >> On Mon, Feb 13, 2017 at 4:05 PM, Masahiko Sawada >> wrote: >>> On Sat, Feb 11, 2017 at 8:18 PM, Petr Jelinek >>> wrote: On 10/02/17 19:55, Masahiko Sawada wrote: > On Thu, Feb 9, 2017 at

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-14 Thread Masahiko Sawada
On Tue, Feb 14, 2017 at 1:13 AM, Fujii Masao wrote: > On Mon, Feb 13, 2017 at 4:05 PM, Masahiko Sawada > wrote: >> On Sat, Feb 11, 2017 at 8:18 PM, Petr Jelinek >> wrote: >>> On 10/02/17 19:55, Masahiko Sawada wrote: On Thu, Feb 9, 2017 at 12:44 AM, Petr Jelinek wrote: > On 08/02

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-13 Thread Fujii Masao
On Mon, Feb 13, 2017 at 4:05 PM, Masahiko Sawada wrote: > On Sat, Feb 11, 2017 at 8:18 PM, Petr Jelinek > wrote: >> On 10/02/17 19:55, Masahiko Sawada wrote: >>> On Thu, Feb 9, 2017 at 12:44 AM, Petr Jelinek >>> wrote: On 08/02/17 07:40, Masahiko Sawada wrote: > On Wed, Feb 8, 2017 at 9

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-12 Thread Masahiko Sawada
On Sat, Feb 11, 2017 at 8:18 PM, Petr Jelinek wrote: > On 10/02/17 19:55, Masahiko Sawada wrote: >> On Thu, Feb 9, 2017 at 12:44 AM, Petr Jelinek >> wrote: >>> On 08/02/17 07:40, Masahiko Sawada wrote: On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier wrote: > On Wed, Feb 8, 2017 at

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-11 Thread Petr Jelinek
On 10/02/17 19:55, Masahiko Sawada wrote: > On Thu, Feb 9, 2017 at 12:44 AM, Petr Jelinek > wrote: >> On 08/02/17 07:40, Masahiko Sawada wrote: >>> On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier >>> wrote: On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: > On Wed, Feb 8, 2017 at 12:2

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-10 Thread Masahiko Sawada
On Thu, Feb 9, 2017 at 12:44 AM, Petr Jelinek wrote: > On 08/02/17 07:40, Masahiko Sawada wrote: >> On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier >> wrote: >>> On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek wrote: > For example w

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-08 Thread Petr Jelinek
On 08/02/17 07:40, Masahiko Sawada wrote: > On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier > wrote: >> On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: >>> On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek >>> wrote: For example what happens if apply crashes during the DROP SUBSCRIPTION

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Masahiko Sawada
On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier wrote: > On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: >> On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek >> wrote: >>> For example what happens if apply crashes during the DROP >>> SUBSCRIPTION/COMMIT and is not started because the delete from

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Michael Paquier
On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: > On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek > wrote: >> For example what happens if apply crashes during the DROP >> SUBSCRIPTION/COMMIT and is not started because the delete from catalog >> is now visible so the subscription is no longer the

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Fujii Masao
On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek wrote: > On 07/02/17 13:10, Masahiko Sawada wrote: >> Hi all, >> >> While testing logical replciation I found that if the transaction >> issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops >> and the subscription can never be removed l

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Petr Jelinek
On 07/02/17 16:26, Petr Jelinek wrote: > On 07/02/17 13:10, Masahiko Sawada wrote: >> I think the logical replication should not stop and the corresponding >> replication slot and replication origin should not be removed until >> the transaction commits. >> >> The solution for this I came up with i

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Petr Jelinek
On 07/02/17 13:10, Masahiko Sawada wrote: > Hi all, > > While testing logical replciation I found that if the transaction > issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops > and the subscription can never be removed later. The document says > that the replication worker associ

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Fujii Masao
On Tue, Feb 7, 2017 at 9:10 PM, Masahiko Sawada wrote: > Hi all, > > While testing logical replciation I found that if the transaction > issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops > and the subscription can never be removed later. The document says > that the replication