Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-12-22 Thread Tom Lane 
Peter Eisentraut  writes:
> On 11/30/16 11:37 PM, Tom Lane wrote:
>> OK, I updated docbook-style-xsl to 1.79.1 from Fedora rawhide (building
>> and installing that was quite painless btw, didn't need a pile of build
>> dependencies like I'd feared it would take).  The extraneous commas are
>> gone, and the speed is better but still not really up to DSSSL speed:
>> 1m44s (vs 1m5s with old toolchain).  So there's some additional piece
>> that needs fixing, but that's certainly the worst of it.

> I've done a few more tweaks, and now it actually runs faster for me than
> the old build.

For me it's now 1m35s, which is better than the last round but not
quite up to the old speed.  It's tolerable though.  Thanks for hacking
on it.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-12-22 Thread Peter Eisentraut 
On 11/30/16 11:37 PM, Tom Lane wrote:
> Peter Eisentraut  writes:
>> OK, I got it.  The component of concern is the DocBook XSL stylesheets,
>> called docbook-style-xsl on RH-like systems (docbook-xsl on Debian).  If
>> it runs too slow, it's probably too old.
> 
> OK, I updated docbook-style-xsl to 1.79.1 from Fedora rawhide (building
> and installing that was quite painless btw, didn't need a pile of build
> dependencies like I'd feared it would take).  The extraneous commas are
> gone, and the speed is better but still not really up to DSSSL speed:
> 1m44s (vs 1m5s with old toolchain).  So there's some additional piece
> that needs fixing, but that's certainly the worst of it.

I've done a few more tweaks, and now it actually runs faster for me than
the old build.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-12-15 Thread Tom Lane 
Alexander Law  writes:
> Hello Alvaro,
> It's caused by the condition
> ...
> in the simple.xlink template 
> (docbook/stylesheet/docbook-xsl/xhtml/inline.xsl). (This test executed 
> for each xlink (~ 9 times)).
> Yes, it's inefficient but it doesn't affect build time (for me).
> You can try to apply the attached patch and measure the time with it.

For me, that reduces the "make html" time from 1m44s to 1m43s.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-12-01 Thread Alvaro Herrera 
Pavel Stehule wrote:

> It does much more intensive work with IO - I have feeling like there are
> intensive fsync.

You could prove that, by running "make html" under "strace -f -e
trace=fsync" etc.  I just tried that, and I don't see any fsync.  I
guess you could try other syscalls, or simply "-e trace=file".  Doing
the latter I noticed an absolutely stupid number of attempts to open
file
/usr/lib/libxslt-plugins/nwalsh_com_xslt_ext_com_nwalsh_saxon_UnwrapLinks.so
which deserves a WTF.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Pavel Stehule 
2016-12-01 5:37 GMT+01:00 Tom Lane :

> Peter Eisentraut  writes:
> > OK, I got it.  The component of concern is the DocBook XSL stylesheets,
> > called docbook-style-xsl on RH-like systems (docbook-xsl on Debian).  If
> > it runs too slow, it's probably too old.
>
> OK, I updated docbook-style-xsl to 1.79.1 from Fedora rawhide (building
> and installing that was quite painless btw, didn't need a pile of build
> dependencies like I'd feared it would take).  The extraneous commas are
> gone, and the speed is better but still not really up to DSSSL speed:
> 1m44s (vs 1m5s with old toolchain).  So there's some additional piece
> that needs fixing, but that's certainly the worst of it.
>

It does much more intensive work with IO - I have feeling like there are
intensive fsync.

Regards

Pavel

>
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Tom Lane 
Peter Eisentraut  writes:
> OK, I got it.  The component of concern is the DocBook XSL stylesheets,
> called docbook-style-xsl on RH-like systems (docbook-xsl on Debian).  If
> it runs too slow, it's probably too old.

OK, I updated docbook-style-xsl to 1.79.1 from Fedora rawhide (building
and installing that was quite painless btw, didn't need a pile of build
dependencies like I'd feared it would take).  The extraneous commas are
gone, and the speed is better but still not really up to DSSSL speed:
1m44s (vs 1m5s with old toolchain).  So there's some additional piece
that needs fixing, but that's certainly the worst of it.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Peter Eisentraut 
On 11/30/16 1:52 PM, Tom Lane wrote:
> However, speed may be the least of its problems.  I just noticed that it's
> inserting commas at random places in syntax summaries :-(.  For instance,
> the "overlay" entry in table 9.8 looks like
> 
> overlay(string, placing
> string, from int [for int])
> 
> Neither comma belongs there according to the SGML source, and I don't see
> them in guaibausaurus' rendering of the page:
> https://www.postgresql.org/docs/devel/static/functions-string.html
> 
> So I'm forced to the conclusion that I need a newer version of the
> toolchain and/or style sheets.  If you've got any idea of just what
> needs to be updated, that would be real helpful.  xsltproc itself
> is from "libxslt-1.1.26-2.el6_3.1.x86_64" but I'm unsure what packages
> contain relevant style sheets.

OK, I got it.  The component of concern is the DocBook XSL stylesheets,
called docbook-style-xsl on RH-like systems (docbook-xsl on Debian).  If
it runs too slow, it's probably too old.

Here you can see a list of available versions:
http://docbook.sourceforge.net/release/xsl/

I noticed a significant slow-down with versions older than 1.76.1.  And
indeed CentOS/RHEL 6 comes with 1.75.2.

Also, the issue with the extra commas mentioned above goes away with 1.78.0.

Here is the trick why this isn't reproducible for some:

The local stylesheet file stylesheet.xsl references
http://docbook.sourceforge.net/release/xsl/current/xhtml/chunk.xsl.  If
you have the docbook-style-xsl package installed, then this URL gets
redirected to your local installation through the XML catalog mechanism.
 If you don't have the package installed locally, then xsltproc will
download the stylesheet files from that actual URL and cache them
locally.  So if you have an old docbook-style-xsl version, you get old
and slow behavior.  If you uninstall it or just never installed it, you
get the latest from the internet.

If you don't want to mess with your local packages, you can also prevent
the use of the XML catalog by setting the environment variable
XML_CATALOG_FILES to empty (e.g., XML_CATALOG_FILES='' make html).

There is some work to be done here to document this and make sure we
wrap releases with appropriate versions and so on, but I hope this
information can keep everyone moving for now.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Tom Lane 
I wrote:
> Still sucks for me on an up-to-date RHEL6 box: about 1m5s to build oldhtml,
> about 4m50s to build html, both starting after "make maintainer-clean" in
> the doc/src/sgml/ subdirectory.

However, speed may be the least of its problems.  I just noticed that it's
inserting commas at random places in syntax summaries :-(.  For instance,
the "overlay" entry in table 9.8 looks like

overlay(string, placing
string, from int [for int])

Neither comma belongs there according to the SGML source, and I don't see
them in guaibausaurus' rendering of the page:
https://www.postgresql.org/docs/devel/static/functions-string.html

So I'm forced to the conclusion that I need a newer version of the
toolchain and/or style sheets.  If you've got any idea of just what
needs to be updated, that would be real helpful.  xsltproc itself
is from "libxslt-1.1.26-2.el6_3.1.x86_64" but I'm unsure what packages
contain relevant style sheets.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Tom Lane 
Peter Eisentraut  writes:
> On 11/16/16 3:59 PM, Peter Eisentraut wrote:
>> On my machine and on the build farm, the performance now almost matches
>> the DSSSL build.

Still sucks for me on an up-to-date RHEL6 box: about 1m5s to build oldhtml,
about 4m50s to build html, both starting after "make maintainer-clean" in
the doc/src/sgml/ subdirectory.

BTW, I notice the "make check-tabs" step isn't getting run with the new
target; is that intentional?

> Anyone who is still getting terrible performance (>2x slower) from the
> html build, please send me the output of
> xsltproc --profile --timing --stringparam pg.version '10devel'
> stylesheet.xsl postgres.xml 2>profile.txt
> so I can look into it.

It wasn't that big, so attached.

regards, tom lane

Parsing stylesheet stylesheet.xsl took 3 ms
Parsing document postgres.xml took 258 ms
number   matchname  mode  Calls Tot 100us Avg

0 gentext.template   740222 13445998 18
1l10n.language   604192 5579772  9
2 footnotefootnote.number
 36 2458970  68304
3  href.target31220 1170552 37
4 gentext.template.exists
 547516 651313  1
5 inherited.table.attribute
 124970 449412  3
6*html.title.attribute
 181126 421298  2
7  gentext13441 307385 22
8   chunk-all-sections 1332 299884225
9chunk   237364 299160  1
   10substitute-markup86180 200978  2
   11 simple.xlink91501 193179  2
   12   entry|entrytbl   entry22086 184189  8
   13   dbhtml-dir   276346 167630  0
   14   lookup.key   306424 160120  0
   15*recursive-chunk-filename
 102309 154378  1
   16 xrefno.anchor.mode
 70 131384   1876
   17 pi-attribute   382931 130482  0
   18   xpath.location   167791 123089  0
   19   anchor   171571 114268  0
   20*head.keywords.content
   5300 100556 18
   21sect1label.markup
  26594  97906  3
   22  chapterlabel.markup
  32343  88112  2
   23  dir   175593  86788  0
   24object.id   195572  85495  0
   25get-attribute   628313  84789  0
   26*title.markup
 168553  80976  0
   27 figure|table|examplelabel.markup
   1226  77663 63
   28   colnum.colspec   127081  76139  0
   29  write.chunk 1333  74765 56
   30 appendixlabel.markup
  26516  70527  2
   31 autolabel.format   101251  62680  0
   32pi.dbhtml_dir   276346  60904  0
   33 dbhtml-attribute   382900  58037  0
   34header.navigation 1332  57161 42
   35*common.html.attributes
 101057  56244  0
   36 html:p|p  unwrap.p  33426  55942  1
   37   label.this.section75320  55522  0
   38   inline.monoseq56958  54528  0
   39footer.navigation 1332  53082 39
   40*class.attribute

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-30 Thread Peter Eisentraut 
On 11/16/16 3:59 PM, Peter Eisentraut wrote:
>>> Build HTML documentation using XSLT stylesheets by default
>>>
>>> The old DSSSL build is still available for a while using the make 
>>> target
>>> "oldhtml".
>>
>> This xslt build  takes  8+ minutes, compared to barely 1 minute for 
>> 'oldhtml'.
> 
> I have committed another patch to improve the build performance a bit.
> Could you check again?
> 
> On my machine and on the build farm, the performance now almost matches
> the DSSSL build.

Anyone who is still getting terrible performance (>2x slower) from the
html build, please send me the output of

xsltproc --profile --timing --stringparam pg.version '10devel'
stylesheet.xsl postgres.xml 2>profile.txt

so I can look into it.

(It will be big, so feel free to paste it somewhere or send privately.)

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Erik Rijkers 

On 2016-11-17 02:15, Peter Eisentraut wrote:

On 11/16/16 1:14 PM, Erik Rijkers wrote:

real5m21.348s  -- for 'make -j 8 html'
versus
real1m8.502s   -- for 'make -j 8 oldhtml'

Centos 6.6 - I suppose it's getting a bit old, I don't know if that's
the cause of the discrepancy with other's measurements.


I tested the build on a variety of operating systems, including that
one, with different tool chain versions and I am getting consistent
performance.  So the above is unclear to me at the moment.

For the heck of it, run this

xsltproc --nonet --stringparam pg.version '10devel'  stylesheet.xsl
postgres.xml

to make sure it's not downloading something from the network.


$ time xsltproc --nonet --stringparam pg.version '10devel'  
stylesheet.xsl postgres.xml

real5m43.776s

$ ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml; time 
make oldhtml )

real1m14.152s

(I did clean out in between)





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 1:14 PM, Erik Rijkers wrote:
> real5m21.348s  -- for 'make -j 8 html'
> versus
> real1m8.502s   -- for 'make -j 8 oldhtml'
> 
> Centos 6.6 - I suppose it's getting a bit old, I don't know if that's 
> the cause of the discrepancy with other's measurements.

I tested the build on a variety of operating systems, including that
one, with different tool chain versions and I am getting consistent
performance.  So the above is unclear to me at the moment.

For the heck of it, run this

xsltproc --nonet --stringparam pg.version '10devel'  stylesheet.xsl
postgres.xml

to make sure it's not downloading something from the network.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 1:23 PM, Alvaro Herrera wrote:
> Now admittedly this conversion didn't do one bit towards the goal I
> wanted to achieve: that each doc source file ended up as a valid XML
> file that could be processed separately with tools like xml2po.  They
> are still SGML only -- in particular no doctype declaration and
> incomplete closing tags.

Yes, that is one of the upcoming steps.  But we need to do the current
thing first.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Tom Lane 
Erik Rijkers  writes:
> On 2016-11-16 21:59, Peter Eisentraut wrote:
>> I have committed another patch to improve the build performance a bit.
>> Could you check again?

> It is indeed better (three minutes off, nice) but still:
> real5m21.348s  -- for 'make -j 8 html'
> versus
> real1m8.502s   -- for 'make -j 8 oldhtml'

Yeah, I get about the same.

> Centos 6.6 - I suppose it's getting a bit old, I don't know if that's 
> the cause of the discrepancy with other's measurements.

... and on the same toolchain.  Probably the answer is "install a newer
toolchain", but from what I understand, there's a whole lot of work there
if your platform vendor doesn't supply it already packaged.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Alvaro Herrera 
Peter Eisentraut wrote:

> > This xslt build  takes  8+ minutes, compared to barely 1 minute for 
> > 'oldhtml'.
> 
> I have committed another patch to improve the build performance a bit.
> Could you check again?

After the optimization, on my laptop it takes 2:31 with the new system
and 1:58 with the old one.  If it can be made faster, all the better,
but at this level I'm okay.

Now admittedly this conversion didn't do one bit towards the goal I
wanted to achieve: that each doc source file ended up as a valid XML
file that could be processed separately with tools like xml2po.  They
are still SGML only -- in particular no doctype declaration and
incomplete closing tags.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Erik Rijkers 

On 2016-11-16 21:59, Peter Eisentraut wrote:

On 11/16/16 6:29 AM, Erik Rijkers wrote:


This xslt build  takes  8+ minutes, compared to barely 1 minute for
'oldhtml'.


I have committed another patch to improve the build performance a bit.
Could you check again?


It is indeed better (three minutes off, nice) but still:
real5m21.348s  -- for 'make -j 8 html'
versus
real1m8.502s   -- for 'make -j 8 oldhtml'

Centos 6.6 - I suppose it's getting a bit old, I don't know if that's 
the cause of the discrepancy with other's measurements.


Obviously as long as 'oldhtml' is possible I won't complain.

thanks,

Erik Rijkers







--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 6:46 AM, Tom Lane wrote:
> What was the improvement we were hoping for, again?

Get off an ancient and unmaintained tool chain.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 12:38 PM, Alvaro Herrera wrote:
> "make check" still uses DSSSL though.  Is that intentional?  Is it going
> to be changed?

It doesn't use DSSSL.  Is uses nsgmls to parse the SGML, which is a
different thing that will be addressed in a separate step.

So, yes, but later.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 6:09 AM, Magnus Hagander wrote:
> Btw., shouldn't the output web site pages have encoding declarations?
> 
> That gets sent in the http header, doesn't it? 

That's probably alright, but it would be nicer if the documents were
self-contained.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut 
On 11/16/16 6:29 AM, Erik Rijkers wrote:
> On 2016-11-16 08:06, Peter Eisentraut wrote:
>> Build HTML documentation using XSLT stylesheets by default
>>
>> The old DSSSL build is still available for a while using the make 
>> target
>> "oldhtml".
> 
> This xslt build  takes  8+ minutes, compared to barely 1 minute for 
> 'oldhtml'.

I have committed another patch to improve the build performance a bit.
Could you check again?

On my machine and on the build farm, the performance now almost matches
the DSSSL build.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Robert Haas 
On Wed, Nov 16, 2016 at 10:16 AM, Andrew Dunstan  wrote:
> On the buildfarm crake has gone from about 2 minutes to about 3.5 minutes to
> run "make doc". That's not good but it's not an eight-fold increase either.

On my MacBook, "time make docs" as of e36ddab11735052841b4eff96642187ec9a8a7bc:

real2m17.871s
user2m15.505s
sys0m2.238s

And as of 4ecd1974377ffb4d6d72874ba14fcd23965b1792:

real1m47.696s
user1m47.085s
sys0m1.145s

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Robert Haas 
On Wed, Nov 16, 2016 at 9:46 AM, Tom Lane  wrote:
> Erik Rijkers  writes:
>> This xslt build  takes  8+ minutes, compared to barely 1 minute for
>> 'oldhtml'.
>
> I'm just discovering the same.
>
>> I'd say that is a strong disadvantage.
>
> I'd say that is flat out unacceptable.  I won't ever use this toolchain
> if it's that much slower than the old way.  What was the improvement
> we were hoping for, again?

Gosh, and I thought the existing toolchain was already ridiculously
slow.  Couldn't somebody write a Perl script that generated the HTML
documentation from the SGML in, like, a second?  I mean, we're
basically just mapping one set up markup tags to another set of markup
tags.  And splitting up some files for the HTML version.  And adding
some boilerplate.  But none of that sounds like it should be all that
hard.

I am reminded of the saying that XML is like violence -- if it doesn't
solve your problem, you're not using enough of it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Andrew Dunstan 



On 11/16/2016 09:46 AM, Tom Lane wrote:

Erik Rijkers  writes:

This xslt build  takes  8+ minutes, compared to barely 1 minute for
'oldhtml'.

I'm just discovering the same.


I'd say that is a strong disadvantage.

I'd say that is flat out unacceptable.  I won't ever use this toolchain
if it's that much slower than the old way.  What was the improvement
we were hoping for, again?






On the buildfarm crake has gone from about 2 minutes to about 3.5 
minutes to run "make doc". That's not good but it's not an eight-fold 
increase either.


cheers

andrew



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Tom Lane 
Erik Rijkers  writes:
> This xslt build  takes  8+ minutes, compared to barely 1 minute for 
> 'oldhtml'.

I'm just discovering the same.

> I'd say that is a strong disadvantage.

I'd say that is flat out unacceptable.  I won't ever use this toolchain
if it's that much slower than the old way.  What was the improvement
we were hoping for, again?

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers