Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-03-01 Thread Peter Eisentraut
On 1/12/17 09:36, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/11/17 11:25 PM, Tom Lane wrote: >>> +1 for the concept, but I'm a bit worried about putting atooid() in >>> postgres_ext.h. That's going to impose on the namespace of libpq-using >>> applications, for instance. A more conservat

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Michael Paquier
On Thu, Jan 12, 2017 at 11:36 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/11/17 11:25 PM, Tom Lane wrote: >>> +1 for the concept, but I'm a bit worried about putting atooid() in >>> postgres_ext.h. That's going to impose on the namespace of libpq-using >>> applications, for instance.

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Tom Lane
Peter Eisentraut writes: > On 1/11/17 11:25 PM, Tom Lane wrote: >> +1 for the concept, but I'm a bit worried about putting atooid() in >> postgres_ext.h. That's going to impose on the namespace of libpq-using >> applications, for instance. A more conservative answer would be to >> add it to c.h.

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Peter Eisentraut
On 1/12/17 12:25 AM, Kuntal Ghosh wrote: > On Wed, Jan 11, 2017 at 9:42 PM, Peter Eisentraut > wrote: >> There are approximately 11 copies of atooid() and 3 of oid_cmp() or >> equivalent, and pending patches are proposing to add more. I propose >> these two patches to collect them in central plac

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Peter Eisentraut
On 1/11/17 11:25 PM, Tom Lane wrote: > Peter Eisentraut writes: >> There are approximately 11 copies of atooid() and 3 of oid_cmp() or >> equivalent, and pending patches are proposing to add more. I propose >> these two patches to collect them in central places. > > +1 for the concept, but I'm a

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-11 Thread Kuntal Ghosh
On Wed, Jan 11, 2017 at 9:42 PM, Peter Eisentraut wrote: > There are approximately 11 copies of atooid() and 3 of oid_cmp() or > equivalent, and pending patches are proposing to add more. I propose > these two patches to collect them in central places. > I've verified that the patch covers all th

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-11 Thread Tom Lane
Peter Eisentraut writes: > There are approximately 11 copies of atooid() and 3 of oid_cmp() or > equivalent, and pending patches are proposing to add more. I propose > these two patches to collect them in central places. +1 for the concept, but I'm a bit worried about putting atooid() in postgre