Re: [HACKERS] myProcLocks initialization

2011-10-31 Thread Simon Riggs
On Mon, Oct 31, 2011 at 7:54 PM, Robert Haas wrote: > Revised patch attached.  I think it would be useful to assert this > both at process startup time and at process shutdown, since it would > really be much nicer to have the process that didn't clean up fail the > assertion, rather than the new

Re: [HACKERS] myProcLocks initialization

2011-10-31 Thread Tom Lane
Simon Riggs writes: > On Mon, Oct 31, 2011 at 7:54 PM, Robert Haas wrote: >> Revised patch attached.  I think it would be useful to assert this >> both at process startup time and at process shutdown, since it would >> really be much nicer to have the process that didn't clean up fail the >> asse

Re: [HACKERS] myProcLocks initialization

2011-10-31 Thread Tom Lane
Robert Haas writes: > Revised patch attached. I think it would be useful to assert this > both at process startup time and at process shutdown, since it would > really be much nicer to have the process that didn't clean up fail the > assertion, rather than the new one that innocently inherited it

Re: [HACKERS] myProcLocks initialization

2011-10-31 Thread Robert Haas
On Sun, Oct 30, 2011 at 11:26 PM, Robert Haas wrote: > On Sun, Oct 30, 2011 at 11:13 PM, Tom Lane wrote: >> Robert Haas writes: >>> I'd like to propose the attached patch, which initializes each >>> PGPROC's myProcLocks just once at postmaster startup, rather than >>> every time the PGPROC is ha

Re: [HACKERS] myProcLocks initialization

2011-10-30 Thread Robert Haas
On Sun, Oct 30, 2011 at 11:13 PM, Tom Lane wrote: > Robert Haas writes: >> I'd like to propose the attached patch, which initializes each >> PGPROC's myProcLocks just once at postmaster startup, rather than >> every time the PGPROC is handed out to a backend.  These lists should >> always be empt

Re: [HACKERS] myProcLocks initialization

2011-10-30 Thread Tom Lane
Robert Haas writes: > I'd like to propose the attached patch, which initializes each > PGPROC's myProcLocks just once at postmaster startup, rather than > every time the PGPROC is handed out to a backend. These lists should > always be emptied before a backend shuts down, so a newly initialized >