Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi wrote: >> Updated patch attached. > Patch rebased. I think the earlier concerns about the performance impact of this are probably very valid concerns, and I don't see how the new version of the patch gets us much closer to solving them. I am also no

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Sep 27, 2017 at 6:58 PM, Haribabu Kommi wrote: > > Updated patch attached. > Patch rebased. Regards, Hari Babu Fujitsu Australia pg_stat_walwrites-statistics-view_v10.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] pg_stat_wal_write statistics view

On Fri, Sep 22, 2017 at 5:46 PM, Julien Rouhaud wrote: > Hello, > > On Wed, Sep 13, 2017 at 3:01 AM, Haribabu Kommi > wrote: > > I ran the latest performance tests with and without IO times, there is an > > overhead involved with IO time calculation and didn't observe any > > performance > > ove

Re: [HACKERS] pg_stat_wal_write statistics view

Hello, On Wed, Sep 13, 2017 at 3:01 AM, Haribabu Kommi wrote: > I ran the latest performance tests with and without IO times, there is an > overhead involved with IO time calculation and didn't observe any > performance > overhead with normal stats. May be we can enable the IO stats only in the >

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Sep 12, 2017 at 3:14 PM, Kuntal Ghosh wrote: > On Tue, Sep 12, 2017 at 9:06 AM, Haribabu Kommi > wrote: > > > > > > On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh < > kuntalghosh.2...@gmail.com> > > wrote: > > > Thanks for the patch. > + * Check whether the current process is a normal bac

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Sep 12, 2017 at 9:06 AM, Haribabu Kommi wrote: > > > On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh > wrote: >> >> On Wed, Sep 6, 2017 at 9:16 AM, Haribabu Kommi >> wrote: >> > >> > Attached the latest patch and performance report. >> > >> While looking into the patch, I realized that a n

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Sep 12, 2017 at 2:04 AM, Kuntal Ghosh wrote: > On Wed, Sep 6, 2017 at 9:16 AM, Haribabu Kommi > wrote: > > > > Attached the latest patch and performance report. > > > While looking into the patch, I realized that a normal backend has to > check almost 10 if conditions at worst case insid

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Sep 6, 2017 at 9:16 AM, Haribabu Kommi wrote: > > Attached the latest patch and performance report. > While looking into the patch, I realized that a normal backend has to check almost 10 if conditions at worst case inside XLogWrite(6 in am_background_process method, 1 for write, 1 for blo

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Aug 15, 2017 at 7:39 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 3/29/17 22:10, Haribabu Kommi wrote: > > Updated patch to use shared counter instead of adding pg_stat_ calls to > send > > the statistics from each background process/worker. > > Your patch needs to

Re: [HACKERS] pg_stat_wal_write statistics view

On 3/29/17 22:10, Haribabu Kommi wrote: > Updated patch to use shared counter instead of adding pg_stat_ calls to send > the statistics from each background process/worker. Your patch needs to be rebased and the OID assignments updated. -- Peter Eisentraut http://www.2ndQuadrant.com

Re: [HACKERS] pg_stat_wal_write statistics view

On Thu, Apr 6, 2017 at 5:51 AM, Andres Freund wrote: > Hi, > > On 2017-03-30 13:10:41 +1100, Haribabu Kommi wrote: >> diff --git a/src/backend/access/transam/xlog.c >> b/src/backend/access/transam/xlog.c >> index 5d58f09..a29c108 100644 >> --- a/src/backend/access/transam/xlog.c >> +++ b/src/back

Re: [HACKERS] pg_stat_wal_write statistics view

Hi, On 2017-03-30 13:10:41 +1100, Haribabu Kommi wrote: > diff --git a/src/backend/access/transam/xlog.c > b/src/backend/access/transam/xlog.c > index 5d58f09..a29c108 100644 > --- a/src/backend/access/transam/xlog.c > +++ b/src/backend/access/transam/xlog.c > @@ -600,6 +600,9 @@ typedef struct X

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Mar 29, 2017 at 5:10 AM, Fujii Masao wrote: > On Tue, Mar 28, 2017 at 1:40 PM, Haribabu Kommi > wrote: > > > > > > Added stats collection for walsender, statrup and autovacuum processes. > > The background workers that call pgstat_report_stat() function will > > automatically > > include

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Mar 28, 2017 at 1:40 PM, Haribabu Kommi wrote: > > > On Mon, Mar 27, 2017 at 1:27 PM, Haribabu Kommi > wrote: >> >> >> >> On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao >> wrote: >>> >>> On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi >>> wrote: >>> > >>> > >>> > On Wed, Feb 8, 2017 at 9

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Mar 28, 2017 at 3:40 PM, Haribabu Kommi wrote: > > update patch attached. > Forgot to execute git commit, new patch attached. Regards, Hari Babu Fujitsu Australia pg_stat_walwrites_view_4.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

Re: [HACKERS] pg_stat_wal_write statistics view

On Mon, Mar 27, 2017 at 1:27 PM, Haribabu Kommi wrote: > > > On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao > wrote: > >> On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi >> wrote: >> > >> > >> > On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila >> wrote: >> >> >> >> On Tue, Feb 7, 2017 at 11:47 AM, H

Re: [HACKERS] pg_stat_wal_write statistics view

On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao wrote: > On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi > wrote: > > > > > > On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila > wrote: > >> > >> On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi > >> wrote: > >> > Hi Hackers, > >> > > >> > I just want to

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Feb 15, 2017 at 12:53 PM, Haribabu Kommi wrote: > > > On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila wrote: >> >> On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi >> wrote: >> > Hi Hackers, >> > >> > I just want to discuss adding of a new statistics view that provides >> > the information of

Re: [HACKERS] pg_stat_wal_write statistics view

On 3/16/17 1:54 AM, vinayak wrote: On 2017/03/16 14:46, Haribabu Kommi wrote: As the view name already contains WAL, I am not sure whether is it required to include WAL in every column? I am fine to change if others have the same opinion of adding WAL to column names. Ok. So what is the st

Re: [HACKERS] pg_stat_wal_write statistics view

On 2017/03/16 14:46, Haribabu Kommi wrote: On Thu, Mar 16, 2017 at 4:15 PM, vinayak > wrote: On 2017/03/16 10:34, Haribabu Kommi wrote: Updated patch attached. The patch looks good to me. Thanks for the review. How about rename th

Re: [HACKERS] pg_stat_wal_write statistics view

On Thu, Mar 16, 2017 at 4:15 PM, vinayak wrote: > > On 2017/03/16 10:34, Haribabu Kommi wrote: > > > Updated patch attached. > > The patch looks good to me. > Thanks for the review. How about rename the view as "pg_stat_walwriter"? > With the use of name "walwriter" instead of "walwrites", the

Re: [HACKERS] pg_stat_wal_write statistics view

On 2017/03/16 10:34, Haribabu Kommi wrote: Updated patch attached. The patch looks good to me. How about rename the view as "pg_stat_walwriter"? The columns of view : backend_writes -> backend_wal_writes writes-> background_wal_writes write_blocks-> wal_write_blocks write_time->wal_write_time

Re: [HACKERS] pg_stat_wal_write statistics view

On Thu, Mar 16, 2017 at 9:55 AM, Julien Rouhaud wrote: > On Wed, Feb 15, 2017 at 02:53:44PM +1100, Haribabu Kommi wrote: > > Here I attached patch that implements the view. > > I will add this patch to next commitfest. > > Hello, > > I just reviewed the patch. > Thanks for the review. First, th

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Feb 15, 2017 at 02:53:44PM +1100, Haribabu Kommi wrote: > Here I attached patch that implements the view. > I will add this patch to next commitfest. Hello, I just reviewed the patch. First, there are some whitespace issues that make git-apply complaining (at least lines 218 and 396). P

Re: [HACKERS] pg_stat_wal_write statistics view

On Wed, Feb 8, 2017 at 9:36 PM, Amit Kapila wrote: > On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi > wrote: > > Hi Hackers, > > > > I just want to discuss adding of a new statistics view that provides > > the information of wal writing details as follows > > > > +1. I think it will be useful

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi wrote: > Hi Hackers, > > I just want to discuss adding of a new statistics view that provides > the information of wal writing details as follows > +1. I think it will be useful to observe WAL activity. > postgres=# \d pg_stat_wal_writer >