Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-12 Thread Robert Haas
2010/3/11 KaiGai Kohei kai...@ak.jp.nec.com: (2010/03/11 23:55), Robert Haas wrote: 2010/3/10 KaiGai Koheikai...@ak.jp.nec.com: Indeed, it is useful to allow renaming attribute of composite types. However, it is also useless to allow to rename attribute of sequences, but harmless, like

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-11 Thread Robert Haas
2010/3/10 KaiGai Kohei kai...@ak.jp.nec.com: Indeed, it is useful to allow renaming attribute of composite types. However, it is also useless to allow to rename attribute of sequences, but harmless, like renames on indexes. It seems to me it is fair enough to allow renaming attributes of

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-11 Thread KaiGai Kohei
(2010/03/11 23:55), Robert Haas wrote: 2010/3/10 KaiGai Koheikai...@ak.jp.nec.com: Indeed, it is useful to allow renaming attribute of composite types. However, it is also useless to allow to rename attribute of sequences, but harmless, like renames on indexes. It seems to me it is fair

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-10 Thread Robert Haas
On Wed, Mar 3, 2010 at 7:16 PM, Robert Haas robertmh...@gmail.com wrote: 2010/3/3 KaiGai Kohei kai...@ak.jp.nec.com: (2010/03/03 22:42), Robert Haas wrote: 2010/3/3 KaiGai Koheikai...@ak.jp.nec.com: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-10 Thread KaiGai Kohei
(2010/03/11 0:54), Robert Haas wrote: On Wed, Mar 3, 2010 at 7:16 PM, Robert Haasrobertmh...@gmail.com wrote: 2010/3/3 KaiGai Koheikai...@ak.jp.nec.com: (2010/03/03 22:42), Robert Haas wrote: 2010/3/3 KaiGai Koheikai...@ak.jp.nec.com: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-03 Thread Boszormenyi Zoltan
Hi, KaiGai Kohei írta: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an expected behavior? postgres= CREATE SEQUENCE s; CREATE SEQUENCE postgres= ALTER TABLE s RENAME sequence_name TO abcd; ALTER TABLE postgres= CREATE

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-03 Thread Robert Haas
2010/3/3 KaiGai Kohei kai...@ak.jp.nec.com: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an expected behavior?   postgres=  CREATE SEQUENCE s;   CREATE SEQUENCE   postgres=  ALTER TABLE s RENAME sequence_name TO abcd;   ALTER TABLE   postgres=  

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-03 Thread KaiGai Kohei
(2010/03/03 22:42), Robert Haas wrote: 2010/3/3 KaiGai Koheikai...@ak.jp.nec.com: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an expected behavior? postgres=CREATE SEQUENCE s; CREATE SEQUENCE postgres=ALTER TABLE s RENAME

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-03 Thread Robert Haas
2010/3/3 KaiGai Kohei kai...@ak.jp.nec.com: (2010/03/03 22:42), Robert Haas wrote: 2010/3/3 KaiGai Koheikai...@ak.jp.nec.com: (2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an expected behavior?    postgres=    CREATE SEQUENCE s;    CREATE SEQUENCE

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-02 Thread Tom Lane
KaiGai Kohei kai...@ak.jp.nec.com writes: Is it an expected behavior? There's no particular reason to forbid it, is there? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-02 Thread KaiGai Kohei
(2010/03/03 11:22), Tom Lane wrote: KaiGai Koheikai...@ak.jp.nec.com writes: Is it an expected behavior? There's no particular reason to forbid it, is there? Perhaps, it is harmless. It just seemed to me the renameatt() was not implemented correctly according to the documentation. --

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-02 Thread Robert Haas
2010/3/2 KaiGai Kohei kai...@ak.jp.nec.com: Is it an expected behavior?  postgres= CREATE SEQUENCE s;  CREATE SEQUENCE  postgres= ALTER TABLE s RENAME sequence_name TO abcd;  ALTER TABLE  postgres= CREATE TABLE t (a int primary key, b text);  NOTICE:  CREATE TABLE / PRIMARY KEY will

Re: [HACKERS] renameatt() can rename attribute of index, sequence, ...

2010-03-02 Thread KaiGai Kohei
(2010/03/03 14:26), Robert Haas wrote: 2010/3/2 KaiGai Koheikai...@ak.jp.nec.com: Is it an expected behavior? postgres= CREATE SEQUENCE s; CREATE SEQUENCE postgres= ALTER TABLE s RENAME sequence_name TO abcd; ALTER TABLE postgres= CREATE TABLE t (a int primary key, b text);