Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Fri, Apr 14, 2017 at 9:36 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/14/17 14:45, Magnus Hagander wrote: > > Attached is a patch that can be applied to pgweb which should fix > all of > > this. > > > > > > > > Applied, thanks. > > Oops, one too many. > >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/14/17 14:45, Magnus Hagander wrote: > Attached is a patch that can be applied to pgweb which should fix all of > this. > > > > Applied, thanks. Oops, one too many. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 3:52 AM, Bruce Momjian wrote: > On Fri, Mar 24, 2017 at 07:01:46AM +0100, Fabien COELHO wrote: > > > > Hello Peter, > > > > >I think the fix belongs into the web site CSS, so there is nothing to > > >commit into PostgreSQL here. > > > > Indeed, the

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/7/17 21:52, Bruce Momjian wrote: > The fix, as Fabien identified, is to conditionally inject additional CSS > to be _more_ specific than the first CSS and set the font-size to a > simple '1em' so the first CSS is not called twice. I don't think > 'important!' is necessary but it would be

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/12/17 09:50, Bruce Momjian wrote: > On Wed, Apr 12, 2017 at 01:31:51PM +0200, Magnus Hagander wrote: >> I think that only leaves the change to the javascript code that Bruce sent. >> Let's see if we can figure out a way to do that one without requiring >> javascript, but after that we have

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/12/17 15:43, Peter Eisentraut wrote: > On 4/12/17 07:31, Magnus Hagander wrote: >> Once difference I notice is that for example the "note boxes" are no >> longer centered, but they do now get the new formatting. > > I have committed something for that. The issue was that the generated >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/12/17 07:31, Magnus Hagander wrote: > Once difference I notice is that for example the "note boxes" are no > longer centered, but they do now get the new formatting. I have committed something for that. The issue was that the generated HTML contained hard-coded style attributes. -- Peter

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Wed, Apr 12, 2017 at 01:31:51PM +0200, Magnus Hagander wrote: > I think that only leaves the change to the javascript code that Bruce sent. > Let's see if we can figure out a way to do that one without requiring > javascript, but after that we have covered all listed issues I think? Well, we

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Tue, Apr 11, 2017 at 4:30 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/11/17 08:49, Magnus Hagander wrote: > > At the risk of being proven wrong again, won't this affect tags in > > the old documentation as well? And if so, is that something we actually > > want? > >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/11/17 08:49, Magnus Hagander wrote: > At the risk of being proven wrong again, won't this affect tags in > the old documentation as well? And if so, is that something we actually > want? Right. New patch with more refined selectors attached. > It does? The output on my laptop for that

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Tue, Apr 11, 2017 at 5:06 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/8/17 12:50, Robert Haas wrote: > > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > >> What other problems do we have with pgweb that I can work on? > > > > Well, the

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 4/8/17 12:50, Robert Haas wrote: > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: >> What other problems do we have with pgweb that I can work on? > > Well, the 10devel documentation doesn't believe in orange. Compare: > >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Mon, Apr 10, 2017 at 10:17:26AM +0200, Magnus Hagander wrote: > didn't that that happened in the old docs, but I can use an href filter > to do it only for docs of versions starting with '1' or saying 'devel'. > > That said, doing something like this would probably be cleaner. However,

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Mon, Apr 10, 2017 at 4:02 AM, Bruce Momjian wrote: > On Sun, Apr 9, 2017 at 07:00:38PM +0200, Magnus Hagander wrote: > > > > > > On Sun, Apr 9, 2017 at 2:32 AM, Bruce Momjian wrote: > > > > On Sat, Apr 8, 2017 at 12:50:19PM -0400, Robert Haas wrote:

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sun, Apr 9, 2017 at 06:59:09PM +0200, Magnus Hagander wrote: > On Sat, Apr 8, 2017 at 3:52 AM, Bruce Momjian wrote: > Attached is a patch that can be applied to pgweb which should fix all of > this. > > Is there any chance we can find a way to do this with actual CSS

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sun, Apr 9, 2017 at 07:00:38PM +0200, Magnus Hagander wrote: > > > On Sun, Apr 9, 2017 at 2:32 AM, Bruce Momjian wrote: > > On Sat, Apr  8, 2017 at 12:50:19PM -0400, Robert Haas wrote: > > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sun, Apr 9, 2017 at 2:32 AM, Bruce Momjian wrote: > On Sat, Apr 8, 2017 at 12:50:19PM -0400, Robert Haas wrote: > > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > > > What other problems do we have with pgweb that I can work on? > > > > Well, the

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 3:52 AM, Bruce Momjian wrote: > On Fri, Mar 24, 2017 at 07:01:46AM +0100, Fabien COELHO wrote: > > > > Hello Peter, > > > > >I think the fix belongs into the web site CSS, so there is nothing to > > >commit into PostgreSQL here. > > > > Indeed, the

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 12:50:19PM -0400, Robert Haas wrote: > On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > > What other problems do we have with pgweb that I can work on? > > Well, the 10devel documentation doesn't believe in orange. Compare: > >

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 6:39 AM, Bruce Momjian wrote: > What other problems do we have with pgweb that I can work on? Well, the 10devel documentation doesn't believe in orange. Compare: https://www.postgresql.org/docs/devel/static/sql-createtable.html

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Sat, Apr 8, 2017 at 07:33:15PM +0900, Fabien COELHO wrote: > > >The fix, as Fabien identified, is to conditionally inject additional CSS > >to be _more_ specific than the first CSS and set the font-size to a > >simple '1em' so the first CSS is not called twice. I don't think > >'important!'

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

The fix, as Fabien identified, is to conditionally inject additional CSS to be _more_ specific than the first CSS and set the font-size to a simple '1em' so the first CSS is not called twice. I don't think 'important!' is necessary but it would be good to test this. I did not wrote the fix,

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On Fri, Mar 24, 2017 at 07:01:46AM +0100, Fabien COELHO wrote: > > Hello Peter, > > >I think the fix belongs into the web site CSS, so there is nothing to > >commit into PostgreSQL here. > > Indeed, the changes were only for the "remove nesting" solution. > > >I will close the commit fest

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

Hello Peter, I think the fix belongs into the web site CSS, so there is nothing to commit into PostgreSQL here. Indeed, the changes were only for the "remove nesting" solution. I will close the commit fest entry, but I have added a section to the open items list so we keep track of it.

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

I think the fix belongs into the web site CSS, so there is nothing to commit into PostgreSQL here. I will close the commit fest entry, but I have added a section to the open items list so we keep track of it. (https://wiki.postgresql.org/wiki/PostgreSQL_10_Open_Items#Documentation_tool_chain) --

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

Hello Peter, I think what you are looking at is the web site stylesheet. Yep. The whole thing looks fine to me using the default stylesheet. On the web site, it looks wrong to me too. I don't know what the rationale for using 1.3em for is, but apparently it's not working correctly.

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 3/2/17 05:50, Fabien COELHO wrote: > (2) do use absolute sizes in the CSS, not relative ones like "1.3em" > which accumulate multiplications when code appears in code, > and count on the navigator ctrl-+/- for users to adjust size > consistently to their needs. I think what you

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

After asking around, and testing with a colleague, we got the same strange size behavior on firefox mac as well. There are 2 possible solutions: (1) do not nest in the first place (i.e. apply the patch I sent). (2) do use absolute sizes in the CSS, not relative ones like "1.3em" which

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

I'm not sure whether it is a stylesheet issue: it is the stylesheet as interpreted by chrome... all is fine with firefox. Whether the bug is in chrome or the stylesheet or elsewhere is well beyond my HTML/CSS skills, but I can ask around. After asking around, and testing with a colleague,

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

Hello Peter, I wrote a few lines of perl to move replaceable out of option and did some manual editing is special cases, the resulting simple 359 changes is attached. If the stylesheet produces unpleasant output, then the stylesheet should be changed. Sure. I'm not sure whether it is a

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

On 2/19/17 12:34, Fabien COELHO wrote: > I wrote a few lines of perl to move replaceable out of option and did some > manual editing is special cases, the resulting simple 359 changes is > attached. If the stylesheet produces unpleasant output, then the stylesheet should be changed. The

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

-f filename The filename in the newer html appears much larger under chrome, seemingly because of the within a . Maybe a bug in chrome CSS interpretation, because CSS on code seems to indicate "font-size: 1.3em", but it seems to do 1.3**2 instead for "filename"... However

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

Hello Magnus, It turns out the "c2" class is added by tidy. The reason is this: http://api.html-tidy.org/tidy/quickref_5.0.0.html#clean I've removed the flag for the devel docs build for now (or - for any XML based docs build). I've also forced another docs load, so the results can be