Re: [PATCHES] contrib/dbmirror

2004-06-30 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: >> Attached is a 1 line bug fix for dbmirror that was submitted. >> It fixes a bug where some transactions could be dropped when writing >> mirrored SQL statements to files. > I know that there were discussions regarding removing t

Re: [PATCHES] latest plperl

2004-06-30 Thread Joe Conway
Andrew Dunstan wrote: The attached patch (and 2 new files incorporating previous eloglvl.[ch] as before) has the following changes over previously sent patch (fixes all by me): Some comments below: In plperl_trigger_build_args(), this looks bogus: + char *tmp; + +

Re: [PATCHES] latest plperl

2004-06-30 Thread Joe Conway
Andrew Dunstan wrote: The attached patch (and 2 new files incorporating previous eloglvl.[ch] as before) has the following changes over previously sent patch (fixes all by me): The patch file itself seems to be empty -- please resend. Thanks, Joe ---(end of broadcast)--

Re: [PATCHES] latest plperl

2004-06-30 Thread Andrew Dunstan
Joe Conway said: > Andrew Dunstan wrote: >> The attached patch (and 2 new files incorporating previous >> eloglvl.[ch] as before) has the following changes over previously >> sent patch >> (fixes all by me): > > The patch file itself seems to be empty -- please resend. > it has 36k with expected

Re: [PATCHES] contrib/dbmirror

2004-06-30 Thread Joe Conway
[EMAIL PROTECTED] wrote: Attached is a 1 line bug fix for dbmirror that was submitted. It fixes a bug where some transactions could be dropped when writing mirrored SQL statements to files. I know that there were discussions regarding removing the replication contribs (rserv and dbmirror) prior t

Re: [PATCHES] latest plperl

2004-06-30 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > If you have some specific patches in mind, I can try to work on one or > more tomorrow and Friday. Unfortunately, on Saturday morning I'm leaving > on a 3600 mile roadtrip by car, and while I'm gone my connectivity will > be spotty (for a week and a half)

Re: [PATCHES] latest plperl

2004-06-30 Thread Joe Conway
Tom Lane wrote: Are there any other pending patches you're interested in taking responsibility for? Yeah, I know you've been especially overloaded lately, and I feel badly that I've not been able to help out in recent months :-( If you have some specific patches in mind, I can try to work on one

Re: [PATCHES] latest plperl

2004-06-30 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > I've been working with Andrew and company on this for a few days. I > intend to finish up my code review and commit it tomorrow sometime, > unless someone has objections. Oh good. I've been feeling stretched a bit thin --- if you want to deal with the pl

[PATCHES] contrib/dbmirror

2004-06-30 Thread ssinger
Attached is a 1 line bug fix for dbmirror that was submitted. It fixes a bug where some transactions could be dropped when writing mirrored SQL statements to files. -- Steven Singer [EMAIL PROTECTED] Dispatch SystemsPhone: 519

Re: [PATCHES] latest plperl

2004-06-30 Thread Andrew Dunstan
Joe Conway wrote: Andrew Dunstan wrote: The attached patch (and 2 new files incorporating previous eloglvl.[ch] as before) has the following changes over previously sent patch (fixes all by me): - fix null <-> undef mappings - fix GNUmakefile to honor rpath configuration, and remove ugly compil

Re: [PATCHES] latest plperl

2004-06-30 Thread Joe Conway
Andrew Dunstan wrote: The attached patch (and 2 new files incorporating previous eloglvl.[ch] as before) has the following changes over previously sent patch (fixes all by me): - fix null <-> undef mappings - fix GNUmakefile to honor rpath configuration, and remove ugly compile arnings due to inap

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Simon Riggs
On Wed, 2004-06-30 at 22:29, Gavin Sherry wrote: > On Thu, 1 Jul 2004, Gavin Sherry wrote: > Oh, and it doesn't handle WAL. Tom mentioned/agreed that btree's method of > dumping whole pages into WAL would be the best/most efficient way to > journaling this and that the btree code should be general

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Gavin Sherry
On Thu, 1 Jul 2004, Gavin Sherry wrote: > Hi all, > > Attached is an updated ALTER TABLE ... SET TABLESPACE patch. > > It uses the block by block copy mechanism proposed by Tom and handles i) > ALTER TABLE and ii) Copying of TOAST tables and the TOAST > table's index. > > It doesn't handle c

[PATCHES] latest plperl

2004-06-30 Thread Andrew Dunstan
The attached patch (and 2 new files incorporating previous eloglvl.[ch] as before) has the following changes over previously sent patch (fixes all by me): - fix null <-> undef mappings - fix GNUmakefile to honor rpath configuration, and remove ugly compile arnings due to inappropriate use of rpat

[PATCHES] contrib/fuzzystrmatch updates

2004-06-30 Thread Joe Conway
If there are no objections, I intend to commit the attached tonight or tomorrow. Changes as follows: - Adds double metaphone code from Andrew Dunstan - Change metaphone so that an empty input string causes an empty output string to be returned, instead of throwing an ERROR. Resolv

Re: [PATCHES] PITR Archive Recovery

2004-06-30 Thread Simon Riggs
On Wed, 2004-06-30 at 12:27, [EMAIL PROTECTED] wrote: > Given that log files will be archieved, how can we purge them (ie know for > sure we won't need them anymore) > Good question - you're right I've not mentioned that. The answer is straightforward. Whenever you do a backup, one of the transa

Re: [PATCHES] psql schema permissions

2004-06-30 Thread Dennis Bjorklund
On Wed, 30 Jun 2004, Kris Jurka wrote: > > There is no way to show schema permissions in psql. > > > > 4) Since \dn only shows the name and the owner we can simply > > add a permission column. > > Someone requested that \dn+ also show the comment for the schema, if > you're messing aroun

Re: [PATCHES] psql schema permissions

2004-06-30 Thread Kris Jurka
On Wed, 30 Jun 2004, Dennis Bjorklund wrote: > There is no way to show schema permissions in psql. > > 4) Since \dn only shows the name and the owner we can simply > add a permission column. > Someone requested that \dn+ also show the comment for the schema, if you're messing around i

[PATCHES] [PATCH] s_lock support for win32

2004-06-30 Thread Manfred Spraul
Hi, The win32 port doesn't have a native user space spinlock implementation yet. Attached is an untested patch - could someone test it? I don't have Visual C++. -- Manfred Index: src/include/storage/s_lock.h === RCS file: /projec

[PATCHES] [PATCH] fix libpq mutex initialization for multithreaded win32 libs

2004-06-30 Thread Manfred Spraul
Hi, win32 doesn't support a static initializer for mutexes, thus the first user must initialize the lock. The problem are concurrent "first" users - the pthread_mutex_t initialization must be synchronized. The current implementation is broken, the attached patches fixes that: mutex_initlock is a

Re: [PATCHES] patch queue reminder

2004-06-30 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > That site is maintained by Bruce, who is out to Armenia until next week, > with virtually no internet access. > In the meanwhile, Tom is trying to take Bruce's part as far as his spare > time allowes, but he probably won't maintain the pending-patches s

[PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Gavin Sherry
Hi all, Attached is an updated ALTER TABLE ... SET TABLESPACE patch. It uses the block by block copy mechanism proposed by Tom and handles i) ALTER TABLE and ii) Copying of TOAST tables and the TOAST table's index. It doesn't handle copying of system tables (pg_largeobject) and, in the int

[PATCHES] psql schema permissions

2004-06-30 Thread Dennis Bjorklund
There is no way to show schema permissions in psql. The alternatives are: 1) A new \dpn command 2) Extend \dp to also show rights for schemas, but then we need an extra column to describe what kind of object it is, and it would mess up the pattern stuff. 3) Do nothing and let pe

Re: [PATCHES] patch queue reminder

2004-06-30 Thread Fabien COELHO
Dear Andreas, > >I have two minor patches that are being submitted but which do not appear > so please be patient. I'm patient, no problem! I'm sorry if my English writing does not convey the soft sound of my voice that would tell that I'm not in a hurry. I'm just vaguely afraid that the submis

Re: [PATCHES] patch queue reminder

2004-06-30 Thread Andreas Pflug
Fabien COELHO wrote: Dear patchers, I have two minor patches that are being submitted but which do not appear yet in the "official" patch queue on the web site: http://momjian.postgresql.org/cgi-bin/pgpatches That site is maintained by Bruce, who is out to Armenia until next week, with virtua

[PATCHES] patch queue reminder

2004-06-30 Thread Fabien COELHO
Dear patchers, I have two minor patches that are being submitted but which do not appear yet in the "official" patch queue on the web site: http://momjian.postgresql.org/cgi-bin/pgpatches I understand that reviewing patch is not a sexy business, but the "feature freeze" is coming, and I wish

Re: [PATCHES] PITR Archive Recovery

2004-06-30 Thread ohp
Dear Simon, I've been following the PITR thread with great interest since a long time. I apologie to jump it so late, but there's one question I can't find any answer for. Given that log files will be archieved, how can we purge them (ie know for sure we won't need them anymore) if I do a backup