Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-28 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I do think we need a boolean for start/stop of archiving, rather than > > setting it to '' to turn it off. Tom, I think the group agreed to this > > on clarity grounds. > > I didn't see any consensus there, nor do I see a point to it

Re: [PATCHES] logger subprocess

2004-07-28 Thread Bruce Momjian
Retracted by author. --- Andreas Pflug wrote: > This is the known patch, with following changes: > > - realStdErr handed over for EXEC_BACKEND, but still not tested > - Sometimes EMFILE is received in the logger's process q

Re: [PATCHES] pg_ctl -o option dumps core when processing postmaster arguments...

2004-07-28 Thread Bruce Momjian
Uh, this patch is strange: -#define WHITESPACE "\f\n\r\t\v"/* as defined by isspace() */ +#define WHITESPACE "\f\n\r\t\v\0" /* as defined by isspace() */ They are processed the same by the backend because every string has a trailing null. I think there must be some other bu

Re: [PATCHES] pgxs: build infrastructure for extensions v4

2004-07-28 Thread Fabien COELHO
Dear peter, > > Please find attached another new version of a patch which provides a > > working infrastructure for pg extensions. I hope it addresses all of > > Peter's comments. I'll be away for the next 3 weeks, so if minor > > changes are required it would be best if you could proceed without

Re: [PATCHES] [subxacts] Fixing TODO items

2004-07-28 Thread Alvaro Herrera
On Tue, Jul 27, 2004 at 01:32:01PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > There are some likely controversial changes; the Xid caches, in the > > first place. > > No kidding ;-) Ok, here is another try. This patch includes both the Xid cache rewrite, source docum

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: I wanted to keep a solution that was as native to the OS as possible, but because we can't do that on Win32 and few people like the unix system call to 'rm', it is time to clean it up. One question --- why is there a sleep loop needed for unlink in you

Re: [PATCHES] logger subprocess

2004-07-28 Thread Andreas Pflug
Bruce Momjian wrote: Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. Do not apply. I'm investigating issues under win32. Main issue:

Re: [PATCHES] pg_config

2004-07-28 Thread Bruce Momjian
Would someone address this and make a new patch? The files are in the patch queue. Thanks. --- Peter Eisentraut wrote: > Andrew Dunstan wrote: > > I don't see a function there to report the libdir at all (only > > pkglibdi

Re: [PATCHES] [HACKERS] Point in Time Recovery

2004-07-28 Thread Bruce Momjian
I do think we need a boolean for start/stop of archiving, rather than setting it to '' to turn it off. Tom, I think the group agreed to this on clarity grounds. I would like the server to throw an error if you try to turn on archiving and the command is set to ''. --

Re: [PATCHES] Admin functions contrib

2004-07-28 Thread Bruce Momjian
I talked to Tom about this today. First, I want to apologize for running you around in circles in this. I don't think we are giving it the attention it needs because of our schedule. I also think the functionality is drifting into the "new features" territory and this is also part of the delay

Re: [PATCHES] Some release notes corrections.

2004-07-28 Thread Bruce Momjian
Thanks, applied. --- Brian B. wrote: > Here's a patch of things I think may need to be adjusted. Maybe all or > some of the changes will prove useful. > > > Thanks, > > Brian B. [ Attachment, skipping... ] > >

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Andrew Dunstan
Bruce Momjian wrote: Dave, now that we are nearing beta, I think we need to correct the initdb problem with removing the directory on Win32. Would you code this up as something that sits in /port/dirmod.c and have both initdb and DROP DATABASE call the C routine rather than call rm -r/rmdir? (I

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The small wrinkle here is that rmtree needs to make a copy of the file > names before it starts removing things. In the backend case that means > calling palloc() and friends - am I correct in assuming it is reasonable > to do this in whatever context

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Bruce Momjian
Andrew Dunstan wrote: > >I wanted to keep a solution that was as native to the OS as possible, > >but because we can't do that on Win32 and few people like the unix > >system call to 'rm', it is time to clean it up. > > > >One question --- why is there a sleep loop needed for unlink in your > >patc

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Andrew Dunstan
Dave Page wrote: -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: 28 July 2004 09:29 To: Dave Page Cc: Tom Lane; PostgreSQL-development; [EMAIL PROTECTED] Subject: Re: [HACKERS] Cannot initdb in cvs tip Dave, now that we are nearing beta, I think we need to cor

[PATCHES] Some release notes corrections.

2004-07-28 Thread Brian B.
Here's a patch of things I think may need to be adjusted. Maybe all or some of the changes will prove useful. Thanks, Brian B. --- release.sgml.orig 2004-07-28 00:01:22.620329079 -0400 +++ release.sgml2004-07-28 00:04:15.712796036 -0400 @@ -171,7 +171,7 @@ Server config

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Dave Page
> -Original Message- > From: Bruce Momjian [mailto:[EMAIL PROTECTED] > Sent: 28 July 2004 09:29 > To: Dave Page > Cc: Tom Lane; PostgreSQL-development; [EMAIL PROTECTED] > Subject: Re: [HACKERS] Cannot initdb in cvs tip > > > Dave, now that we are nearing beta, I think we need to > c

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Bruce Momjian
Dave, now that we are nearing beta, I think we need to correct the initdb problem with removing the directory on Win32. Would you code this up as something that sits in /port/dirmod.c and have both initdb and DROP DATABASE call the C routine rather than call rm -r/rmdir? (I think those are the o