Re: [PATCHES] 8.0.0b1: configure.in cygipc

2004-09-01 Thread Reini Urban
Peter Eisentraut schrieb: Reini Urban wrote: But my patch is still valid: The current cygipc check is wrong when cygserver is running. If cygserver is not running, it displays a warning when using the cygipc library. What would be wrong with using cygserver when available (!= when running),

Re: [PATCHES] time_t timezone

2004-09-01 Thread Reini Urban
Tom Lane schrieb: Reini Urban [EMAIL PROTECTED] writes: Added configure time_t timezone check for the SUSV definition. Kindly do not claim that this is per SUS spec. http://www.opengroup.org/onlinepubs/007908799/xsh/timezone.html oops! sorry :( -- Reini Urban

[PATCHES] pg_autovacuum service fixes

2004-09-01 Thread Dave Page
Hi, The attached patch addresses the following issues with the WIn32 service code in pg_autovacuum. Please apply. - Add documentation. - Use the main PostgreSQL message dll when logging to the application log. - Set the -P (port) option correctly when installing as a service. Regards, Dave

Re: [PATCHES] time_t timezone

2004-09-01 Thread Bruce Momjian
I am inclined to leave the #ifdef Cygwin test in the code rather than add a configure check. --- Reini Urban wrote: Tom Lane schrieb: Reini Urban [EMAIL PROTECTED] writes: Added configure time_t timezone check for the

Re: [PATCHES] time_t timezone

2004-09-01 Thread Reini Urban
Bruce Momjian schrieb: I am inclined to leave the #ifdef Cygwin test in the code rather than add a configure check. No, There are a lot of other systems with time_t timezone! newlib explains it like this: /* defines for the opengroup specifications Derived from Issue 1 of the SVID. */ extern

Re: [PATCHES] time_t timezone

2004-09-01 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: But the time_t timezone issue is here: XSHd7 Aardvark Change Request Report http://www.opengroup.org/austin/docs/austin_97.txt (ERN 20 Accept as marked, page 1177) There is nothing whatever on that page about the datatype of the timezone variable.

Re: [PATCHES] time_t timezone

2004-09-01 Thread Reini Urban
Tom Lane schrieb: Reini Urban [EMAIL PROTECTED] writes: But the time_t timezone issue is here: XSHd7 Aardvark Change Request Report http://www.opengroup.org/austin/docs/austin_97.txt (ERN 20 Accept as marked, page 1177) There is nothing whatever on that page about the datatype of the timezone

Re: [PATCHES] time_t timezone

2004-09-01 Thread Tom Lane
Reini Urban [EMAIL PROTECTED] writes: Yes, they are talking about the localtime return value, but nevertheless the newlib folks refer to that. Their fault. Should I discuss that with them? Probably. They have a gratuitous variation from the Single Unix Spec. But what may be more to the

[PATCHES] Win32 Version patch

2004-09-01 Thread Dave Page
Evening committers, Any ideas when Magnus' win32 version numbering patch is likely to get applied? Regards, Dave. ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes

Re: [PATCHES] time_t timezone

2004-09-01 Thread Reini Urban
Tom Lane schrieb: Reini Urban [EMAIL PROTECTED] writes: Yes, they are talking about the localtime return value, but nevertheless the newlib folks refer to that. Their fault. Should I discuss that with them? Probably. They have a gratuitous variation from the Single Unix Spec. But what may be

Re: [PATCHES] time_t timezone

2004-09-01 Thread Bruce Momjian
Tom Lane wrote: Reini Urban [EMAIL PROTECTED] writes: Yes, they are talking about the localtime return value, but nevertheless the newlib folks refer to that. Their fault. Should I discuss that with them? Probably. They have a gratuitous variation from the Single Unix Spec. But

Re: [PATCHES] dbsize contrib

2004-09-01 Thread Bruce Momjian
Patch applied. Thanks. Can I get some documentation in the README for all the new functionality. --- Andreas Pflug wrote: The current implementation of dbsize doesn't handle tables in tablespaces correctly, and is

Re: [PATCHES] Timezones on localized windows

2004-09-01 Thread Bruce Momjian
Patch applied. Thanks. This part of the patch was already in CVS: *** 822,829 --- 822,832 { int i; chartzname[128]; + charlocaltzname[128]; time_t

Re: [PATCHES] Timezones on localized windows

2004-09-01 Thread Bruce Momjian
I have backed out my application of the patch because Tom already applied it. I didn't see the merge failure because I assume Tom placed your code in a different part of the code. --- Bruce Momjian wrote: Patch applied.

Re: [PATCHES] Win32 Version patch

2004-09-01 Thread Bruce Momjian
Dave Page wrote: Evening committers, Any ideas when Magnus' win32 version numbering patch is likely to get applied? Good question. Last I saw it it was quite large. Magnus, would you post a new version so we can look it over again. I have no problem with the binary file you suggested. --