Re: [PATCHES] Cosmetic changes

2004-09-30 Thread Tom Lane
Euler Taveira de Oliveira <[EMAIL PROTECTED]> writes: > This small patch correct a hint style and change from multiple to > single line comment because gettext seems not to like multiple line > comments. Then we could see the "translator: ..." in po files too. I believe most of these changes are f

[PATCHES] Cosmetic changes

2004-09-30 Thread Euler Taveira de Oliveira
Hi, This small patch correct a hint style and change from multiple to single line comment because gettext seems not to like multiple line comments. Then we could see the "translator: ..." in po files too. = Euler Taveira de Oliveira euler[at]yahoo_com_br _

Re: [PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The following patch addresses this issue by making libpgport usable > unchanged by client applications, and makes a special server version for > the backend. This raises some alarm bells for me. Why does a "port support" library need to distinguish whet

Re: [PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Neil Conway
Pasto: *** src/bin/pg_config/Makefile 1 Aug 2004 06:56:38 - 1.8 --- src/bin/pg_config/Makefile 1 Oct 2004 04:04:06 - *** *** 1,18 [...] --- 1,23 ! #- ! # ! # Makefile for src/bin/pg_contro

[PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Bruce Momjian
As many know, the FRONTEND usage of /src/port is very fragile. It requires every binary that uses certain libpgport object files to create its own version, which is very fragile, and could easily break if a function call is added in a subrelease, especially on certain ports. The following patch a

Re: [PATCHES] LDFLAGS overriding

2004-09-30 Thread Neil Conway
On Thu, 2004-09-30 at 17:20, Neil Conway wrote: > Ok, I think 'override' is definitely correct for the instance the patch > fixes, since the build breaks otherwise. Therefore I intend to apply the > patch I posted earlier to HEAD shortly, barring any objections. Patch applied. I haven't changed th

Re: [PATCHES] 8.0.0beta3 release documentation fixes for Tcl

2004-09-30 Thread Neil Conway
On Thu, 2004-09-30 at 10:30, ljb wrote: > These corrections against 8.0.0beta3 are for removal of the Tcl interface > from core. Patch applied to HEAD, with some editorializing. autoconf (2.53) re-run. For future reference, patches should be made with a consistent directory prefix (i.e. if you're

Re: [PATCHES] SSL on win32

2004-09-30 Thread Dave Page
> -Original Message- > From: Magnus Hagander [mailto:[EMAIL PROTECTED] > Sent: 30 September 2004 23:00 > To: PostgreSQL-patches > Cc: Dave Page > Subject: SSL on win32 > > Hello! > > Here is a patch to fix win32 ssl builds. Summary of changes: > > > I'd appreciate it if one of the

[PATCHES] SSL on win32

2004-09-30 Thread Magnus Hagander
Hello! Here is a patch to fix win32 ssl builds. Summary of changes: * Links with -leay32 and -lssleay32 instead of crypto and ssl. On win32, "crypto and ssl" is only used for static linking. * Initializes SSL in the backend and not just in the postmaster. We cannot pass the SSL context from the

Re: [PATCHES] plperl features

2004-09-30 Thread Sergej Sergeev
Sergej Sergeev <[EMAIL PROTECTED]> writes: What happens if you feed other pseudotypes, like cstring or language_handler? Shouldn't that be disallowed or something? Other pseudo-types are disallowed (no-change) No, because you diked out the check at lines 1452ff, rather than upgr

Re: [PATCHES] LDFLAGS overriding

2004-09-30 Thread Reini Urban
Neil Conway schrieb: [ CC'ing Peter since this is usually his area ] On Wed, 2004-09-29 at 02:10, Bruce Momjian wrote: I think your 'override' fix is correct. Personally I think override should be used in most cases in our code because we are usually careful to add to any flags already supplied by

Re: [PATCHES] minor doc change

2004-09-30 Thread Neil Conway
On Thu, 2004-09-30 at 15:53, Robert Treat wrote: > This patch makes mention to use the newer pg_dump when migrating, as suggested > by a few folks. Patch applied with some editorialization. Thanks! -Neil ---(end of broadcast)--- TIP 3: if postin

Re: [PATCHES] LDFLAGS overriding

2004-09-30 Thread Neil Conway
[ CC'ing Peter since this is usually his area ] On Wed, 2004-09-29 at 02:10, Bruce Momjian wrote: > I think your 'override' fix is correct. Personally I think override > should be used in most cases in our code because we are usually careful > to add to any flags already supplied by the user. Ok