Neil Conway wrote:
Attached is a trivial improvement to ecpg's pgtypeslib: (1) `pstr' must
be non-NULL in this function, so no need to check for it (2) we should
check the return value of pgtypes_strdup(). Patch from Eric Astor at
EDB, with slight cleanup by myself, to fix a Coverity report.
Neil Conway wrote:
This patch adds some missing error handling to PGTYPESnumeric_div() in
ecpg's pgtypeslib: (1) we need to check the return value of sub_abs()
(2) we need to check the return value of 4 calls to digitbuf_alloc().
Applied.
-Neil
---(end of broadcast)--
Dear Stephen,
Attached please find files and patches associated with moving from the
User/Group system currently in place to Roles, as discussed
previously. The files are:
pg_authid.h
New system table, contains role information
To be placed in src/include/catalog, replacing pg_shado
This patch adds some missing error handling to PGTYPESnumeric_div() in
ecpg's pgtypeslib: (1) we need to check the return value of sub_abs()
(2) we need to check the return value of 4 calls to digitbuf_alloc().
Per Coverity static analysis by EDB.
Barring any objections I'll apply this to CVS
Attached is a trivial improvement to ecpg's pgtypeslib: (1) `pstr' must
be non-NULL in this function, so no need to check for it (2) we should
check the return value of pgtypes_strdup(). Patch from Eric Astor at
EDB, with slight cleanup by myself, to fix a Coverity report.
Barring any objectio
Bruce Momjian writes:
> I don't think so. I think trait and property suggests an aspect of the
> object, so saying trait/property size is saying I am talking about an
> aspect of the object, while for a heap, its size is really its size, it
> isn't an aspect of its size.
I haven't been followi
[EMAIL PROTECTED] wrote:
> > > I have a new idea --- pg_storage_size().
> >
> > I'm not against that one, but I think Tom's point is vaild. I cannot
> > think of anything better at the moment though (maybe pg_component_size,
> > but that's equally random) :-(
> >
> > Anyone else? Please? Someone
Simon Riggs wrote:
> On Mon, 2005-06-27 at 01:41 +0100, Simon Riggs wrote:
> > I enclose a fully working implementation of Constraint Exclusion, a very
> > basic form of Partitioning. Initial review is requested, to allow us all
> > to assess what further work is required on this prior to Beta free
Dave Page wrote:
> > That would do just the
> > toast/index/heap, and pg_relation_size() gets a total of them all, and
> > only works on heap, no index or toast.
>
> The totalling version (whatever it ends up being called) should
> definitely work on toast tables, as it is a legitimate use case to
Simon Riggs <[EMAIL PROTECTED]> writes:
> Has this patch been registered for review? I haven't heard anything.
I think Bruce is still out of town, and maintaining his patch list isn't
his highest priority ...
regards, tom lane
---(end of broadcast)
On Mon, 2005-06-27 at 01:41 +0100, Simon Riggs wrote:
> I enclose a fully working implementation of Constraint Exclusion, a very
> basic form of Partitioning. Initial review is requested, to allow us all
> to assess what further work is required on this prior to Beta freeze.
>
> Patch against curr
"Dave Page" writes:
>> I've not been following the thread closely, so maybe this was already
>> proposed and rejected, but what about:
>> [4 functions]
> That moves the goal posts somewhat.
Fair enough. The two you described are OK by me.
regards, tom lane
---
> -Original Message-
> From: Tom Lane [mailto:[EMAIL PROTECTED]
> Sent: 30 June 2005 14:41
> To: Dave Page
> Cc: Michael Glaesemann; PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [PATCHES] Dbsize backend integration
>
> "Dave Page" writes:
> > Thanks Michael. We have 2 fu
"Dave Page" writes:
> Thanks Michael. We have 2 functions - 1 returns the on disk size of a
> table or index without any additional parts such as indexes or toast
> tables. The other function returns the total on disk size of a table and
> all associated indexes and toast tables (and any indexes t
On 6/30/05, Peter Eisentraut <[EMAIL PROTECTED]> wrote:
> Am Donnerstag, 30. Juni 2005 09:34 schrieb Adrian Maier:
> > The attached patch modifies the message displayed by psql
> > when asking the password "Password: "
> > to include the username as well: "Password for user postgres : ".
>
> I can
> -Original Message-
> From: Michael Glaesemann [mailto:[EMAIL PROTECTED]
> Sent: 30 June 2005 10:01
> To: Dave Page
> Cc: PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [PATCHES] Dbsize backend integration
>
>
> I'm still unclear as to what exactly is trying to be captured
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: 30 June 2005 10:29
> To: Bruce Momjian; Dave Page
> Cc: PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [PATCHES] Dbsize backend integration
>
>
> Maybe pg_trait_size() or pg_property_size() wil
> > I have a new idea --- pg_storage_size().
>
> I'm not against that one, but I think Tom's point is vaild. I cannot
> think of anything better at the moment though (maybe pg_component_size,
> but that's equally random) :-(
>
> Anyone else? Please? Someone? Anyone? :-)
Maybe pg_trait_size() or
On Jun 30, 2005, at 5:48 PM, Dave Page wrote:
-Original Message-
From: Bruce Momjian [mailto:[EMAIL PROTECTED]
Sent: 29 June 2005 12:46
I have a new idea --- pg_storage_size().
I'm not against that one, but I think Tom's point is vaild. I cannot
think of anything better at the mo
> -Original Message-
> From: Bruce Momjian [mailto:[EMAIL PROTECTED]
> Sent: 29 June 2005 12:46
> To: Dave Page
> Cc: PostgreSQL-patches; PostgreSQL-development
> Subject: Re: [PATCHES] Dbsize backend integration
>
> I have a new idea --- pg_storage_size().
I'm not against that one,
Am Donnerstag, 30. Juni 2005 09:34 schrieb Adrian Maier:
> The attached patch modifies the message displayed by psql
> when asking the password "Password: "
> to include the username as well: "Password for user postgres : ".
I can't decode your attachment so I don't know if this is a typo or actu
Hello all,
The attached patch modifies the message displayed by psql
when asking the password "Password: "
to include the username as well: "Password for user postgres : ".
Displaying the username is useful when running sql scripts
which are setting the session authorization (like the dump sc
22 matches
Mail list logo