Re: [PATCHES] Unused MMCacheLock

2005-07-28 Thread Neil Conway
Simon Riggs wrote: I thought you removed that in February? Or is my memory playing tricks? Not I -- Tom removed src/backend/storage/smgr/mm.c in February of '04, but evidently forgot to remove the associated LWLock. -Neil ---(end of broadcast)

Re: [HACKERS] [PATCHES] O_DIRECT for WAL writes

2005-07-28 Thread Bruce Momjian
Patch applied. Thanks. --- ITAGAKI Takahiro wrote: > Thanks for reviewing! > But the patch does not work on HEAD, because of the changes in > BootStrapXLOG(). > I send the patch with a fix for it. > > > Bruce Momjian w

Re: [PATCHES] ALTER OBJECT SET SCHEMA

2005-07-28 Thread Bruce Momjian
Here is an updated version of your patch. Would you supply SGML documentation updates to match the code changes? Thanks. --- Bernd Helmle wrote: > Here's my current patch for ALTER OBJECT SET SCHEMA: the attached patch >

Re: [PATCHES] regexp_replace

2005-07-28 Thread Bruce Momjian
Patch applied. Thanks. --- Atsushi Ogawa wrote: > > Bruce Momjian wrote: > > I have applied your patch, with slight adjustments in spacing and > > documentation. > > > > Patch applied. Thanks. > > Thank you for applying

Re: [PATCHES] Unused MMCacheLock

2005-07-28 Thread Simon Riggs
On Wed, 2005-07-27 at 18:06 +1000, Neil Conway wrote: > ITAGAKI Takahiro wrote: > > Are there any reasons MMCacheLock has been left yet? > > Not as far as I can see -- good catch. Patch applied to HEAD. Neil, I thought you removed that in February? Or is my memory playing tricks? Best Regards,

Re: [PATCHES] psql tab-completion for COMMIT/ROLLBACK PREPARED

2005-07-28 Thread Bruce Momjian
Patch applied. Thanks. --- Heikki Linnakangas wrote: > On Fri, 1 Jul 2005, Bruce Momjian wrote: > > > Heikki Linnakangas wrote: > >> On Fri, 1 Jul 2005, Oliver Jowett wrote: > >> > >>> PS: noticed in passing: psql's help

[PATCHES] Win32 eventlog level fix

2005-07-28 Thread Magnus Hagander
This patch fixes the event type used to log output from the stderr-in-service or output-from-syslogger-in-service code. Previously everything was flagged as ERRORs there, which caused all instances to log "LOG: logger shutting down" as error... Please apply for 8.1. I'd also like it considered for

Re: [PATCHES] patch for win32 dynloader

2005-07-28 Thread Magnus Hagander
> >> 3) I restarted the postmaster both times. I got this error > both times. > >> :25: ERROR: could not load library "C:/Program > >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error > > > Yes. We really need to look at fixing that error message. I had > > forgotten it completel

Re: [PATCHES] AIX - pgport/contrib resolution

2005-07-28 Thread Rocco Altier
Here is a backport of patches to get AIX to work on 8.0. Basically, it's the changes to : backend/Makefile - redo the linking of the SUBSYS objects contrib/cube - pick up -lm port/getopt_long.c - fix include files (might want to think about other files changed here too?) contrib/tsearch2 - similar

Re: [PATCHES] AIX - pgport/contrib resolution

2005-07-28 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Pushed these in too ... hope to see a green board on the AIX buildfarm >> machines soon. > That's what we have. Good work. Are these changes too intrusive to > backpatch to 8.0? At this point I'm not sure which changes are necessary

Re: [PATCHES] AIX - pgport/contrib resolution

2005-07-28 Thread Andrew Dunstan
Tom Lane wrote: Pushed these in too ... hope to see a green board on the AIX buildfarm machines soon. That's what we have. Good work. Are these changes too intrusive to backpatch to 8.0? cheers andrew ---(end of broadcast)---