Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Böszörményi Zoltán
Hi, > Robert Treat <[EMAIL PROTECTED]> writes: >> On Tuesday 22 August 2006 16:10, Tom Lane wrote: >>> As I see it, we've effectively got a patch that was rejected once, >>> and Bruce wants to apply it anyway because no replacement has been >>> forthcoming. > >> Well, unless someone is going to co

Re: [PATCHES] Some minor changes to pgbench

2006-08-22 Thread Tom Lane
"Joshua D. Drake" <[EMAIL PROTECTED]> writes: > * The schema now uses foreign keys to more accurately reflect a finacial DDL Addition of foreign key checking will certainly impact performance significantly. > * The history table now has a primary key that uses a serial Ditto. > * The respective

[PATCHES] Some minor changes to pgbench

2006-08-22 Thread Joshua D. Drake
2006/08/22 * New schema contributed by Joshua Drake * The schema now uses foreign keys to more accurately reflect a finacial DDL * The history table now has a primary key that uses a serial * The respective balance columns have been increased to int8 to deal with larger values * Initalizatio

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Bruce Momjian
Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > On Tuesday 22 August 2006 16:10, Tom Lane wrote: > >> As I see it, we've effectively got a patch that was rejected once, > >> and Bruce wants to apply it anyway because no replacement has been > >> forthcoming. > > > Well, unless someo

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > On Tuesday 22 August 2006 16:10, Tom Lane wrote: >> As I see it, we've effectively got a patch that was rejected once, >> and Bruce wants to apply it anyway because no replacement has been >> forthcoming. > Well, unless someone is going to commit to doing

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Robert Treat
On Tuesday 22 August 2006 16:10, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > It sucks that patches are posted and no action is taken on them for > > months. I agree with that. > > This particular patch was originally posted during the 8.1 feature > freeze window (2005-09-29),

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > It sucks that patches are posted and no action is taken on them for > > months. I agree with that. > > This particular patch was originally posted during the 8.1 feature > freeze window (2005-09-29), so it was doomed to a certain am

Re: [PATCHES] [GENERAL] pgxml & xpath_table

2006-08-22 Thread John Gray
On Mon, 2006-08-21 at 23:38 -0400, Bruce Momjian wrote: [snip] > > FYI, I have not seen a patch for this yet. > Thanks for prodding me to submit it. Attached is the documentation patch, based on Phillipe's example. Regards John Index: contrib/xml2/README.xml2 ==

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > It sucks that patches are posted and no action is taken on them for > months. I agree with that. This particular patch was originally posted during the 8.1 feature freeze window (2005-09-29), so it was doomed to a certain amount of languishing on the t

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Alvaro Herrera
Hans-Juergen Schoenig wrote: > It has been made as "COPY FROM / TO view" because people wanted it to be > done that way. > My original proposal was in favour of arbitrary SELECTs (just like > proposed by the TODO list) but this was rejected. So, we did it that way > (had to explain to customer

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Andrew Dunstan
Hans-Juergen Schoenig wrote: Tom Lane wrote: Stefan Kaltenbrunner <[EMAIL PROTECTED]> writes: Bruce Momjian wrote: Well, the patch was submitted in time, and it is a desired feature. If we want to hold it for 8.3 due to lack of time, we can, but I don't think we can decide now that it

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > It's a close call. On balance I'd be inclined to accept the patch if it > reviews OK, even though we will throw the code away soon (we hope). Well, the patch seems pretty ugly code-wise as well. I'd be willing to clean it up if I thought it wouldn't u

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Andrew Dunstan
Stefan Kaltenbrunner wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: OK, based on this feedback, I am adding COPY VIEW to the patches queue. I think we have other things that demand our attention more than a half-baked feature.

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Tom Lane
Stefan Kaltenbrunner <[EMAIL PROTECTED]> writes: > Bruce Momjian wrote: >> Well, the patch was submitted in time, and it is a desired feature. If >> we want to hold it for 8.3 due to lack of time, we can, but I don't >> think we can decide now that it must wait. > well I thought the agreed approa

Re: [HACKERS] [PATCHES] COPY view

2006-08-22 Thread Stefan Kaltenbrunner
Bruce Momjian wrote: > Tom Lane wrote: >> Bruce Momjian <[EMAIL PROTECTED]> writes: >>> OK, based on this feedback, I am adding COPY VIEW to the patches queue. >> I think we have other things that demand our attention more than a >> half-baked feature. > > Well, the patch was submitted in time, an

Re: [PATCHES] COPY view

2006-08-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > OK, based on this feedback, I am adding COPY VIEW to the patches queue. > > I think we have other things that demand our attention more than a > half-baked feature. Well, the patch was submitted in time, and it is a desired feature.

Re: [PATCHES] Use of backslash in tsearch2

2006-08-22 Thread Teodor Sigaev
Teodor, are the new attached regression results correct? If so, I will apply the patch and update the expected file. Patch isn't full, simple test (values are took from regression.diffs): # create table tt (tv tsvector, tq tsquery); # insert into tt values (E'''1 \\''2''', NULL); # insert into

Re: [PATCHES] [HACKERS] Unable to post to -patches (was: Visual C++ build files)

2006-08-22 Thread Magnus Hagander
> > a.hub.org[200.46.208.251], delay=1, status=sent (250 2.7.1 Ok, > > discarded, id=258 > > 35-09 - BANNED: P=p003,L=1,M=multipart/mixed | > > P=p002,L=1/2,M=application/x-gzip ,T=gz,N=vcbuild.tar.gz | > P=p...) > > > Seems -patches is rejecting any mail with attached .tar.gz files, > if I > > re