Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Tom Lane
"Gurjeet Singh" <[EMAIL PROTECTED]> writes: > On 1/6/07, Tom Lane <[EMAIL PROTECTED]> wrote: >> Yes, because it can be more than one hostname. > But the code in postmaster.c expects the list to be comma separated. Sure, but SplitIdentifierString allows for whitespace, eg 'host1, host2, h

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
On 1/6/07, Tom Lane <[EMAIL PROTECTED]> wrote: "Gurjeet Singh" <[EMAIL PROTECTED]> writes: > This patch removes double-quotes from around the listen_addresses=%s part; I > couldn't find a way of doing that. But then, the questions is, can the %s > (hostname) have spaces embedded in it? Yes, bec

Re: [PATCHES] [COMMITTERS] pgsql: Put back ERANGE test in dpow().

2007-01-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Actually, when you return ERANGE, what is 'result'? Nan? Inf? finite? I believe it's HUGE_VAL (the largest finite value) ... which is something I don't want to explicitly test for, any more than I liked the explicit use of min/max values before. Your

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Joshua D. Drake
> Actually, I'm not seeing the use-case for a slave having a different > setting from the master at all? > > "My backup server is less reliable than the primary." > > "My backup server is more reliable than the primary." > > Somehow, neither of these statements seem likely to be utt

Re: [PATCHES] [COMMITTERS] pgsql: Put back ERANGE test in

2007-01-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > It ERANGE's only on Inf, not underflow? I would prefer: > > else if (errno == ERANGE && !isinf(result)) > > No objection to that, just don't take out the ERANGE test altogether > again ;-) Actually, when you return ERANGE, what

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Tom Lane
Jim Nasby <[EMAIL PROTECTED]> writes: > On Jan 5, 2007, at 6:30 AM, Zeugswetter Andreas ADI SD wrote: >> Ok, so when you need CRC's on a replicate (but not on the master) you > Which sounds to me like a good reason to allow the option in > recovery.conf as well... Actually, I'm not seeing the u

Re: [PATCHES] [COMMITTERS] pgsql: Put back ERANGE test in dpow().

2007-01-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > It ERANGE's only on Inf, not underflow? I would prefer: > else if (errno == ERANGE && !isinf(result)) No objection to that, just don't take out the ERANGE test altogether again ;-) regards, tom lane

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Tom Lane
"Gurjeet Singh" <[EMAIL PROTECTED]> writes: > This patch removes double-quotes from around the listen_addresses=%s part; I > couldn't find a way of doing that. But then, the questions is, can the %s > (hostname) have spaces embedded in it? Yes, because it can be more than one hostname. Why do you

Re: [PATCHES] [COMMITTERS] pgsql: Put back ERANGE test in dpow().

2007-01-05 Thread Bruce Momjian
Tom Lane wrote: > Log Message: > --- > Put back ERANGE test in dpow(). There are platforms that need this, > like my HPPA ... It ERANGE's only on Inf, not underflow? I would prefer: else if (errno == ERANGE && !isinf(result)) because the sign computation isn't 100%, think pow(-1e30

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-05 Thread Jim Nasby
On Jan 3, 2007, at 4:20 PM, Bill Moran wrote: * trace_temp_files is now an int: -1 disables, 0 and up equate to "log if the file is this size or larger" Another thought is to allow ignoring files over a certain size. The reason is that if you end up creating 10MB of temp files, you can

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Jim Nasby
On Jan 5, 2007, at 6:30 AM, Zeugswetter Andreas ADI SD wrote: Ok, so when you need CRC's on a replicate (but not on the master) you turn it off during standby replay, but turn it on when you start the replicate for normal operation. Which sounds to me like a good reason to allow the option in

Re: [PATCHES] [INTERFACES] BCC55 and libpq 8.2

2007-01-05 Thread Bruce Momjian
I have created the following patch based on your description of how to get BCC compiled. Please let me know how it works against a stock PostgreSQL 8.2.X and I can include the patch in 8.2.2. Sorry it didn't make it in time for 8.2.1.

Re: [PATCHES] Tablespace for temporary objects and sort files

2007-01-05 Thread Albert Cervera Areny
Here's a new version that takes into account the SELECT INTO TEMP case. Thanks Jaime! What other temporary objects do you think should be considered? Any other comments on the patch? A Dijous 04 Gener 2007 05:33, Jaime Casanova va escriure: > On 12/27/06, Albert Cervera Areny <[EMAIL PROTECTED]

Re: [PATCHES] Updated XML patch

2007-01-05 Thread korryd
s/XMLGEN/XMLAGG/ Sorry, I meant XMLAGG() not XMLGEN() -- Korry > > Here is an updated updated XML patch. Unless there are objections of > > the sort that this approach is totally wrong or there is crash > > potential, I'd like to get this committed this week and fill in the > >

Re: [PATCHES] Updated XML patch

2007-01-05 Thread korryd
> Here is an updated updated XML patch. Unless there are objections of > the sort that this approach is totally wrong or there is crash > potential, I'd like to get this committed this week and fill in the > gaps next year. Peter - I have a few quick questions about the XML patch that you sub

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
cool... On 1/6/07, Magnus Hagander <[EMAIL PROTECTED]> wrote: Gurjeet Singh wrote: > On Windows, if logged in as an Administrator, 'make check' fails with > our standard error, saying: > > > Execution of PostgreSQL by a user with administrative permissions is not > permitted. > The server must

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Magnus Hagander
Gurjeet Singh wrote: > On Windows, if logged in as an Administrator, 'make check' fails with > our standard error, saying: > > > Execution of PostgreSQL by a user with administrative permissions is not > permitted. > The server must be started under an unprivileged user ID to prevent > possible s

Re: [PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
This patch removes double-quotes from around the listen_addresses=%s part; I couldn't find a way of doing that. But then, the questions is, can the %s (hostname) have spaces embedded in it? -- [EMAIL PROTECTED] [EMAIL PROTECTED] gmail | hotmail | yahoo }.com On 1/6/07, Gurjeet Singh <[EMAIL PROT

[PATCHES] COPY with no WAL, in certain circumstances

2007-01-05 Thread Simon Riggs
http://archives.postgresql.org/pgsql-hackers/2006-10/msg01172.php As discussed on -hackers, its possible to avoid writing any WAL at all for COPY in these circumstances: BEGIN; CREATE TABLE foo.. COPY foo... COMMIT; BEGIN; TRUNCATE foo.. COPY foo... COMMIT; The enclosed patch implements

[PATCHES] A patch to pg_regress for Windows port

2007-01-05 Thread Gurjeet Singh
On Windows, if logged in as an Administrator, 'make check' fails with our standard error, saying: Execution of PostgreSQL by a user with administrative permissions is not permitted. The server must be started under an unprivileged user ID to prevent possible system security compromises. See the

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Zeugswetter Andreas ADI SD
> > Ok, so when you need CRC's on a replicate (but not on the master) you > > turn it > > off during standby replay, but turn it on when you start the replicate > > for normal operation. > > Thought: even when it's off, the CRC had better be computed for > shutdown-checkpoint records. Else there

Re: [PATCHES] Last infomask bit

2007-01-05 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > I believe it would actually be even better to combine the t_natts and > t_infomask fields to a single 32-bit infomask field. That's not happening, because the alignment is wrong ...unless maybe we switch this field to fall before t_ctid, but t

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Tom Lane
"Zeugswetter Andreas ADI SD" <[EMAIL PROTECTED]> writes: > Ok, so when you need CRC's on a replicate (but not on the master) you > turn it > off during standby replay, but turn it on when you start the replicate > for normal operation. Thought: even when it's off, the CRC had better be computed fo

[PATCHES] Last infomask bit

2007-01-05 Thread Heikki Linnakangas
Hi, We're running out of infomask bits in the tuple header. I bumped into this as I tried to apply both the phantom command ids patch, and the HOT patch simultaneously. They both require one infomask bit, so they conflicted. This has been discussed before; I think the best approach is to use

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Zeugswetter Andreas ADI SD
> > > > What's the use-case for changing the variable on the fly anyway? Seems a > > better > > > > solution is just to lock down the setting at postmaster start. > > > > I guess that the use case is more for a WAL based replicate, that > > has/wants a different setting. Maybe we want a WAL entr

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Simon Riggs
On Fri, 2007-01-05 at 11:01 +0100, Zeugswetter Andreas ADI SD wrote: > > > What's the use-case for changing the variable on the fly anyway? Seems a > better > > > solution is just to lock down the setting at postmaster start. > > I guess that the use case is more for a WAL based replicate, that

Re: [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-05 Thread Zeugswetter Andreas ADI SD
> > >>> Recovery can occur with/without same setting of wal_checksum, to avoid > > >>> complications from crashes immediately after turning GUC on. > > >> > > >> Surely not. Otherwise even the "on" setting is not really a defense. > > > > > Only when the CRC is exactly zero, which happens very