On Fri, Apr 06, 2007 at 11:34:39PM -0400, Bruce Momjian wrote:
Patch applied. Thanks. Your documentation changes can be viewed in
five minutes using links on the developer's page,
Thanks. 8.1 and 8.2 have the same typo -- any reason not to backpatch
this?
--
Michael Fuhr
Correct the spelling of SYMMETRIC.
--
Michael Fuhr
Index: doc/src/sgml/func.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/func.sgml,v
retrieving revision 1.375
diff -c -r1.375 func.sgml
*** doc/src/sgml/func.sgml 5 Apr
Update the UTF-8 RFC reference. RFC 2044 was obsoleted by RFC 2279,
which was obsoleted by RFC 3629.
--
Michael Fuhr
Index: doc/src/sgml/charset.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/charset.sgml,v
retrieving
The uninstall scripts for dblink and ltree were missing some
functions.
--
Michael Fuhr
Index: contrib/dblink/uninstall_dblink.sql
===
RCS file: /projects/cvsroot/pgsql/contrib/dblink/uninstall_dblink.sql,v
retrieving revision 1.2
Fix references to the Options section in the pgcrypto documentation.
Should be applied to HEAD and 8.1.
--
Michael Fuhr
Index: contrib/pgcrypto/README.pgcrypto
===
RCS file: /projects/cvsroot/pgsql/contrib/pgcrypto/README.pgcrypto,v
On Thu, Aug 03, 2006 at 12:05:23PM -0400, Tom Lane wrote:
Michael Fuhr [EMAIL PROTECTED] writes:
Set tg_trigtuple/tg_newtuple in AFTER triggers according to whether
old and new tuples were supplied rather than blindly setting them
according to the event type. Per discussion in pgsql
or stylistically flawed then please advise
and I'll rework it. Thanks.
--
Michael Fuhr
Index: src/backend/commands/trigger.c
===
RCS file: /projects/cvsroot/pgsql/src/backend/commands/trigger.c,v
retrieving revision 1.205
diff -c -r1.205
MySQL users' turn to say, Sure, but speed isn't
everything :-)
--
Michael Fuhr
---(end of broadcast)---
TIP 6: explain analyze is your friend
? This patch changes
the string to E'...' but other ways would be to use dollar quotes
or ESCAPE.
--
Michael Fuhr
Index: contrib/vacuumlo/vacuumlo.c
===
RCS file: /projects/cvsroot/pgsql/contrib/vacuumlo/vacuumlo.c,v
retrieving revision 1.30
Remove a space that incorrectly precedes a comma in the PL/pgSQL
documentation.
--
Michael Fuhr
Index: doc/src/sgml/plpgsql.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v
retrieving revision 1.82
diff -c
of the line, or is that part truncated too?
--
Michael Fuhr
---(end of broadcast)---
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
patches for earlier branches when I get
a chance to build and test those versions.
--
Michael Fuhr
Index: src/backend/utils/adt/datetime.c
===
RCS file: /projects/cvsroot/pgsql/src/backend/utils/adt/datetime.c,v
retrieving revision
dates who's result should be dates whose result.
--
Michael Fuhr
Index: doc/src/sgml/release.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/release.sgml,v
retrieving revision 1.391
diff -c -r1.391 release.sgml
*** doc/src
On Tue, Oct 25, 2005 at 12:17:52AM -0400, Tom Lane wrote:
Michael Fuhr [EMAIL PROTECTED] writes:
dates who's result should be dates whose result.
It's still horrible English :-( A date hasn't got a result, much
less one that includes a daylight savings time adjustment period.
Good point
On Fri, Oct 14, 2005 at 06:18:08PM -0400, Neil Conway wrote:
On Thu, 2005-13-10 at 00:39 -0600, Michael Fuhr wrote:
Correct several typos in the documentation.
Are there any remaining objections to this patch? Otherwise, I'll apply
it within 24 hours.
I could submit a version with randomi
of each; the
latter forms were far more common.
behaviour= behavior
organisation = organization
recognised = recognized
recognises = recognizes
--
Michael Fuhr
Index: doc/src/sgml/config.sgml
===
RCS file: /projects/cvsroot/pgsql
In the UPDATE documentation, indeterminacy is misspelled as
indeterminancy.
http://www.m-w.com/cgi-bin/dictionary?va=indeterminacy
--
Michael Fuhr
Index: doc/src/sgml/ref/update.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src
One of the web pages mentioned in dmetaphone.c has moved. Also fix
a few typos in comments.
The dictionaries I checked list altho as a variant of although,
but I didn't find any other instances of the former in the source
tree so I changed it.
--
Michael Fuhr
Index: contrib/fuzzystrmatch
On Fri, Sep 23, 2005 at 05:03:02PM -0400, Bruce Momjian wrote:
Michael Fuhr wrote:
http://archives.postgresql.org/pgsql-patches/2005-06/msg00519.php
I have backpatched this to 8.0.X. It did not apply cleanly to 7.4.X so
if you would like that version patched please submit a matching patch
Two items the body of the FAQ are numbered 4.20 (the table of
contents correctly has 4.20 and 4.21). This patch fixes that.
--
Michael Fuhr
Index: doc/src/FAQ/FAQ.html
===
RCS file: /projects/cvsroot/pgsql/doc/src/FAQ/FAQ.html,v
The synopsis for SPI_getbinval() shows the third argument being
colnumber but in the Arguments section it appears as rownumber.
This patch corrects that.
The patch is against HEAD but 8.0 and 7.4 have the same mistake.
--
Michael Fuhr
Index: doc/src/sgml/spi.sgml
10) line 3.
Global symbol $x requires explicit package name at (eval 10) line 4.
Global symbol $y requires explicit package name at (eval 10) line 4.
--
Michael Fuhr
---(end of broadcast)---
TIP 5: don't forget to increase your free space map
On Sat, Aug 20, 2005 at 01:52:42PM -0600, Michael Fuhr wrote:
The attached patch allows the PL/Perl regression tests to pass when
use_strict is enabled. I've also attached a variant of plperl_elog.out
to account for an elog() message that shows a different line number
when run under
On Tue, Aug 23, 2005 at 09:12:10PM -0400, Andrew Dunstan wrote:
The attached patch completes (I hope) the work begun by Michael Fuhr in
an earlier unapplied patch, and makes strict mode work as recently
discussed. I moved the embedded strings out of the calling functions
into global macros
On Tue, Aug 23, 2005 at 11:58:25PM -0400, Tom Lane wrote:
Michael Fuhr [EMAIL PROTECTED] writes:
Here's an updated version of the PL/Perl regression test patch that
works with Andrew Dunstan's strict mode patch, both when use_strict
is enabled and when it's disabled. The variant
On Tue, Aug 23, 2005 at 10:30:51PM -0600, Michael Fuhr wrote:
Global symbol $x requires explicit package name at (eval 3) line 1.
If I'm reading the Perl source code correctly (pp_ctl.c), the number
following eval comes from a variable named PL_evalseq that's
incremented each time it appears
explain?
If this is indeed the correct fix then it should probably be
backpatched to 8.0.
--
Michael Fuhr
Index: plperl.c
===
RCS file: /projects/cvsroot/pgsql/src/pl/plperl/plperl.c,v
retrieving revision 1.89
diff -c -r1.89 plperl.c
/msg00189.php
I'm not sure this patch meets Tom's request to avoid too much
violence to the readability, mostly because of the added backslashes
at the end of the macro's lines. Opinions?
--
Michael Fuhr
Index: plperl.c
===
RCS file
The attached patch allows the PL/Perl regression tests to pass when
use_strict is enabled. I've also attached a variant of plperl_elog.out
to account for an elog() message that shows a different line number
when run under use_strict.
--
Michael Fuhr
Index: src/pl/plperl/sql/plperl.sql
On Mon, Jul 11, 2005 at 08:13:24PM -0600, Michael Fuhr wrote:
On Sun, Jul 10, 2005 at 12:58:24AM -0400, Bruce Momjian wrote:
I am unclear about backpatching this. We have to weigh the risks of
applying or not applying to 8.0.X. Comments?
Since 7.4, PL/Python is only available
versions,
which would presumably require DBD::PgSPI.
--
Michael Fuhr
---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings
On Fri, Aug 12, 2005 at 10:22:32PM -0400, Bruce Momjian wrote:
Michael Fuhr wrote:
ECPG ignores SAVEPOINT if it's the first statement of a transaction:
ECPGtrans() ignores the statement because of this check:
/*
* if we are not in autocommit mode, already have committed
is that it assumes a version of Python
based on the OS, which might clean up the current buildfarm but
that isn't really correct. Is there a better way to handle this?
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
plpython_error/.*-darwin=plpython_error_py23
-- test error handling, i forgot
it, say, plpython_error_1.out. Job done, and no OS dependence.
Thanks -- I overlooked that in src/test/regress/README.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send
them in a PL/pgSQL function that traps the
errors), or should we just leave the tests alone now that we think
we understand what's happening?
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 6: explain analyze is your friend
if you installed a new
Python but not a new version of libpython.*.so, then plpython.so
might be linked against an old version.
Does this machine have ldd or the equivalent? If so, can you compare
ldd /path/to/python and ldd /path/to/plpython.so?
--
Michael Fuhr
http://www.fuhr.org/~mfuhr
On Tue, Jul 19, 2005 at 03:11:35PM -0500, Jim C. Nasby wrote:
On Tue, Jul 19, 2005 at 01:54:00PM -0600, Michael Fuhr wrote:
Does this machine have ldd or the equivalent? If so, can you compare
ldd /path/to/python and ldd /path/to/plpython.so?
Oddly, no, it doesn't seem to have ldd
-aliasing -g -bundle plpython.o
-L../../../src/port -L/opt/local/lib -bundle_loader
../../../src/backend/postgres -framework Python -o libplpython.0.0.so
Hmmm...what's that -framework Python business? Looks mighty
suspicious in light of the otool output.
--
Michael Fuhr
http://www.fuhr.org
On Sun, Jul 10, 2005 at 12:58:24AM -0400, Bruce Momjian wrote:
Michael Fuhr wrote:
The patch is against HEAD but the same changes should be applied
to earlier versions because they have the same problem. The patch
might not apply cleanly against earlier versions -- will the committer
@openssl.org/msg00063.html
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://www.postgresql.org/docs/faq
plpython_populate... ok
test plpython_function... ok
test plpython_test... ok
test plpython_error ... ok
test plpython_drop... ok
=
All 6 tests passed.
=
What about documentation updates? Still in the works?
--
Michael Fuhr
http
code but use old (non-STRICT) catalog entries (e.g., restored
from a dump). Per recent discussion in pgsql-hackers.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: contrib/pgcrypto/pgcrypto.sql.in
===
RCS file: /projects/cvsroot
is where the patch was committed.
Could somebody else test HEAD and see what they get?
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister
On Tue, Jul 05, 2005 at 01:14:25PM -0400, Tom Lane wrote:
Aside from minor problems like being broken and undocumented, there is a
more serious question here: is this even the functionality we want?
I'd rather see something akin to PL/pgSQL's RETURN NEXT or PL/Perl's
return_next.
--
Michael
build problems. Any chance of applying
the patches to at least REL8_0_STABLE?
[1] http://www.mail-archive.com/openssl-announce@openssl.org/msg00062.html
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 5: Have you checked
://cvs.openssl.org/chngview?cn=9888
This patch adds the necessary header files. It doesn't appear to
break anything when building against OpenSSL 0.9.7.
BTW, core appears to build and work fine with OpenSSL 0.9.8. I've
built 7.3 through HEAD against 0.9.8-beta6 without noticing any
problems.
--
Michael
they have the same problem. The patch
might not apply cleanly against earlier versions -- will the committer
take care of little differences or should I submit different versions
of the patch?
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: src/pl/plpython/plpython.c
-hackers to keep the discussion in one place
(I already moved it to -hackers from -bugs because the former seemed
more a appropriate place for extended discussion).
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
---(end of broadcast)---
TIP 2: you can
pl_funcs.c has a comment that refers to functins, which I'm
assuming should be functions. The attached patch corrects
the spelling.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: src/pl/plpgsql/src/pl_funcs.c
===
RCS file
Here's a PL/Python patch that includes a few tests for Universal
Newline Support. gmake installcheck in src/pl/plpython is
successful in HEAD on my Solaris 9 box running Python 2.4.1c2.
I ran the tests against an unpatched 8.0.1 server and they failed
as expected.
--
Michael Fuhr
http
On Mon, Mar 21, 2005 at 02:50:47AM -0500, Tom Lane wrote:
Michael Fuhr [EMAIL PROTECTED] writes:
The operative word there was how :-) I don't see anything testing
PL/{Python,Perl,Tcl} under src/test/regress -- should I put something
there?
No.
The PLs have their own regression tests
On Mon, Mar 21, 2005 at 01:19:35AM -0700, Michael Fuhr wrote:
We're testing what happens when \r gets into prosrc, right? Shouldn't
creating the function with \r in single quotes instead of dollar
quotes work, as in the tests I showed in my original submission?
...or what about a little
On Mon, Mar 21, 2005 at 10:28:28AM +1100, Neil Conway wrote:
Michael Fuhr wrote:
How should I submit regression tests?
Yes, please.
The operative word there was how :-) I don't see anything testing
PL/{Python,Perl,Tcl} under src/test/regress -- should I put something
there? Can
being discussed.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: src/pl/plpython/plpython.c
===
RCS file: /projects/cvsroot/pgsql/src/pl/plpython/plpython.c,v
retrieving revision 1.58
diff -c -r1.58 plpython.c
*** src/pl/plpython
On Sat, Feb 19, 2005 at 10:56:46PM -0700, Michael Fuhr wrote:
What about making the behavior configurable at run time, say via a
command-line option?
Such functionality should be easy to backpatch to earlier versions,
shouldn't it? Pleas for help could then be answered with, upgrade
FAQ 4.4 is How do you remove a column from a table, or change it's
data type? The possessive pronoun its doesn't have an apostrophe.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: doc/src/FAQ/FAQ.html
===
RCS file: /projects
The PostgreSQL documentation has examples in the Cursors section
of the PL/pgSQL chapter. If those aren't helpful, then please
describe what you're trying to do so we can provide an example
that's more relevant to the problem.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr
The 8.0.0beta5 Release Notes contain a reference to g_restore instead
of pg_restore.
--
Michael Fuhr
http://www.fuhr.org/~mfuhr/
Index: doc/src/sgml/release.sgml
===
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/release.sgml,v
58 matches
Mail list logo
