Re: [PATCHES] COMMENT ON mega patch

2003-11-23 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> Out of interest, I notice you didn't commit my inv_api.c change to >> delete comments on LOBs - where did you put it instead? > Doh - just answered my own question - elsewhere in the same file. Just editorializing --- the order of operations

Re: [PATCHES] COMMENT ON mega patch

2003-11-21 Thread Christopher Kings-Lynne
Out of interest, I notice you didn't commit my inv_api.c change to delete comments on LOBs - where did you put it instead? Doh - just answered my own question - elsewhere in the same file. Chris ---(end of broadcast)--- TIP 1: subscribe and unsub

Re: [PATCHES] COMMENT ON mega patch

2003-11-21 Thread Christopher Kings-Lynne
* You were using a bare C string as the amname argument in COMMENT ON OPERATOR CLASS. This won't do because the parse tree is not a valid Node structure; copyObject will fail on it. I inserted makeString() and strVal() calls to fix it. BTW, a simple test to detect uncopiable-parsetree problems is

Re: [PATCHES] COMMENT ON mega patch

2003-11-21 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > This patch does the following: > 1. Comment on 5 new objects: > [ etc ] Reviewed and applied. Couple things I didn't like: * You were using a bare C string as the amname argument in COMMENT ON OPERATOR CLASS. This won't do because the parse

[PATCHES] COMMENT ON mega patch

2003-11-18 Thread Christopher Kings-Lynne
This patch does the following: 1. Comment on 5 new objects: COMMENT ON CONVERSION my_conv IS 'Conversion to Unicode'; COMMENT ON LANGUAGE plpython IS 'Python support for stored procedures'; COMMENT ON OPERATOR CLASS int4ops USING btree IS '4 byte integer operators for btrees'; COMMENT ON LARGE O