Re: [PATCHES] [HACKERS] Function structure in formatting.c

2008-03-24 Thread Brendan Jurd
On 23/03/2008, Tom Lane <[EMAIL PROTECTED]> wrote: > > Working through this patch now. I found one thing that seems to be > a mistake (probably an overenthusiastic search&replace): the patch > changes > - {"iy", 2, dch_date, DCH_IY, TRUE}, > to > + {"iyear", 2, DCH_IY, TRUE}, > >

Re: [PATCHES] [HACKERS] Function structure in formatting.c

2008-03-22 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: >> As discussed on -hackers, I've done some refactoring work on >> backend/utils/adt/formatting.c, in an attempt to make the code a bit >> more intelligible before improving handling of bogus formats. Applied with minor revisions.

Re: [PATCHES] [HACKERS] Function structure in formatting.c

2008-03-22 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I noticed an editing error in the patch I originally submitted; it > defined the same debugging macro twice. > I've attached a fresh copy of the patch against the current HEAD with > the fix included. Working through this patch now. I found one thing t

Re: [PATCHES] [HACKERS] Function structure in formatting.c

2007-10-08 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Brendan Jurd wrote: > I noticed an editing error in the patch I originally submitted; it > defined the same debugging

Re: [PATCHES] [HACKERS] Function structure in formatting.c

2007-10-02 Thread Brendan Jurd
I noticed an editing error in the patch I originally submitted; it defined the same debugging macro twice. I've attached a fresh copy of the patch against the current HEAD with the fix included. Cheers, BJ On 8/11/07, Brendan Jurd <[EMAIL PROTECTED]> wrote: > Hello, > > As discussed on -hackers,

Re: [PATCHES] [HACKERS] Function structure in formatting.c

2007-08-13 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Brendan Jurd wrote: > Hello, > > As discussed on -hackers, I've done some refactoring work on > backend/utils/adt/fo