Re: [PATCHES] CREATE INDEX ... ONLINE

2006-08-24 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Updated patch. Fixed a few minor things, added documentation and regression > tests. Unfortunately I can't test the regression tests because I get a > segmentation fault earlier in the same file due to a GIN index build. So I > haven't updated the "expected"

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-08-17 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Just remembered one open question I had. I'm not clear what to do with the > index statistics. It may be that the current code is basically the right thing > -- it leaves the statistics as they are after phase 1, ie after the regular > index build before we

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-08-17 Thread Greg Stark
Greg Stark <[EMAIL PROTECTED]> writes: > > Tom Lane <[EMAIL PROTECTED]> writes: > > > Greg Stark <[EMAIL PROTECTED]> writes: > > > Updated patch. Fixed a few minor things, added documentation and > > > regression > > > tests. Unfortunately I can't test the regression tests because I get a > > >

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-08-16 Thread Greg Stark
Tom Lane <[EMAIL PROTECTED]> writes: > Greg Stark <[EMAIL PROTECTED]> writes: > > Updated patch. Fixed a few minor things, added documentation and regression > > tests. Unfortunately I can't test the regression tests because I get a > > segmentation fault earlier in the same file due to a GIN inde

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-08-16 Thread Tom Lane
Greg Stark <[EMAIL PROTECTED]> writes: > Updated patch. Fixed a few minor things, added documentation and regression > tests. Unfortunately I can't test the regression tests because I get a > segmentation fault earlier in the same file due to a GIN index build. So I > haven't updated the "expected"

Re: [PATCHES] CREATE INDEX ... ONLINE

2006-07-29 Thread Bruce Momjian
Still discussion about keyword use. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---