Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Bruce Momjian
Patch applied. Thanks. I added #ifdef WIN32 around your new postmaster function. --- Magnus Hagander wrote: > Hi! > > Here's a patch implementing the "thread method" to workaround the bug > with socket calls in signal ha

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Claudio Natoli
> >What I am wondering about now, is where else we need to change? AFAICS, > >there is (at least?) one signal handler that performs sockets > >ops, namely Async_NotifyHandler. > > Actually, I don't think we need to do anything about that one. This > signal handler is used in the backend (not pos

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Magnus Hagander
>> > > Here's a patch implementing the "thread method" to >> > workaround the bug >> > > with socket calls in signal handlers. See details in mail to >> > > pgsql-hackers-win32 a couple of minutes ago. >> > >> > Looks ok, but wouldn't it be better placed in pgstat.c? >> >> Actually, I don't th

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Claudio Natoli
> > > Here's a patch implementing the "thread method" to > > workaround the bug > > > with socket calls in signal handlers. See details in mail to > > > pgsql-hackers-win32 a couple of minutes ago. > > > > Looks ok, but wouldn't it be better placed in pgstat.c? > > Actually, I don't think so.

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Magnus Hagander
> > Here's a patch implementing the "thread method" to > workaround the bug > > with socket calls in signal handlers. See details in mail to > > pgsql-hackers-win32 a couple of minutes ago. > > Looks ok, but wouldn't it be better placed in pgstat.c? Actually, I don't think so. I considered it,

Re: [PATCHES] Patch for select and APC on win32

2004-03-22 Thread Claudio Natoli
> Here's a patch implementing the "thread method" to workaround the bug > with socket calls in signal handlers. See details in mail to > pgsql-hackers-win32 a couple of minutes ago. Looks ok, but wouldn't it be better placed in pgstat.c? My $0.02, Claudio --- Certain disclaimers and policies