Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > >Tom Lane wrote: > > > > > >>"Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > >> > >> > >>>I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > >>>WIN32... #endif clause to pgdumpopts to store > >>>the parameters with

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Andrew Dunstan
Bruce Momjian wrote: Tom Lane wrote: "Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef WIN32... #endif clause to pgdumpopts to store the parameters with double quotations intead simple quotation marks in case of WIN32 ports

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Tom Lane wrote: > "Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > > I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > > WIN32... #endif clause to pgdumpopts to store > > the parameters with double quotations intead simple quotation marks in > > case of WIN32 ports > > This s

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Bruce Momjian
Patch applied. Thanks. --- Luiz K. Matsumura wrote: > > > Andrew Dunstan wrote: > > > > > > > Luiz K. Matsumura wrote: > > > >> Hi, > >> > >> I tried to use pg_dumpall in Win32 and receive a error message like > >> th

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Tom Lane
"Luiz K. Matsumura" <[EMAIL PROTECTED]> writes: > I modified pg_dumpall.c lines between 160 and 270 to add a #ifndef > WIN32... #endif clause to pgdumpopts to store > the parameters with double quotations intead simple quotation marks in > case of WIN32 ports This seems unnecessarily ugly. Why

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-06 Thread Luiz K. Matsumura
Andrew Dunstan wrote: Luiz K. Matsumura wrote: Hi, I tried to use pg_dumpall in Win32 and receive a error message like this: pg_dump.exe: [archiver (db)] connection to database "test" failed: FATAL: user "'postgres'" does not exist Well, the word "'postgres'" is the word is between simple qu

Re: [PATCHES] pg_dumpall bug in PG 8.0b3 Win32 port

2004-10-05 Thread Andrew Dunstan
Luiz K. Matsumura wrote: Hi, I tried to use pg_dumpall in Win32 and receive a error message like this: pg_dump.exe: [archiver (db)] connection to database "test" failed: FATAL: user "'postgres'" does not exist Well, the word "'postgres'" is the word is between simple quotations marks and late