[PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Lee Kindness
Guys, attached is a patch to fix two memory leaks on start-up. The first is when freeaddrinfo has been used to free memory allocated by getaddrinfo2 (so freeaddrinfo2 should be used). The second is 2 leaks when creating the lock (PostgreSQL and socket) files. The diff is against last night's CVS H

[PATCHES] Czech NLS

2003-07-22 Thread Karel Zak
Hi, the patch contains complete messages transaltion of: libpq pg_controldata pg_resetxlog psql pg_dump pgscripts Beacuse this patch is a little greater than pgsql-patches list limit I put it to my FTP instead to mail attachement. Please, load it from following URL:

Re: [PATCHES] ruleutils with pretty-print option

2003-07-22 Thread Andreas Pflug
Bruce Momjian wrote: Andreas, looks good, but I need a diff -c, context diff. Hi Bruce, I intentionally only attached only non-context diffs because the patch is about 50 % size of the original file. Now, here's the same as context diff. Regards, Andreas Index: pg_proc.h ===

Re: [PATCHES] Release.sgml markup

2003-07-22 Thread Peter Eisentraut
Rod Taylor writes: > As for the brackets. Currently they are a part of the content in order > to achieve a specific style in the output of the resulting page. The > data could be tabular (items on left, names to right), different type of > bracket, removed entirely for different outputs, or perha

Re: [PATCHES] Release.sgml markup

2003-07-22 Thread Rod Taylor
On Tue, 2003-07-22 at 15:35, Peter Eisentraut wrote: > Rod Taylor writes: > > > As for the brackets. Currently they are a part of the content in order > > to achieve a specific style in the output of the resulting page. The > > data could be tabular (items on left, names to right), different type

Re: [PATCHES] Release.sgml markup

2003-07-22 Thread Peter Eisentraut
Rod Taylor writes: > Attached is the new file based on itemizedlists blocks, and simplelist > blocks for the names. I tried to apply this patch modulo the reservations I expressed, but it's impossible to sort out those parts. Apparently you used some automatic search and replace, because I find

Re: [PATCHES] timetravel.c

2003-07-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Böjthe Zoltán wrote: > Bruce Momjian ?rta

Re: [PATCHES] ruleutils with pretty-print option

2003-07-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Andreas Pflug wrote: > Bruce Momjian wrot

Re: [PATCHES] ruleutils with pretty-print option

2003-07-22 Thread Bruce Momjian
Andreas Pflug wrote: > Bruce Momjian wrote: > > >Andreas, looks good, but I need a diff -c, context diff. > > > > > > > Hi Bruce, > I intentionally only attached only non-context diffs because the patch > is about 50 % size of the original file. Now, here's the same as context > diff. I under

Re: [PATCHES] Release.sgml markup

2003-07-22 Thread Rod Taylor
On Tue, 2003-07-22 at 15:42, Peter Eisentraut wrote: > Rod Taylor writes: > > > Attached is the new file based on itemizedlists blocks, and simplelist > > blocks for the names. > > I tried to apply this patch modulo the reservations I expressed, but it's > impossible to sort out those parts. App

Re: [PATCHES] Adding Rendezvous support to postmaster

2003-07-22 Thread Bruce Momjian
Got it. Thanks for the testing. Patch attached and applied. --- Chris Campbell wrote: > OK, compiled and tested. Looks good. One modification to your patch: > there's a line that says "if (service_name != NULL)" -- that s

Re: [PATCHES] [GENERAL] Making pg_dump cvs friendly

2003-07-22 Thread Bruce Momjian
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 I will probably merge those two options into a single option. --- Jonathan Bartlett wrote: > I have created a patch to postgr

Re: [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Tom Lane
Lee Kindness <[EMAIL PROTECTED]> writes: > Guys, attached is a patch to fix two memory leaks on start-up. I do not like the changes to miscinit.c. In the first place, it is not a "memory leak" to do a one-time allocation of state for a proc_exit function. A bigger complaint is that your proposed

Re: [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Lee Kindness
Tom, happier with the attached patch? I'd have to disagree with regards to the memory leaks not being worth a mention - any such leak can cause problems when the PostgreSQL installation is either unattended, long-living andor has very high connection levels. Half a kilobyte on start-up isn't negli

Re: [PATCHES] PATCH: Memory leaks on start-up

2003-07-22 Thread Tom Lane
Lee Kindness <[EMAIL PROTECTED]> writes: > I'd have to disagree with regards to the memory leaks not being worth > a mention - any such leak can cause problems when the PostgreSQL > installation is either unattended, long-living andor has very high > connection levels. I don't see how. We are tal

Re: [PATCHES] [GENERAL] Making pg_dump cvs friendly

2003-07-22 Thread Jonathan Bartlett
Excellent! Thanks! JOn On Tue, 22 Jul 2003, Bruce Momjian wrote: > > This has been saved for the 7.5 release: > > http:/momjian.postgresql.org/cgi-bin/pgpatches2 > > I will probably merge those two options into a single option. > > -