Dear Robert,
> > (1) boolean-and and boolean-or aggregates named bool_and and bool_or.
> > they should correspond to standard sql every and some/any aggregates.
>
> Just a minor nibble, but could you add something to the documentation
> entries that these are postgresql implementation of the
On 5-May-04, at 2:26 AM, David Fetter wrote:
Here it is :)
Looks good for the most part. A few minor quibbles / suggestions:
- Where an example uses double-quotes in a function body, we ought to
change the example to use dollar quoting -- but if no doubled-quotes
are used, I think it's better to
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Andrew Dunstan wrote:
>> Shouldn't this be
>> if (toupper(*src) != toupper(*dst))
> Yep, fixed.
Also, all of the ctype.h calls need to be like
toupper((unsigned char) *src)
to avoid problems with high-bit-set characters.
Neil Conway wrote:
> On 5-May-04, at 2:26 AM, David Fetter wrote:
> > Here it is :)
>
> Looks good for the most part. A few minor quibbles / suggestions:
>
> - Where an example uses double-quotes in a function body, we ought to
> change the example to use dollar quoting -- but if no doubled-quot
On Wed, May 05, 2004 at 10:42:56AM -0400, Bruce Momjian wrote:
> Neil Conway wrote:
> > On 5-May-04, at 2:26 AM, David Fetter wrote:
> > > Here it is :)
> >
> > Looks good for the most part. A few minor quibbles / suggestions:
> >
> > - Where an example uses double-quotes in a function body, we o
David Fetter wrote:
On Wed, May 05, 2004 at 10:42:56AM -0400, Bruce Momjian wrote:
Neil Conway wrote:
On 5-May-04, at 2:26 AM, David Fetter wrote:
Here it is :)
Looks good for the most part. A few minor quibbles / suggestions:
- Where an example uses double-quotes in a funct
David Fetter wrote:
> You folks have commit privs, so please settle on something.
>
> Here's $.01 worth:
>
> It ought to be pretty clear in each example that the stuff between the
> $'s can be varied.
Yes, we need to show that it can be varied, but when we are trying to
illustrate another concep
On Wed, 2004-05-05 at 02:59, Fabien COELHO wrote:
>
> Dear Robert,
>
> > > (1) boolean-and and boolean-or aggregates named bool_and and bool_or.
> > > they should correspond to standard sql every and some/any aggregates.
> >
> > Just a minor nibble, but could you add something to the document
On 5-May-04, at 10:42 AM, Bruce Momjian wrote:
I disagree. I think swiching between single quote and $$ based on the
content is just too confusing. I would just use $$ in all cases unless
$$ appears in the function (which should be rare), in which case I
would
use $quote$ or something generic.
We
On 5-May-04, at 11:32 AM, Bruce Momjian wrote:
Yes, we need to show that it can be varied, but when we are trying to
illustrate another concept, we should show examples that highlight
that concept, not add additional complexity with showing we can put a
tag between $$. My guess is that if we show
Neil Conway wrote:
> On 5-May-04, at 10:42 AM, Bruce Momjian wrote:
> > I disagree. I think swiching between single quote and $$ based on the
> > content is just too confusing. I would just use $$ in all cases unless
> > $$ appears in the function (which should be rare), in which case I
> > would
On 6-May-04, at 12:41 AM, Bruce Momjian wrote:
OK. I am just afraid if we show 4 functions, and three use $$, and one
doesn't use single-quotes inside, so we quote with single-quotes, that
it would look strange.
Personally I don't think it would look that strange, but maybe that's
just me. Does a
Neil Conway wrote:
> On 6-May-04, at 12:41 AM, Bruce Momjian wrote:
> > OK. I am just afraid if we show 4 functions, and three use $$, and one
> > doesn't use single-quotes inside, so we quote with single-quotes, that
> > it would look strange.
>
> Personally I don't think it would look that stra
On Thu, May 06, 2004 at 12:47:46AM -0400, Bruce Momjian wrote:
> Neil Conway wrote:
> > On 6-May-04, at 12:41 AM, Bruce Momjian wrote:
> > > OK. I am just afraid if we show 4 functions, and three use $$,
> > > and one doesn't use single-quotes inside, so we quote with
> > > single-quotes, that it
14 matches
Mail list logo
