Re: [PATCHES] [HACKERS] pg_dump 'die_on_errors'

2004-08-15 Thread Philip Warner
At 02:32 PM 12/08/2004, Philip Warner wrote: >At 01:27 PM 12/08/2004, Bruce Momjian wrote: >Set client_min_messages to WARNING? > >Sounds like a plan. Attached patch sets client_min_messages as above and gives some context to errors messages, eg: pg_restore: [archiver (db)] Error from TOC Entry

[PATCHES] ALTER SCHEMA ... SET TABLESPACE

2004-08-15 Thread Gavin Sherry
This patch implements ALTER SCHEMA ... SET TABLESPACE. This changes the default schema tablespace but does not attempted to move objects within the schema to the new tablespace. Docs, regression test and tab-completion included. There were a few places which conflicted with my alter index patch

Re: [PATCHES] [HACKERS] pg_dump 'die_on_errors'

2004-08-15 Thread Tom Lane
Philip Warner <[EMAIL PROTECTED]> writes: > Attached patch sets client_min_messages as above and gives some > context to errors messages, eg: > pg_restore: [archiver (db)] Error from TOC Entry 19; 1255 16438403 FUNCTION foo() pjw > pg_restore: [archiver (db)] could not execute query: ERROR: no s

[PATCHES] compile fix for contrib/fuzzystrmatch

2004-08-15 Thread Richard Poole
I notice that contrib/fuzzystrmatch/dmetaphone.c doesn't compile cleanly as it stands - it mixes declarations in code, C++-style. The attached patch shifts declarations to the tops of functions and enables this file to compile cleanly as C. Richard Index: contrib/fuzzystrmatch/dmetaphone.c ===

Re: [PATCHES] CREATE DATABASE with tablespace fix

2004-08-15 Thread Bruce Momjian
Gavin Sherry wrote: > Attached is a patch resolving the issue raised here: > > http://groups.google.com.au/groups?q=tablespaces+group:comp.databases.postgresql.hackers&hl=en&lr=&ie=UTF-8&group=comp.databases.postgresql.hackers&scoring=d&selm=Pine.LNX.4.58.0407281411470.17889%40linuxworld.com.au&rn

Re: [PATCHES] CREATE DATABASE with tablespace fix

2004-08-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I am a little confused why we can't just merge the directories? The > relfilenodes would guarantee that the files are unique, right? Actually not: there is no uniqueness check on relfilenode beyond the indirect one of the files having to live in the sam

Re: [PATCHES] CREATE DATABASE with tablespace fix

2004-08-15 Thread Bruce Momjian
Added to open items: * fix case where template db already uses target tablespace --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I am a little confused why we can't just merge the directories?

Re: [PATCHES] [HACKERS] pg_dump 'die_on_errors'

2004-08-15 Thread Philip Warner
At 01:32 AM 16/08/2004, Tom Lane wrote: It'd be substantially *more* helpful if it reported the failing command. They are two different problems; the TOC entry is important for any multiline command or to rerun the command easily later. Whereas displaying the failed SQL command is a matter of fi

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Bruce Momjian
OK, I have cleaned up this code and clarified the comment. Attached and applied. --- Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > > > > /* > >+ * Sometime the child

Re: [PATCHES] Postgresql.conf Documentation change

2004-08-15 Thread Bruce Momjian
What would people like done with this patch? A sample section is: ! datestyle = 'iso, mdy' ! #timezone = {enviroment}# actually, defaults to TZ environment setting ! # set at initdb time ! australian_timezones = false ! extra_float_digits = 0 # mi

Re: [PATCHES] psql tab-complete patch #3

2004-08-15 Thread Bruce Momjian
It is great you looked over the tab code and got it up to date. Yea, there are some enhancements in the patch, but it seems safe enough to get in. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied a

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > /* >* We emulate fgets() behaviour. So if there is no newline >* at the end, we add one... >*/ > ! if (line[len-1] != '\n') >

Re: [PATCHES] Add GUC_REPORT to server_encoding, integer_datetimes

2004-08-15 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > This adds GUC_REPORT to server_encoding and integer_datetimes so they > are reported in the V3 protocol startup packet. Also some related doc > updates. Applied (with some further hacking on the docs). regards, tom lane --

Re: [PATCHES] Win32 fix for pg_dumpall

2004-08-15 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > /* > > * We emulate fgets() behaviour. So if there is no newline > > * at the end, we add one... > > */ > > ! if (line[len-1

Re: [PATCHES] fix schema ownership on first connection preliminary

2004-08-15 Thread Bruce Momjian
Added to TODO: * Set proper permissions on non-system schemas during db creation Currently all schemas are owned by the super-user because they are copied from the template1 database. --