Re: [PATCHES] Win32 psql fix

2004-10-19 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 18 October 2004 18:37 > To: Dave Page > Cc: PostgreSQL-patches > Subject: Re: [PATCHES] Win32 psql fix > > "Dave Page" <[EMAIL PROTECTED]> writes: > > The attached patch fixes psql's win32 frontend-only build, by

[PATCHES] Updated Turkish translations

2004-10-19 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, http://www.gunduz.org/postgresql/translation/PostgreSQL-8.0/PgSQL-DilDosyalari/pg_config-tr.po is the updated pg_config translation. Also, the following are initial translations for libpq and pg_dump: http://www.gunduz.org/postgresql/translation/Pos

Re: [PATCHES] [HACKERS] Open Items

2004-10-19 Thread Zeugswetter Andreas DAZ SD
> >>o fix shared memory on Win2k terminal server > >> > >>We might be able to just mark this as not supported. > > > >I have attached a patch that I think fixes this. The problem I saw > >and fixed is, that the shmem created in a terminal services client is not > >visible to the console

Re: [PATCHES] [HACKERS] strange result from contrib/seg regression on windows

2004-10-19 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Does anyone have a clue why? Evidently your sscanf isn't setting errno for overflow --- look at seg_atof() in segparse.y. This code shows several other signs of severe brain death, actually, like leaking 256 bytes on each call for

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a revised patch. Changes: Looks reasonable to me. Just one comment: should the -fno-strict-aliasing probe be inside the "if test "$GCC" = yes" part? It effectively was in the original. > BTW, since we're on the topic of compiler options, is t

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > -Wstrict-prototypes causes a few distinct warnings but they are emitted > repeatedly. At least one does not seem easily solvable: > expression_tree_walker() and friends declare the callback function as > bool (*walker) (), but it seems a pain to make that t

Re: [PATCHES] pg_regress --temp-keep

2004-10-19 Thread Fabien COELHO
Dear Tom, Improving the performance would require to fix the install script so that it can handle more than one argument at once, and/or use a more or less standard "install" program when available. We used to try to use the "standard" install program when available. After sufficient bitter experie

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Peter Eisentraut
Neil Conway wrote: > Attached is a revised patch. Changes: Another word from the wise: Never write "recent" in code designed for longevity. :) > BTW, since we're on the topic of compiler options, is there a reason > we don't use -g3 with GCC when --enable-debug is specified? It seems > worth usi

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Alvaro Herrera
On Tue, Oct 19, 2004 at 07:40:56PM +0200, Peter Eisentraut wrote: > I'm already not so happy about the new warning options, because they > make the compile lines too long. How's that for an argument? ;-) There's a better solution: use an approach similar to that used in the Linux kernel, which e

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > There's a better solution: use an approach similar to that used in the > Linux kernel, which echoes only the object name that's currently being > compiled. If I'm reading this correctly, it requires replacing every default build rule with our own hacked

Re: [PATCHES] pg_regress --temp-keep

2004-10-19 Thread Reini Urban
Fabien COELHO schrieb: Improving the performance would require to fix the install script so that it can handle more than one argument at once, and/or use a more or less standard "install" program when available. We used to try to use the "standard" install program when available. After sufficient

[PATCHES] Translation updates for 8.0: initdb-ru, pg_config-ru

2004-10-19 Thread Serguei Mokhov
Hello Peter, Please install the attached updates for 8.0. Please add 'ru' to AVAIL_LANGUAGES in nls.mk for pg_config. More to come. Thanks, -s PS: your NLS status page, the 2nd table for 7.4 branch was not refreshed. initdb-ru.po.gz Description: GNU Zip compressed data pg_config.po.gz Descri

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Gaetano Mendola
Tom Lane wrote: Neil Conway <[EMAIL PROTECTED]> writes: -Wpointer-arith might be worth enabling. I'll add it to the GCC CFLAGS in the next patch I send in. If PG builds cleanly or nearly so with it on, by all means. As you said, -Wcast-align can't be enabled in general at the moment because it fl

Re: [PATCHES] [CYGWIN] Where is the link to cygwin?

2004-10-19 Thread Reini Urban
Marek Lewczuk schrieb: Reini Urban wrote: Richard Sydney-Smith schrieb: A new initd script will come with 8.0, which just calls pg_ctl and adds service install/uninstall args. Reini, a few days ago you wrote that you are working on plperl patch for cygwin - how are doing with this ? well, bruce s

Re: [PATCHES] additional GCC warning flags

2004-10-19 Thread Neil Conway
On Wed, 2004-10-20 at 02:07, Tom Lane wrote: > Looks reasonable to me. Just one comment: should the > -fno-strict-aliasing probe be inside the "if test "$GCC" = yes" part? > It effectively was in the original. Yeah, makes sense. Patch applied with this fix and Peter's suggested improvement to a c